From: James Morris <jmorris@namei.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Kees Cook <keescook@chromium.org>,
Micah Morton <mortonm@chromium.org>,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] LSM: fix return value check in safesetid_init_securityfs()
Date: Wed, 13 Feb 2019 06:01:41 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1902130601300.15293@namei.org> (raw)
In-Reply-To: <20190212075831.114668-1-weiyongjun1@huawei.com>
On Tue, 12 Feb 2019, Wei Yongjun wrote:
> In case of error, the function securityfs_create_dir() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: aeca4e2ca65c ("LSM: add SafeSetID module that gates setid calls")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2019-02-12 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:58 [PATCH -next] LSM: fix return value check in safesetid_init_securityfs() Wei Yongjun
2019-02-12 16:55 ` Kees Cook
2019-02-12 19:01 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1902130601300.15293@namei.org \
--to=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=serge@hallyn.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).