From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: dhowells@redhat.com, "Jarkko Sakkinen" <jarkko@kernel.org>,
"Eric Snowberg" <eric.snowberg@oracle.com>,
"Mickaël Salaün" <mic@linux.microsoft.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] Add EFI_CERT_X509_GUID support for dbx/mokx entries
Date: Tue, 23 Feb 2021 17:44:30 +0000 [thread overview]
Message-ID: <3493921.1614102270@warthog.procyon.org.uk> (raw)
In-Reply-To: <1323922.1612970030@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> This set of patches from Eric Snowberg that add support for
> EFI_CERT_X509_GUID entries in the dbx and mokx UEFI tables (such entries
> cause matching certificates to be rejected). These are currently ignored
> and only the hash entries are made use of.
>
> These patches fix CVE-2020-26541.
>
> To quote Eric:
>
> This is the fifth patch series for adding support for
> EFI_CERT_X509_GUID entries [1]. It has been expanded to not only
> include dbx entries but also entries in the mokx. Additionally my
> series to preload these certificate [2] has also been included.
>
> This series is based on v5.11-rc4.
>
> [1] https://patchwork.kernel.org/project/linux-security-module/patch/20200916004927.64276-1-eric.snowberg@oracle.com/
> [2] https://lore.kernel.org/patchwork/cover/1315485/
>
> Note that this is based on top of the collected minor fixes I sent you a
> preceding pull request for. If you would rather this was not based on my
> keys-misc branch, but was instead based on your tree directly, I can rebase
> it. Note that there would be very minor conflict between the two branches,
> but I think git merge should be able to handle it automatically.
Please drop this request for now. It turns out there's a broken dependency
in there:
https://lore.kernel.org/keyrings/20210217165058.1336155-1-eric.snowberg@oracle.com/
I'll look at folding that in, but I'm not sure Eric's solution is the right
one. I suspect there needs to be something in Kconfig somewhere.
David
next prev parent reply other threads:[~2021-02-23 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 15:13 [GIT PULL] Add EFI_CERT_X509_GUID support for dbx/mokx entries David Howells
2021-02-10 15:17 ` David Howells
2021-02-23 17:44 ` David Howells [this message]
2021-03-11 17:05 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3493921.1614102270@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@linux.microsoft.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).