actx not used?

actx not used?

[Richard Guy Briggs]

Hello users of *audit_rule_match(),

As far as I can tell, it appears that the audit_context *actx parameter
to *audit_rule_match() is not used by any consumers in-tree upstream.
This includes selinux, apparmour, integrity and smack.
Might there be others out of tree that do use it (or did request it)?

I'm a bit puzzled that it was ever offered since it should be relatively
opaque and accessed only by audit or its accessor functions.

It was part of the 2008 commit 03d37d25e0f9 ("LSM/Audit: Introduce
generic Audit LSM hooks").

Would anyone object if I ripped out actx?

- RGB

--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

Re: actx not used?

[Casey Schaufler]

On 1/30/2019 4:58 PM, Richard Guy Briggs wrote:
> Hello users of *audit_rule_match(),
>
> As far as I can tell, it appears that the audit_context *actx parameter
> to *audit_rule_match() is not used by any consumers in-tree upstream.
> This includes selinux, apparmour, integrity and smack.
> Might there be others out of tree that do use it (or did request it)?
>
> I'm a bit puzzled that it was ever offered since it should be relatively
> opaque and accessed only by audit or its accessor functions.
>
> It was part of the 2008 commit 03d37d25e0f9 ("LSM/Audit: Introduce
> generic Audit LSM hooks").
>
> Would anyone object if I ripped out actx?

I don't see any reason to keep it based on what I see.
I don't see what it was supposed to be for, either.

> - RGB
>
> --
> Richard Guy Briggs <rgb@redhat.com>
> Sr. S/W Engineer, Kernel Security, Base Operating Systems
> Remote, Ottawa, Red Hat Canada
> IRC: rgb, SunRaycer
> Voice: +1.647.777.2635, Internal: (81) 32635
>

Re: actx not used?

[Paul Moore]

On Wed, Jan 30, 2019 at 7:59 PM Richard Guy Briggs <rgb@redhat.com> wrote:
> Hello users of *audit_rule_match(),
>
> As far as I can tell, it appears that the audit_context *actx parameter
> to *audit_rule_match() is not used by any consumers in-tree upstream.
> This includes selinux, apparmour, integrity and smack.
> Might there be others out of tree that do use it (or did request it)?

I'm not aware of any work-in-progress that would make use of it, so if
it isn't used by anything in-tree, go ahead and get rid of it.  If we
need it again in the future for some reason we can always add it back.

-- 
paul moore
www.paul-moore.com