From: Mimi Zohar <zohar@linux.ibm.com>
To: Jiele Zhao <unclexiaole@gmail.com>
Cc: jmorris@namei.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] integrity: Add declarations to init_once void arguments.
Date: Fri, 09 Apr 2021 14:55:11 -0400 [thread overview]
Message-ID: <cb640adf4fe93e054d7a8c148fea601048bfd562.camel@linux.ibm.com> (raw)
In-Reply-To: <20210407014438.39516-1-unclexiaole@gmail.com>
Hi Jiele,
On Wed, 2021-04-07 at 01:44 +0000, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> ---
> security/integrity/iint.c | 2 +-
> security/integrity/ima/ima_main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 0ba01847e836..fca8a9409e4a 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -160,7 +160,7 @@ void integrity_inode_free(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct integrity_iint_cache *iint = foo;
> + struct integrity_iint_cache *iint = (struct integrity_iint_cache *) foo;
>
> memset(iint, 0, sizeof(*iint));
> iint->ima_file_status = INTEGRITY_UNKNOWN;
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9ef748ea829f..03bef720ab44 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -482,7 +482,7 @@ int ima_bprm_check(struct linux_binprm *bprm)
> }
>
> /**
> - * ima_path_check - based on policy, collect/store measurement.
> + * ima_file_check - based on policy, collect/store measurement.
> * @file: pointer to the file to be measured
> * @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND
> *
This change was already posted as "ima: Fix function name error in
comment". I've dropped this hunk. In the future, please review your
patch line by line before posting.
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
next-integrity
thanks,
Mimi
next prev parent reply other threads:[~2021-04-09 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 1:44 [PATCH v2] integrity: Add declarations to init_once void arguments Jiele Zhao
2021-04-09 1:24 ` Jiele Zhao
2021-04-09 18:55 ` Mimi Zohar [this message]
2021-04-10 3:19 ` Jiele Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb640adf4fe93e054d7a8c148fea601048bfd562.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=unclexiaole@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).