* [PATCH 0/1] keys: seq_file .next functions should increase position index
@ 2020-01-24 6:25 Vasily Averin
0 siblings, 0 replies; only message in thread
From: Vasily Averin @ 2020-01-24 6:25 UTC (permalink / raw)
To: keyrings, linux-security-module
Cc: David Howells, Jarkko Sakkinen, James Morris, Serge E. Hallyn
In Aug 2018 NeilBrown noticed
commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
"Some ->next functions do not increment *pos when they return NULL...
Note that such ->next functions are buggy and should be fixed.
A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps"
Described problem is still actual. If you make lseek into middle of last output line
following read will output end of last line and whole last line once again.
$ dd if=/proc/swaps bs=1 # usual output
Filename Type Size Used Priority
/dev/dm-0 partition 4194812 97536 -2
104+0 records in
104+0 records out
104 bytes copied
$ dd if=/proc/swaps bs=40 skip=1 # last line was generated twice
dd: /proc/swaps: cannot skip to specified offset
v/dm-0 partition 4194812 97536 -2
/dev/dm-0 partition 4194812 97536 -2
3+1 records in
3+1 records out
131 bytes copied
There are lot of other affected files, I've found 30+ including
/proc/net/ip_tables_matches and /proc/sysvipc/*
Following patch fixes the problem in keys-related file.
https://bugzilla.kernel.org/show_bug.cgi?id=206283
Vasily Averin (1):
proc_keys_next should increase position index
security/keys/proc.c | 2 ++
1 file changed, 2 insertions(+)
--
1.8.3.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-24 6:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-24 6:25 [PATCH 0/1] keys: seq_file .next functions should increase position index Vasily Averin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).