From: Greg KH <gregkh@linuxfoundation.org>
To: Fugang Duan <fugang.duan@nxp.com>
Cc: linux-serial@vger.kernel.org, lukas@wunner.de,
s.hauer@pengutronix.de, kernel@pengutronix.de, jslaby@suse.com
Subject: Re: [PATCH tty/serial v2 1/1] tty: serial: imx: enable imx serial console port as module
Date: Fri, 17 Jul 2020 10:58:12 +0200 [thread overview]
Message-ID: <20200717085812.GA1457960@kroah.com> (raw)
In-Reply-To: <20200717081827.3417-1-fugang.duan@nxp.com>
On Fri, Jul 17, 2020 at 04:18:27PM +0800, Fugang Duan wrote:
> GKI kernel requires drivers built as modules including
> console driver, so add the support that imx serial console
> driver can be built as module.
>
> The changes of the patch:
> - imx console driver can be built as module.
> - move out earlycon code to separated driver like imx_earlycon.c,
> and imx earlycon driver only support build-in.
>
> v2:
> - fix kbuild error
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/tty/serial/Kconfig | 18 +++++++----
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/imx.c | 37 ++---------------------
> drivers/tty/serial/imx_earlycon.c | 50 +++++++++++++++++++++++++++++++
> 4 files changed, 66 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 780908d43557..dabd06ca9b66 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -502,20 +502,28 @@ config SERIAL_IMX
> can enable its onboard serial port by enabling this option.
>
> config SERIAL_IMX_CONSOLE
> - bool "Console on IMX serial port"
> - depends on SERIAL_IMX=y
> + tristate "Console on IMX serial port"
> + depends on SERIAL_IMX
> select SERIAL_CORE_CONSOLE
> - select SERIAL_EARLYCON if OF
> help
> If you have enabled the serial port on the Freescale IMX
> - CPU you can make it the console by answering Y to this option.
> + CPU you can make it the console by answering Y/M to this option.
>
> - Even if you say Y here, the currently visible virtual console
> + Even if you say Y/M here, the currently visible virtual console
> (/dev/tty0) will still be used as the system console by default, but
> you can alter that using a kernel command line option such as
> "console=ttymxc0". (Try "man bootparam" or see the documentation of
> your bootloader about how to pass options to the kernel at boot time.)
>
> +config SERIAL_IMX_EARLYCON
> + bool "Earlycon on IMX serial port"
> + depends on OF
> + select SERIAL_EARLYCON
> + default y
Only put "default y" if you can not boot a machine without this.
Otherwise leave the default line off, it will be 'n' and can be selected
if a user wants that.
That should be the case here, please change this.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-17 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:18 [PATCH tty/serial v2 1/1] tty: serial: imx: enable imx serial console port as module Fugang Duan
2020-07-17 8:58 ` Greg KH [this message]
2020-07-17 9:33 ` [EXT] " Andy Duan
2020-07-17 9:41 ` Greg KH
2020-07-17 9:43 ` Andy Duan
2020-07-17 8:59 ` Greg KH
2020-07-17 9:41 ` [EXT] " Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717085812.GA1457960@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fugang.duan@nxp.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).