From: Andy Duan <fugang.duan@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"lukas@wunner.de" <lukas@wunner.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"jslaby@suse.com" <jslaby@suse.com>
Subject: RE: [EXT] Re: [PATCH tty/serial v2 1/1] tty: serial: imx: enable imx serial console port as module
Date: Fri, 17 Jul 2020 09:41:05 +0000 [thread overview]
Message-ID: <AM6PR0402MB36074D3821E7B188F3E987D1FF7C0@AM6PR0402MB3607.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200717085900.GB1457960@kroah.com>
From: Greg KH <gregkh@linuxfoundation.org> Sent: Friday, July 17, 2020 4:59 PM
> On Fri, Jul 17, 2020 at 04:18:27PM +0800, Fugang Duan wrote:
> > GKI kernel requires drivers built as modules including console driver,
> > so add the support that imx serial console driver can be built as
> > module.
>
> No one knows what "GKI" is, and it isn't relevant here.
The Next Generation Android Device kernel will consist of generic
Kernel Image (GKI) and several GKI modules, and drivers for specific
hardware (possibly closed-source drivers) will be loaded as kernel modules.
In short, in this scenario, everything soc vendor driver is modularized.
Anyway, it isn't relevant here. Will delete the information in v3.
>
> >
> > The changes of the patch:
> > - imx console driver can be built as module.
> > - move out earlycon code to separated driver like imx_earlycon.c,
> > and imx earlycon driver only support build-in.
>
> Why is this not 2 separate patches?
It can be split into 2 separated patches, will update it in v3.
>
> > v2:
> > - fix kbuild error
>
> These v2: stuff should go below the --- line.
Got it, thanks for your comments.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2020-07-17 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:18 [PATCH tty/serial v2 1/1] tty: serial: imx: enable imx serial console port as module Fugang Duan
2020-07-17 8:58 ` Greg KH
2020-07-17 9:33 ` [EXT] " Andy Duan
2020-07-17 9:41 ` Greg KH
2020-07-17 9:43 ` Andy Duan
2020-07-17 8:59 ` Greg KH
2020-07-17 9:41 ` Andy Duan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0402MB36074D3821E7B188F3E987D1FF7C0@AM6PR0402MB3607.eurprd04.prod.outlook.com \
--to=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).