* [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static
@ 2020-09-12 3:38 Jason Yan
2020-09-14 5:29 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-09-12 3:38 UTC (permalink / raw)
To: timur, gregkh, jirislaby, linux, leoyang.li, linuxppc-dev, linux-serial
Cc: Jason Yan, Hulk Robot
This eliminates the following sparse warning:
drivers/tty/serial/ucc_uart.c:286:6: warning: symbol 'qe_uart_set_mctrl'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/tty/serial/ucc_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 3c8c662c69e2..d6a8604157ab 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -283,7 +283,7 @@ static unsigned int qe_uart_tx_empty(struct uart_port *port)
* don't need that support. This function must exist, however, otherwise
* the kernel will panic.
*/
-void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
+static void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
{
}
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static
2020-09-12 3:38 [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static Jason Yan
@ 2020-09-14 5:29 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2020-09-14 5:29 UTC (permalink / raw)
To: Jason Yan, timur, gregkh, linux, leoyang.li, linuxppc-dev, linux-serial
Cc: Hulk Robot
On 12. 09. 20, 5:38, Jason Yan wrote:
> This eliminates the following sparse warning:
>
> drivers/tty/serial/ucc_uart.c:286:6: warning: symbol 'qe_uart_set_mctrl'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Sure:
Acked-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/ucc_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
> index 3c8c662c69e2..d6a8604157ab 100644
> --- a/drivers/tty/serial/ucc_uart.c
> +++ b/drivers/tty/serial/ucc_uart.c
> @@ -283,7 +283,7 @@ static unsigned int qe_uart_tx_empty(struct uart_port *port)
> * don't need that support. This function must exist, however, otherwise
> * the kernel will panic.
> */
> -void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
> +static void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
> {
> }
>
>
--
js
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-14 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 3:38 [PATCH] serial: ucc_uart: make qe_uart_set_mctrl() static Jason Yan
2020-09-14 5:29 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).