* [PATCH] tty: serial: imx: enable eralycon by default if IMX_SERIAL_CONSOLE is enabled
@ 2020-11-05 14:28 Lucas Stach
2020-11-05 15:41 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2020-11-05 14:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: Fugang Duan, linux-serial, patchwork-lst, kernel
Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon
part of imx serial is a separate driver and isn't necessarily enabled anymore
when the console is enabled. This causes users to loose the earlycon
functionality when upgrading their kenrel configuration via oldconfig.
Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.
Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1044fc387691..28f22e58639c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -522,6 +522,7 @@ config SERIAL_IMX_EARLYCON
depends on OF
select SERIAL_EARLYCON
select SERIAL_CORE_CONSOLE
+ default y if SERIAL_IMX_CONSOLE
help
If you have enabled the earlycon on the Freescale IMX
CPU you can make it the earlycon by answering Y to this option.
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: serial: imx: enable eralycon by default if IMX_SERIAL_CONSOLE is enabled
2020-11-05 14:28 [PATCH] tty: serial: imx: enable eralycon by default if IMX_SERIAL_CONSOLE is enabled Lucas Stach
@ 2020-11-05 15:41 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2020-11-05 15:41 UTC (permalink / raw)
To: Lucas Stach
Cc: Greg Kroah-Hartman, Jiri Slaby, Fugang Duan, linux-serial,
patchwork-lst, Sascha Hauer
Hi Lucas,
On Thu, Nov 5, 2020 at 11:29 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon
> part of imx serial is a separate driver and isn't necessarily enabled anymore
> when the console is enabled. This causes users to loose the earlycon
> functionality when upgrading their kenrel configuration via oldconfig.
>
> Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.
>
> Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Thanks for the fix:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
In the Subject: s/eralycon/earlycon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-05 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 14:28 [PATCH] tty: serial: imx: enable eralycon by default if IMX_SERIAL_CONSOLE is enabled Lucas Stach
2020-11-05 15:41 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).