* [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API
@ 2021-01-03 3:54 Yangtao Li
2021-01-04 18:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2021-01-03 3:54 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park, cw00.choi, krzk, shawnguo, s.hauer,
kernel, festevam, linux-imx, digetx, thierry.reding, jonathanh,
yuq825, airlied, daniel, robdclark, sean, robh, tomeu.vizoso,
steven.price, alyssa.rosenzweig, stanimir.varbanov, agross,
bjorn.andersson, mchehab, lukasz.luba, adrian.hunter,
ulf.hansson, vireshk, nm, sboyd, broonie, gregkh, jirislaby, rjw,
jcrouse, hoegsberg, eric, tzimmermann, marijn.suijten,
gustavoars, emil.velikov, jonathan, akhilpo, smasetty, airlied,
masneyb, kalyan_t, tanmay, tiny.windzz, ddavenport, jsanka,
rnayak, tongtiangen, miaoqinglang, khsieh, abhinavk, chandanu,
groeck, varar, mka, harigovi, rikard.falkeborn, natechancellor,
georgi.djakov, akashast, parashar, dianders
Cc: linux-pm, linux-kernel, linux-samsung-soc, linux-arm-kernel,
linux-tegra, dri-devel, lima, linux-arm-msm, freedreno,
linux-media, linux-mmc, linux-spi, linux-serial
Use devm_pm_opp_* API to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/memory/tegra/tegra30-emc.c | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
index 44ac155936aa..a93d8c3629fe 100644
--- a/drivers/memory/tegra/tegra30-emc.c
+++ b/drivers/memory/tegra/tegra30-emc.c
@@ -1483,31 +1483,31 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc)
static int tegra_emc_opp_table_init(struct tegra_emc *emc)
{
u32 hw_version = BIT(tegra_sku_info.soc_speedo_id);
- struct opp_table *clk_opp_table, *hw_opp_table;
+ struct opp_table *opp_table;
int err;
- clk_opp_table = dev_pm_opp_set_clkname(emc->dev, NULL);
- err = PTR_ERR_OR_ZERO(clk_opp_table);
+ opp_table = devm_pm_opp_set_clkname(emc->dev, NULL);
+ err = PTR_ERR_OR_ZERO(opp_table);
if (err) {
dev_err(emc->dev, "failed to set OPP clk: %d\n", err);
return err;
}
- hw_opp_table = dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1);
- err = PTR_ERR_OR_ZERO(hw_opp_table);
+ opp_table = devm_pm_opp_set_supported_hw(emc->dev, &hw_version, 1);
+ err = PTR_ERR_OR_ZERO(opp_table);
if (err) {
dev_err(emc->dev, "failed to set OPP supported HW: %d\n", err);
- goto put_clk_table;
+ return err;
}
- err = dev_pm_opp_of_add_table(emc->dev);
+ err = devm_pm_opp_of_add_table(emc->dev);
if (err) {
if (err == -ENODEV)
dev_err(emc->dev, "OPP table not found, please update your device tree\n");
else
dev_err(emc->dev, "failed to add OPP table: %d\n", err);
- goto put_hw_table;
+ return err;
}
dev_info(emc->dev, "OPP HW ver. 0x%x, current clock rate %lu MHz\n",
@@ -1515,19 +1515,8 @@ static int tegra_emc_opp_table_init(struct tegra_emc *emc)
/* first dummy rate-set initializes voltage state */
err = dev_pm_opp_set_rate(emc->dev, clk_get_rate(emc->clk));
- if (err) {
+ if (err)
dev_err(emc->dev, "failed to initialize OPP clock: %d\n", err);
- goto remove_table;
- }
-
- return 0;
-
-remove_table:
- dev_pm_opp_of_remove_table(emc->dev);
-put_hw_table:
- dev_pm_opp_put_supported_hw(hw_opp_table);
-put_clk_table:
- dev_pm_opp_put_clkname(clk_opp_table);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API
2021-01-03 3:54 [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API Yangtao Li
@ 2021-01-04 18:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-01-04 18:06 UTC (permalink / raw)
To: Yangtao Li
Cc: myungjoo.ham, kyungmin.park, cw00.choi, shawnguo, s.hauer,
kernel, festevam, linux-imx, digetx, thierry.reding, jonathanh,
yuq825, airlied, daniel, robdclark, sean, robh, tomeu.vizoso,
steven.price, alyssa.rosenzweig, stanimir.varbanov, agross,
bjorn.andersson, mchehab, lukasz.luba, adrian.hunter,
ulf.hansson, vireshk, nm, sboyd, broonie, gregkh, jirislaby, rjw,
jcrouse, hoegsberg, eric, tzimmermann, marijn.suijten,
gustavoars, emil.velikov, jonathan, akhilpo, smasetty, airlied,
masneyb, kalyan_t, tanmay, ddavenport, jsanka, rnayak,
tongtiangen, miaoqinglang, khsieh, abhinavk, chandanu, groeck,
varar, mka, harigovi, rikard.falkeborn, natechancellor,
georgi.djakov, akashast, parashar, dianders, linux-pm,
linux-kernel, linux-samsung-soc, linux-arm-kernel, linux-tegra,
dri-devel, lima, linux-arm-msm, freedreno, linux-media,
linux-mmc, linux-spi, linux-serial
On Sun, Jan 03, 2021 at 03:54:15AM +0000, Yangtao Li wrote:
> Use devm_pm_opp_* API to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/memory/tegra/tegra30-emc.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-04 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03 3:54 [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API Yangtao Li
2021-01-04 18:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).