[PATCH -repost] kgdb: depends on VT

[PATCH -repost] kgdb: depends on VT

[Jiri Slaby]

With VT=n, the kernel build fails with:
drivers/built-in.o: In function `kgdboc_pre_exp_handler':
kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console'
kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons'
kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons'

kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make
KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: "Jim Davis" <jim.epost@gmail.com>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: <kgdb-bugreport@lists.sourceforge.net>
Cc: <linux-serial@vger.kernel.org>
---
 lib/Kconfig.kgdb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.kgdb b/lib/Kconfig.kgdb
index c635a107a7de..533f912638ed 100644
--- a/lib/Kconfig.kgdb
+++ b/lib/Kconfig.kgdb
@@ -22,7 +22,7 @@ config KGDB_SERIAL_CONSOLE
 	tristate "KGDB: use kgdb over the serial console"
 	select CONSOLE_POLL
 	select MAGIC_SYSRQ
-	depends on TTY
+	depends on TTY && HW_CONSOLE
 	default y
 	help
 	  Share a serial console with kgdb. Sysrq-g must be used
-- 
2.7.4

Re: [PATCH -repost] kgdb: depends on VT

[Jason Wessel]

On 03/31/2016 03:29 AM, Jiri Slaby wrote:
> With VT=n, the kernel build fails with:
> drivers/built-in.o: In function `kgdboc_pre_exp_handler':
> kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console'
> kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons'
> kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons'
>
> kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make
> KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols.

Acked-by: Jason Wessel <jason.wessel@windriver.com>


I'll put this in the kgdb-next branch and submit it to the upstream, unless it gets merged in another queue.

Thanks!
Jason.

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140

Re: [PATCH -repost] kgdb: depends on VT

[Jiri Slaby]

On 03/31/2016, 02:01 PM, Jason Wessel wrote:
> On 03/31/2016 03:29 AM, Jiri Slaby wrote:
>> With VT=n, the kernel build fails with:
>> drivers/built-in.o: In function `kgdboc_pre_exp_handler':
>> kgdboc.c:(.text+0x7b5aa): undefined reference to `fg_console'
>> kgdboc.c:(.text+0x7b5ce): undefined reference to `vc_cons'
>> kgdboc.c:(.text+0x7b5d5): undefined reference to `vc_cons'
>>
>> kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make
>> KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols.
> 
> Acked-by: Jason Wessel <jason.wessel@windriver.com>
> 
> 
> I'll put this in the kgdb-next branch and submit it to the upstream,
> unless it gets merged in another queue.

Nobody else seemed to put it in any queue. And since it haven't appeared
in -next, it seems neither you did?

thanks,
-- 
js
suse labs