From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Mark Brown" <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v2] serial: max310x: rework RX interrupt handling
Date: Thu, 1 Oct 2020 14:35:31 +0300 [thread overview]
Message-ID: <CAHp75VdJBj_1j6JtA7wtbJ4Ji_s5sdjxunckv7mBHsxXE+t7Aw@mail.gmail.com> (raw)
In-Reply-To: <20201001074415.349739-1-thomas.petazzoni@bootlin.com>
On Thu, Oct 1, 2020 at 10:44 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Currently, the RX interrupt logic uses the RXEMPTY interrupt, with the
> RXEMPTYINV bit set, which means we get an RX interrupt as soon as the
> RX FIFO is non-empty.
>
> However, with the MAX310X having a FIFO of 128 bytes, this makes very
> poor use of the FIFO: we trigger an interrupt as soon as the RX FIFO
> has one byte, which means a lot of interrupts, each only collecting a
> few bytes from the FIFO, causing a significant CPU load.
>
> Instead this commit relies on two other RX interrupt events:
>
> - MAX310X_IRQ_RXFIFO_BIT, which triggers when the RX FIFO has reached
> a certain threshold, which we define to be half of the FIFO
> size. This ensure we get an interrupt before the RX FIFO fills up.
>
> - MAX310X_LSR_RXTO_BIT, which triggers when the RX FIFO has received
> some bytes, and then no more bytes are received for a certain
> time. Arbitrarily, this time is defined to the time is takes to
> receive 4 characters.
>
> On a Microchip SAMA5D3 platform that is receiving 20 bytes every 16ms
> over one MAX310X UART, this patch has allowed to reduce the CPU
> consumption of the interrupt handler thread from ~25% to 6-7%.
>
You missed my tag :-(
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Changes since v1:
> - Fix missing space when closing a comment
> ---
> drivers/tty/serial/max310x.c | 29 ++++++++++++++++++++++++-----
> 1 file changed, 24 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> index 8434bd5a8ec7..21130af106bb 100644
> --- a/drivers/tty/serial/max310x.c
> +++ b/drivers/tty/serial/max310x.c
> @@ -1056,9 +1056,9 @@ static int max310x_startup(struct uart_port *port)
> max310x_port_update(port, MAX310X_MODE1_REG,
> MAX310X_MODE1_TRNSCVCTRL_BIT, 0);
>
> - /* Configure MODE2 register & Reset FIFOs*/
> - val = MAX310X_MODE2_RXEMPTINV_BIT | MAX310X_MODE2_FIFORST_BIT;
> - max310x_port_write(port, MAX310X_MODE2_REG, val);
> + /* Reset FIFOs */
> + max310x_port_write(port, MAX310X_MODE2_REG,
> + MAX310X_MODE2_FIFORST_BIT);
> max310x_port_update(port, MAX310X_MODE2_REG,
> MAX310X_MODE2_FIFORST_BIT, 0);
>
> @@ -1086,8 +1086,27 @@ static int max310x_startup(struct uart_port *port)
> /* Clear IRQ status register */
> max310x_port_read(port, MAX310X_IRQSTS_REG);
>
> - /* Enable RX, TX, CTS change interrupts */
> - val = MAX310X_IRQ_RXEMPTY_BIT | MAX310X_IRQ_TXEMPTY_BIT;
> + /*
> + * Let's ask for an interrupt after a timeout equivalent to
> + * the receiving time of 4 characters after the last character
> + * has been received.
> + */
> + max310x_port_write(port, MAX310X_RXTO_REG, 4);
> +
> + /*
> + * Make sure we also get RX interrupts when the RX FIFO is
> + * filling up quickly, so get an interrupt when half of the RX
> + * FIFO has been filled in.
> + */
> + max310x_port_write(port, MAX310X_FIFOTRIGLVL_REG,
> + MAX310X_FIFOTRIGLVL_RX(MAX310X_FIFO_SIZE / 2));
> +
> + /* Enable RX timeout interrupt in LSR */
> + max310x_port_write(port, MAX310X_LSR_IRQEN_REG,
> + MAX310X_LSR_RXTO_BIT);
> +
> + /* Enable LSR, RX FIFO trigger, CTS change interrupts */
> + val = MAX310X_IRQ_LSR_BIT | MAX310X_IRQ_RXFIFO_BIT | MAX310X_IRQ_TXEMPTY_BIT;
> max310x_port_write(port, MAX310X_IRQEN_REG, val | MAX310X_IRQ_CTS_BIT);
>
> return 0;
> --
> 2.26.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-01 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 7:44 [PATCH v2] serial: max310x: rework RX interrupt handling Thomas Petazzoni
2020-10-01 11:35 ` Andy Shevchenko [this message]
2020-10-28 16:20 ` Jan Kundrát
2020-10-28 17:06 ` Thomas Petazzoni
2020-10-28 17:14 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdJBj_1j6JtA7wtbJ4Ji_s5sdjxunckv7mBHsxXE+t7Aw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kundrat@cesnet.cz \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).