From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Changqi Hu <changqi.hu@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH 1/2] tty: serial: print earlycon info after match->setup
Date: Tue, 15 Sep 2020 01:27:20 +0800
Message-ID: <CAJMQK-iL6xvn96=WkRBwCeyV2NEe9uTJGY2Tntomnpouern5+A@mail.gmail.com> (raw)
In-Reply-To: <20200914160634.GL3956970@smile.fi.intel.com>
On Tue, Sep 15, 2020 at 12:06 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Sep 11, 2020 at 05:39:26PM +0800, Hsin-Yi Wang wrote:
> > 8250 devices may modify iotype in their own earlycon setup. For example:
> > 8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info
> > after match->setup to reflect actual earlycon info.
>
> But this means you do something which user didn't ask for...
>
8250_uniphier states that it can only use mmio32
https://elixir.bootlin.com/linux/v5.9-rc4/source/drivers/tty/serial/8250/8250_uniphier.c#L46
For MTK, may be the same case. So they are set in the driver.
> > +static void __init earlycon_info(struct earlycon_device *device)
>
> Can it be earlycon_pr_info() or earlycon_print_info() ?
>
Sure. I'll send a v2.
> --
> With Best Regards,
> Andy Shevchenko
>
>
prev parent reply index
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 9:39 Hsin-Yi Wang
2020-09-11 9:39 ` [PATCH 2/2] tty: serial: 8250_mtk: set regshift for mmio32 Hsin-Yi Wang
2020-09-14 16:06 ` [PATCH 1/2] tty: serial: print earlycon info after match->setup Andy Shevchenko
2020-09-14 17:27 ` Hsin-Yi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMQK-iL6xvn96=WkRBwCeyV2NEe9uTJGY2Tntomnpouern5+A@mail.gmail.com' \
--to=hsinyi@chromium.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changqi.hu@mediatek.com \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Serial Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
linux-serial@vger.kernel.org
public-inbox-index linux-serial
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git