* [PATCH] serial: samsung: Checks the return value of function
[not found] <CGME20210104082958epcas5p12c5c0e78dec7f106375b4f507a3b152b@epcas5p1.samsung.com>
@ 2021-01-04 8:35 ` Tamseel Shams
2021-01-04 10:03 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Tamseel Shams @ 2021-01-04 8:35 UTC (permalink / raw)
To: kgene, krzk, gregkh, jslaby
Cc: linux-arm-kernel, linux-samsung-soc, linux-serial, linux-kernel,
alim.akhtar, Tamseel Shams
"uart_add_one_port" function call may fail and return
some error code, so adding a check for return value.
If it is returning some error code, then displaying the
result and returning back from there.
Signed-off-by: Tamseel Shams <m.shams@samsung.com>
---
drivers/tty/serial/samsung_tty.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 6ef614d8648c..a220ba166ffe 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2072,7 +2072,11 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
}
dev_dbg(&pdev->dev, "%s: adding port\n", __func__);
- uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
+ ret = uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Failed to add uart port, err %d\n", ret);
+ return ret;
+ }
platform_set_drvdata(pdev, &ourport->port);
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: samsung: Checks the return value of function
2021-01-04 8:35 ` [PATCH] serial: samsung: Checks the return value of function Tamseel Shams
@ 2021-01-04 10:03 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-01-04 10:03 UTC (permalink / raw)
To: Tamseel Shams
Cc: kgene, krzk, jslaby, linux-arm-kernel, linux-samsung-soc,
linux-serial, linux-kernel, alim.akhtar
On Mon, Jan 04, 2021 at 02:05:51PM +0530, Tamseel Shams wrote:
> "uart_add_one_port" function call may fail and return
> some error code, so adding a check for return value.
> If it is returning some error code, then displaying the
> result and returning back from there.
>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> drivers/tty/serial/samsung_tty.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 6ef614d8648c..a220ba166ffe 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2072,7 +2072,11 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
> }
>
> dev_dbg(&pdev->dev, "%s: adding port\n", __func__);
> - uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> + ret = uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Failed to add uart port, err %d\n", ret);
> + return ret;
Why are you not unwinding the other logic that happened above? If this
fails, you need to properly do that as well, otherwise the driver is
still registered, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-04 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210104082958epcas5p12c5c0e78dec7f106375b4f507a3b152b@epcas5p1.samsung.com>
2021-01-04 8:35 ` [PATCH] serial: samsung: Checks the return value of function Tamseel Shams
2021-01-04 10:03 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).