[Bug] staging: rtl8723bs: Bluetooth stops working after patch: serial: 8250_dw: Do not reclock if already at correct rate

[Bug] staging: rtl8723bs: Bluetooth stops working after patch: serial: 8250_dw: Do not reclock if already at correct rate

[Philipp Hortmann]

Hi,

I have a ODYS Trendbook next 14 with the wlan/bluetooth module rtl8723bs.

Bluetooth stops working with the following commit:
commit e5d6bd25f93d6ae158bb4cd04956cb497a85b8ef (HEAD)
Author: Peter Collingbourne <pcc@google.com>
Date:   Thu Feb 22 11:26:34 2024 -0800
     serial: 8250_dw: Do not reclock if already at correct rate

Please find dmesg below. Module has issues to load firmware.

To enshure that this is the function breaking commit I applied the 
commit reversed on top of the latest kernel from the staging tree. Then 
bluetooth is working again.

I can support with further tests. I do not have a good proposal for a 
fix as I expect a lot of side effects. Please send me proposals for a 
fix. Comming Thursday I will be OOO.

Thanks for your support.

Bye Philipp


dmesg when not working:
[   26.904914] Bluetooth: Core ver 2.22
[   26.905130] NET: Registered PF_BLUETOOTH protocol family
[   26.905136] Bluetooth: HCI device and connection manager initialized
[   26.905154] Bluetooth: HCI socket layer initialized
[   26.905161] Bluetooth: L2CAP socket layer initialized
[   26.905184] Bluetooth: SCO socket layer initialized
[   27.291346] audit: type=1130 audit(1715629261.116:39): pid=1 uid=0 
auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 
msg='unit=systemd-tmpfiles-setup comm="systemd" 
exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success'
[   27.335410] audit: type=1334 audit(1715629261.160:40): prog-id=57 op=LOAD
[   29.472422] usb 1-4: Found UVC 1.00 device USB 2.0 Camera (058f:5608)
[   29.494762] usbcore: registered new interface driver uvcvideo
[   29.506692] RPC: Registered named UNIX socket transport module.
[   29.506704] RPC: Registered udp transport module.
[   29.506707] RPC: Registered tcp transport module.
[   29.506709] RPC: Registered tcp-with-tls transport module.
[   29.506711] RPC: Registered tcp NFSv4.1 backchannel transport module.
[   29.532484] Bluetooth: HCI UART driver ver 2.3
[   29.532503] Bluetooth: HCI UART protocol H4 registered
[   29.532507] Bluetooth: HCI UART protocol BCSP registered
[   29.532594] Bluetooth: HCI UART protocol LL registered
[   29.532599] Bluetooth: HCI UART protocol ATH3K registered
[   29.533139] Bluetooth: HCI UART protocol Three-wire (H5) registered
[   29.533325] Bluetooth: HCI UART protocol Intel registered
[   29.533506] Bluetooth: HCI UART protocol Broadcom registered
[   29.533541] Bluetooth: HCI UART protocol QCA registered
[   29.533546] Bluetooth: HCI UART protocol AG6XX registered
[   29.533572] Bluetooth: HCI UART protocol Marvell registered
[   30.114887] cfg80211: Loading compiled-in X.509 certificates for 
regulatory database
[   30.172864] Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[   30.175628] Loaded X.509 cert 'wens: 
61c038651aabdcf94bd0ac7ff06c7248db18c600'
[   30.269514] Bluetooth: hci0: RTL: examining hci_ver=06 hci_rev=000b 
lmp_ver=06 lmp_subver=8723
[   30.273192] Bluetooth: hci0: RTL: rom_version status=0 version=1
[   30.273218] Bluetooth: hci0: RTL: loading rtl_bt/rtl8723bs_fw.bin
[   30.300067] Bluetooth: hci0: RTL: loading 
rtl_bt/rtl8723bs_config-OBDA8723.bin
[   30.328993] Bluetooth: hci0: RTL: cfg_sz 64, total sz 24508
[   30.617609] input: chtnau8824 Headset as 
/devices/pci0000:00/808622A8:00/cht-bsw-nau8824/sound/card1/input15
[   31.630950] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   31.630966] Bluetooth: BNEP filters: protocol multicast
[   31.631013] Bluetooth: BNEP socket layer initialized
[   32.388997] Bluetooth: hci0: command 0xfc20 tx timeout
[   33.397774] NET: Registered PF_QIPCRTR protocol family
[   35.872260] r8723bs: module is from the staging directory, the 
quality is unknown, you have been warned.
[   36.008866] pnetdev = 0000000086c577c1
[   38.957652] rtl8723bs: acquire FW from file:rtlwifi/rtl8723bs_nic.bin
[   39.065930] ax88179_178a 2-1:1.0 enp0s20u1: ax88179 - Link status is: 1
[   40.516641] Bluetooth: hci0: RTL: download fw command failed (-110)
[   41.754022] ax88179_178a 2-1:1.0 enp0s20u1: ax88179 - Link status is: 1
[   62.939117] rfkill: input handler disabled
[   66.873746] intel_sst_acpi 808622A8:00: FW Version 01.0b.02.02
[   95.201213] systemd-journald[587]: 
/var/log/journal/deb6c1cc9b434036821e1d20b20e14ec/user-1000.journal: 
Journal file uses a different sequence number ID, rotating.
[   96.212917] rfkill: input handler enabled
[  104.357628] rfkill: input handler disabled
[  124.215728]  mmcblk1: p1 p2 p3
[  169.291952] netfs: FS-Cache loaded
[  169.343759] Key type dns_resolver registered
[  170.689598] Key type cifs.spnego registered
[  170.689677] Key type cifs.idmap registered
[  170.691671] CIFS: Attempting to mount //192.168.2.110/kernelcomp
[  181.038648]  mmcblk1: p1 p2 p3

Re: [Bug] staging: rtl8723bs: Bluetooth stops working after patch: serial: 8250_dw: Do not reclock if already at correct rate

[Andy Shevchenko]

On Tue, May 14, 2024 at 06:32:37AM +0200, Philipp Hortmann wrote:
> Hi,
> 
> I have a ODYS Trendbook next 14 with the wlan/bluetooth module rtl8723bs.
> 
> Bluetooth stops working with the following commit:
> commit e5d6bd25f93d6ae158bb4cd04956cb497a85b8ef (HEAD)
> Author: Peter Collingbourne <pcc@google.com>
> Date:   Thu Feb 22 11:26:34 2024 -0800
>     serial: 8250_dw: Do not reclock if already at correct rate
> 
> Please find dmesg below. Module has issues to load firmware.
> 
> To enshure that this is the function breaking commit I applied the commit
> reversed on top of the latest kernel from the staging tree. Then bluetooth
> is working again.
> 
> I can support with further tests. I do not have a good proposal for a fix as
> I expect a lot of side effects. Please send me proposals for a fix.

The revert is in the tree IIRC.
7dfae6cbadc1 ("serial: 8250_dw: Revert: Do not reclock if already at correct rate")

First appeared in v6.9-rc5.

-- 
With Best Regards,
Andy Shevchenko