From: Jethro Beekman <jethro@fortanix.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>
Cc: "dave.hansen@intel.com" <dave.hansen@intel.com>,
"sean.j.christopherson@intel.com"
<sean.j.christopherson@intel.com>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"npmccallum@redhat.com" <npmccallum@redhat.com>,
"serge.ayoun@intel.com" <serge.ayoun@intel.com>,
"shay.katz-zamir@intel.com" <shay.katz-zamir@intel.com>,
"haitao.huang@intel.com" <haitao.huang@intel.com>,
"mark.shanahan@intel.com" <mark.shanahan@intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Reinette Chatre <reinette.chatre@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v15 16/23] x86/sgx: Enumerate and track EPC sections
Date: Sat, 3 Nov 2018 01:07:27 +0000 [thread overview]
Message-ID: <79867568-c21f-8a09-d06e-360b1b925dd5@fortanix.com> (raw)
Message-ID: <20181103010727.IWlPptT3DdqIpMbb_jNBNqKlYuj7x5YTzWvnrmGhFD4@z> (raw)
In-Reply-To: <20181102231320.29164-17-jarkko.sakkinen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
On 2018-11-02 16:11, Jarkko Sakkinen wrote:
> diff --git a/arch/x86/kernel/cpu/intel_sgx.c b/arch/x86/kernel/cpu/intel_sgx.c
> new file mode 100644
> index 000000000000..b86aa4111592
> --- /dev/null
> +++ b/arch/x86/kernel/cpu/intel_sgx.c
>
> ...
>
> +static __init int sgx_page_cache_init(void)
> +{
> + u32 eax, ebx, ecx, edx, type;
> + u64 pa, size;
> + int ret;
> + int i;
> +
> + BUILD_BUG_ON(SGX_MAX_EPC_SECTIONS > (SGX_EPC_SECTION_MASK + 1));
> +
> + for (i = 0; i < SGX_MAX_EPC_SECTIONS; i++) {
Perhaps print a warning if there are more than SGX_MAX_EPC_SECTIONS
sections reported by CPUID.
> + cpuid_count(SGX_CPUID, i + SGX_CPUID_FIRST_VARIABLE_SUB_LEAF,
> + &eax, &ebx, &ecx, &edx);
> +
> + type = eax & SGX_CPUID_SUB_LEAF_TYPE_MASK;
> + if (type == SGX_CPUID_SUB_LEAF_INVALID)
> + break;
> + if (type != SGX_CPUID_SUB_LEAF_EPC_SECTION) {
> + pr_err_once("sgx: Unknown sub-leaf type: %u\n", type);
> + continue;
> + }
> +
> + pa = sgx_calc_section_metric(eax, ebx);
> + size = sgx_calc_section_metric(ecx, edx);
> + pr_info("sgx: EPC section 0x%llx-0x%llx\n", pa, pa + size - 1);
> +
> + ret = sgx_init_epc_section(pa, size, i, &sgx_epc_sections[i]);
> + if (ret) {
> + sgx_page_cache_teardown();
> + return ret;
> + }
> +
> + sgx_nr_epc_sections++;
> + }
> +
> + if (!sgx_nr_epc_sections) {
> + pr_err("sgx: There are zero EPC sections.\n");
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
--
Jethro Beekman | Fortanix
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3990 bytes --]
next prev parent reply other threads:[~2018-11-03 1:07 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 23:10 [PATCH v15 00/23] Intel SGX1 Jarkko Sakkinen
2018-11-02 23:10 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 01/23] x86/sgx: Update MAINTAINERS Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 02/23] x86/cpufeatures: Add Intel-defined SGX feature bit Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:33 ` Borislav Petkov
2018-11-02 23:33 ` Borislav Petkov
2018-11-02 23:55 ` Jarkko Sakkinen
2018-11-02 23:55 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 03/23] x86/cpufeatures: Add SGX sub-features (as Linux-defined bits) Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 04/23] x86/msr: Add IA32_FEATURE_CONTROL.SGX_ENABLE definition Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 05/23] x86/cpu/intel: Detect SGX support and update caps appropriately Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-03 13:05 ` Andy Shevchenko
2018-11-03 13:05 ` Andy Shevchenko
2018-11-05 14:09 ` Jarkko Sakkinen
2018-11-05 14:09 ` Jarkko Sakkinen
2018-11-05 14:11 ` Jarkko Sakkinen
2018-11-05 14:11 ` Jarkko Sakkinen
2018-11-05 14:31 ` Andy Shevchenko
2018-11-05 14:31 ` Andy Shevchenko
2018-11-02 23:11 ` [PATCH v15 06/23] x86/mm: x86/sgx: Add new 'PF_SGX' page fault error code bit Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 07/23] x86/mm: x86/sgx: Signal SIGSEGV for userspace #PFs w/ PF_SGX Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 08/23] x86/sgx: Define SGX1 and SGX2 ENCLS leafs Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 09/23] x86/sgx: Add ENCLS architectural error codes Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 10/23] x86/sgx: Add SGX1 and SGX2 architectural data structures Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 11/23] x86/sgx: Add definitions for SGX's CPUID leaf and variable sub-leafs Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-03 13:11 ` Andy Shevchenko
2018-11-03 13:11 ` Andy Shevchenko
2018-11-05 14:35 ` Jarkko Sakkinen
2018-11-05 14:35 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 12/23] x86/cpufeatures: Add Intel-defined SGX_LC feature bit Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 13/23] x86/msr: Add SGX Launch Control MSR definitions Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 14/23] x86/cpu/intel: Clear SGX_LC capability if not enabled in FEATURE_CONTROL Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-03 13:15 ` Andy Shevchenko
2018-11-03 13:15 ` Andy Shevchenko
2018-11-05 14:37 ` Jarkko Sakkinen
2018-11-05 14:37 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-03 13:17 ` Andy Shevchenko
2018-11-03 13:17 ` Andy Shevchenko
2018-11-05 17:30 ` Jarkko Sakkinen
2018-11-05 17:30 ` Jarkko Sakkinen
2018-11-05 20:39 ` Andy Shevchenko
2018-11-05 20:39 ` Andy Shevchenko
2018-11-06 12:03 ` Jarkko Sakkinen
2018-11-06 12:03 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 16/23] x86/sgx: Enumerate and track EPC sections Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-03 1:07 ` Jethro Beekman [this message]
2018-11-03 1:07 ` Jethro Beekman
2018-11-05 17:31 ` Jarkko Sakkinen
2018-11-05 17:31 ` Jarkko Sakkinen
2018-11-03 13:22 ` Andy Shevchenko
2018-11-03 13:22 ` Andy Shevchenko
2018-11-05 17:35 ` Jarkko Sakkinen
2018-11-05 17:35 ` Jarkko Sakkinen
2018-11-06 12:10 ` Jarkko Sakkinen
2018-11-06 12:10 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 17/23] x86/sgx: Add functions to allocate and free EPC pages Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 18/23] x86/sgx: Add sgx_einit() for initializing enclaves Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 19/23] platform/x86: Intel SGX driver Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 20/23] platform/x86: sgx: Add swapping functionality to the " Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 21/23] x86/sgx: Add a simple swapper for the EPC memory manager Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 22/23] platform/x86: ptrace() support for the SGX driver Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-02 23:11 ` [PATCH v15 23/23] x86/sgx: Driver documentation Jarkko Sakkinen
2018-11-02 23:11 ` Jarkko Sakkinen
2018-11-04 8:15 ` Mike Rapoport
2018-11-04 8:15 ` Mike Rapoport
2018-11-05 17:39 ` Jarkko Sakkinen
2018-11-05 17:39 ` Jarkko Sakkinen
2018-11-05 20:27 ` Dave Hansen
2018-11-05 20:27 ` Dave Hansen
2018-11-06 5:49 ` Jarkko Sakkinen
2018-11-06 5:49 ` Jarkko Sakkinen
2018-11-06 6:20 ` Jarkko Sakkinen
2018-11-06 6:20 ` Jarkko Sakkinen
2018-11-06 16:45 ` Dave Hansen
2018-11-06 16:45 ` Dave Hansen
2018-11-07 16:30 ` Jarkko Sakkinen
2018-11-07 16:30 ` Jarkko Sakkinen
2018-11-07 17:09 ` Dave Hansen
2018-11-07 17:09 ` Dave Hansen
2018-11-08 14:39 ` Jarkko Sakkinen
2018-11-08 14:39 ` Jarkko Sakkinen
2018-11-08 19:20 ` Jarkko Sakkinen
2018-11-08 19:20 ` Jarkko Sakkinen
2018-11-13 15:13 ` Jarkko Sakkinen
2018-11-06 6:26 ` Jarkko Sakkinen
2018-11-06 6:26 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79867568-c21f-8a09-d06e-360b1b925dd5@fortanix.com \
--to=jethro@fortanix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=haitao.huang@intel.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mark.shanahan@intel.com \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).