From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Josh Triplett <josh@joshtriplett.org>,
linux-sgx@vger.kernel.org,
Haitao Huang <haitao.huang@linux.intel.com>,
Jethro Beekman <jethro@fortanix.com>,
"Dr. Greg" <greg@enjellic.com>
Subject: Re: [RFC PATCH v2 4/4] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions
Date: Fri, 7 Dec 2018 08:51:45 -0800 [thread overview]
Message-ID: <20181207165145.GB10404@linux.intel.com> (raw)
In-Reply-To: <CALCETrXRJ645=08fyeoMQ949fLB1TvhsgERFVx5mAHdViEjq8Q@mail.gmail.com>
+Cc: linux-sgx, Haitao, Greg and Jethro
My apologies for neglecting to cc the SGX folks, original thread is here:
https://lkml.kernel.org/r/20181206221922.31012-1-sean.j.christopherson@intel.com
On Thu, Dec 06, 2018 at 02:50:01PM -0800, Andy Lutomirski wrote:
> On Thu, Dec 6, 2018 at 2:19 PM Sean Christopherson
> <sean.j.christopherson@intel.com> wrote:
> >
> +
> > + /*
> > + * Invoke the caller's exit handler if one was provided. The return
> > + * value tells us whether to re-enter the enclave (EENTER or ERESUME)
> > + * or to return (EEXIT).
> > + */
> > + if (exit_handler) {
> > + leaf = exit_handler(exit_info, tcs, priv);
> > + if (leaf == SGX_EENTER || leaf == SGX_ERESUME)
> > + goto enter_enclave;
> > + if (leaf == SGX_EEXIT)
> > + return 0;
> > + return -EINVAL;
> > + } else if (leaf != SGX_EEXIT) {
> > + return -EFAULT;
> > + }
>
> This still seems overcomplicated to me. How about letting the
> requested leaf (EENTER or ERESUME) be a parameter to the function and
> then just returning here? As it stands, you're requiring any ERESUME
> that gets issued (other than the implicit ones) to be issued in the
> same call stack, which is very awkward if you're doing something like
> forwarding the fault to a different task over a socket and then
> waiting in epoll_wait() or similar before resuming the enclave.
Ah, yeah, wasn't thinking about usage models where the enclave could
get passed off to a different thread.
What about supporting both, i.e. keep the exit handler but make it 100%
optional? And simplify the exit_handler to effectively return a boolean,
i.e. "exit or continue".
Something like this:
notrace long __vdso_sgx_enter_enclave(u32 op, void *tcs, void *priv,
struct sgx_enclave_exit_info *exit_info,
sgx_enclave_exit_handler *exit_handler)
{
u64 rdi, rsi, rdx;
u32 leaf;
long ret;
if (!tcs || !exit_info)
return -EINVAL;
enter_enclave:
if (op != SGX_EENTER && op != SGX_ERESUME)
return -EINVAL;
<same core code>
/*
* Invoke the caller's exit handler if one was provided. The return
* value tells us whether to re-enter the enclave (EENTER or ERESUME)
* or to return (EEXIT).
*/
if (exit_handler) {
if (exit_handler(exit_info, tcs, priv)) {
op = exit_info->leaf;
goto enter_enclave;
}
}
if (exit_info->leaf == SGX_EEXIT)
return -EFAULT;
return 0;
}
I like that the exit handler allows userspace to trap/panic with the full
call stack in place, and in a dedicated path, i.e. outside of the basic
enter/exit code. An exit handler probably doesn't fundamentally change
what userspace can do with respect to debugging/reporting, but I think
it would actually simplify some userspace implementations, e.g. I'd use
it in my tests like so:
long fault_handler(struct sgx_enclave_exit_info *exit_info, void *tcs, void *priv)
{
if (exit_info->leaf == SGX_EEXIT)
return 0;
<report exception and die/hang>
}
next parent reply other threads:[~2018-12-07 16:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181206221922.31012-1-sean.j.christopherson@intel.com>
[not found] ` <20181206221922.31012-5-sean.j.christopherson@intel.com>
[not found] ` <CALCETrXRJ645=08fyeoMQ949fLB1TvhsgERFVx5mAHdViEjq8Q@mail.gmail.com>
2018-12-07 16:51 ` Sean Christopherson [this message]
2018-12-07 17:56 ` [RFC PATCH v2 4/4] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions Andy Lutomirski
2018-12-07 19:02 ` Sean Christopherson
2018-12-07 19:23 ` Andy Lutomirski
2018-12-07 20:09 ` Sean Christopherson
2018-12-07 20:16 ` Andy Lutomirski
2018-12-07 20:35 ` Sean Christopherson
2018-12-07 21:26 ` Sean Christopherson
2018-12-07 23:33 ` Andy Lutomirski
2018-12-11 19:31 ` Sean Christopherson
2018-12-11 20:04 ` Andy Lutomirski
2018-12-11 22:00 ` Sean Christopherson
2018-12-11 23:12 ` Andy Lutomirski
2018-12-07 18:15 ` Jethro Beekman
2018-12-07 18:44 ` Dave Hansen
2018-12-07 18:50 ` Andy Lutomirski
2018-12-08 8:15 ` Jethro Beekman
2018-12-14 15:04 ` Sean Christopherson
[not found] ` <20181207163127.GA23494@wind.enjellic.com>
2018-12-07 18:19 ` Jethro Beekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207165145.GB10404@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=greg@enjellic.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).