From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-sgx@vger.kernel.org,
Haitao Huang <haitao.huang@linux.intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Jethro Beekman <jethro@fortanix.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3] x86/sgx: Fix sgx_encl_may_map locking
Date: Mon, 5 Oct 2020 20:28:16 +0300 [thread overview]
Message-ID: <20201005172816.GA13168@linux.intel.com> (raw)
In-Reply-To: <20201005172514.GA12358@linux.intel.com>
On Mon, Oct 05, 2020 at 08:25:39PM +0300, Jarkko Sakkinen wrote:
> On Mon, Oct 05, 2020 at 03:12:54PM +0100, Matthew Wilcox wrote:
> > On Mon, Oct 05, 2020 at 05:11:19PM +0300, Jarkko Sakkinen wrote:
> > > Fix the issue further discussed in:
> >
> > No, this is still utter crap. Just use the version I sent.
>
> OK, just a quick recap to fully understand it.
>
> Here's your response from the original thread:
>
> https://lore.kernel.org/linux-sgx/20201005013053.GJ20115@casper.infradead.org/
>
> And here's your snippet from v2:
>
> https://lore.kernel.org/linux-sgx/20201005111139.GK20115@casper.infradead.org/
>
> This is what confused me.
>
> Compared to (v3) patch and your version, the differences I spot are:
>
> A. 'count' is checked first.
> B. Both this and the snippet from the original thread (i.e.
> page-writeback.c) use the same loop construct.
>
> Right, and snippet from page-writeback.c is not compatible with this
> because looking at documentation xas_find() continued with
> xas_next_entry() sequence will jump through the existing entries and
> skip the holes? On the other hand, xas_next() does not.
>
> Of the A part I'm not sure how the order there semantically matter.
Right, how blind I was with B. Read Dave's response.
/Jarkko
next prev parent reply other threads:[~2020-10-05 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 14:11 [PATCH v3] x86/sgx: Fix sgx_encl_may_map locking Jarkko Sakkinen
2020-10-05 14:12 ` Matthew Wilcox
2020-10-05 17:25 ` Jarkko Sakkinen
2020-10-05 17:28 ` Jarkko Sakkinen [this message]
2020-10-05 14:28 ` Dave Hansen
2020-10-05 17:36 ` Jarkko Sakkinen
2020-10-05 15:55 ` Sean Christopherson
2020-10-05 17:41 ` Jarkko Sakkinen
2020-10-05 17:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005172816.GA13168@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=linux-sgx@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).