From: Kai Huang <kai.huang@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-sgx@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
luto@kernel.org, rick.p.edgecombe@intel.com,
haitao.huang@intel.com, pbonzini@redhat.com, bp@alien8.de,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Subject: Re: [RFC PATCH v4 05/26] x86/sgx: Introduce virtual EPC for use by KVM guests
Date: Thu, 11 Feb 2021 12:12:16 +1300 [thread overview]
Message-ID: <20210211121216.bb9a9430eee1f2fd43702e93@intel.com> (raw)
In-Reply-To: <YCQPSUNFlWd/s+up@google.com>
On Wed, 10 Feb 2021 08:52:25 -0800 Sean Christopherson wrote:
> On Wed, Feb 10, 2021, Kai Huang wrote:
> > On Tue, 2021-02-09 at 13:36 -0800, Dave Hansen wrote:
> > > On 2/9/21 1:19 PM, Jarkko Sakkinen wrote:
> > > > > Without that clearly documented, it would be unwise to merge this.
> > > > E.g.
> > > >
> > > > - Have ioctl() to turn opened fd as vEPC.
> > > > - If FLC is disabled, you could only use the fd for creating vEPC.
> > > >
> > > > Quite easy stuff to implement.
>
> ...
>
> > What's your opinion? Did I miss anything?
>
> Frankly, I think trying to smush them together would be a complete trainwreck.
>
> The vast majority of flows would need to go down completely different paths, so
> you'd end up with code like this:
>
> diff --git a/arch/x86/kernel/cpu/sgx/driver.c b/arch/x86/kernel/cpu/sgx/driver.c
> index f2eac41bb4ff..5128043c7871 100644
> --- a/arch/x86/kernel/cpu/sgx/driver.c
> +++ b/arch/x86/kernel/cpu/sgx/driver.c
> @@ -46,6 +46,9 @@ static int sgx_release(struct inode *inode, struct file *file)
> struct sgx_encl *encl = file->private_data;
> struct sgx_encl_mm *encl_mm;
>
> + if (encl->not_an_enclave)
> + return sgx_virt_epc_release(encl);
> +
> /*
> * Drain the remaining mm_list entries. At this point the list contains
> * entries for processes, which have closed the enclave file but have
> @@ -83,6 +86,9 @@ static int sgx_mmap(struct file *file, struct vm_area_struct *vma)
> struct sgx_encl *encl = file->private_data;
> int ret;
>
> + if (encl->not_an_enclave)
> + return sgx_virt_epc_mmap(encl, vma);
> +
> ret = sgx_encl_may_map(encl, vma->vm_start, vma->vm_end, vma->vm_flags);
> if (ret)
> return ret;
> @@ -104,6 +110,11 @@ static unsigned long sgx_get_unmapped_area(struct file *file,
> unsigned long pgoff,
> unsigned long flags)
> {
> + struct sgx_encl *encl = file->private_data;
> +
> + if (encl->not_an_enclave)
> + return sgx_virt_epc_mmap(encl, addr, len, pgoff, flags);
> +
> if ((flags & MAP_TYPE) == MAP_PRIVATE)
> return -EINVAL;
>
> I suspect it would also be tricky to avoid introducing races, since anything that
> is different for virtual EPC would have a dependency on the ioctl() being called.
>
> This would also prevent making /dev/sgx_enclave root-only while allowing users
> access to /dev/sgx_vepc. Forcing admins to use LSMs to do the same is silly.
Agreed. This is really a good point. Two different device nodes allows
different permission control. Thanks.
>
> For the few flows that can share code, just split out the common bits to helpers.
next prev parent reply other threads:[~2021-02-10 23:16 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:53 [RFC PATCH v4 00/26] KVM SGX virtualization support Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 01/26] x86/cpufeatures: Make SGX_LC feature bit depend on SGX bit Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 02/26] x86/cpufeatures: Add SGX1 and SGX2 sub-features Kai Huang
2021-02-09 16:11 ` Dave Hansen
2021-02-08 10:54 ` [RFC PATCH v4 03/26] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page() Kai Huang
2021-02-09 16:18 ` Dave Hansen
2021-02-09 18:26 ` Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 04/26] x86/sgx: Add SGX_CHILD_PRESENT hardware error code Kai Huang
2021-02-09 16:24 ` Dave Hansen
2021-02-09 16:48 ` Sean Christopherson
2021-02-09 16:52 ` Dave Hansen
2021-02-09 17:07 ` Sean Christopherson
2021-02-09 21:03 ` Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 05/26] x86/sgx: Introduce virtual EPC for use by KVM guests Kai Huang
2021-02-09 21:18 ` Jarkko Sakkinen
2021-02-09 21:19 ` Jarkko Sakkinen
2021-02-09 21:36 ` Dave Hansen
2021-02-10 0:20 ` Kai Huang
2021-02-10 16:52 ` Sean Christopherson
2021-02-10 23:12 ` Kai Huang [this message]
2021-02-12 12:17 ` [RFC PATCH v4 05/26] x86/sgx: Introduce virtual EPC for use by KVM guests' Jarkko Sakkinen
2021-02-13 13:33 ` Kai Huang
2021-02-12 12:15 ` [RFC PATCH v4 05/26] x86/sgx: Introduce virtual EPC for use by KVM guests Jarkko Sakkinen
2021-02-12 12:14 ` Jarkko Sakkinen
2021-02-08 10:54 ` [RFC PATCH v4 06/26] x86/cpu/intel: Allow SGX virtualization without Launch Control support Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 07/26] x86/sgx: Initialize virtual EPC driver even when SGX driver is disabled Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 08/26] x86/sgx: Expose SGX architectural definitions to the kernel Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 09/26] x86/sgx: Move ENCLS leaf definitions to sgx_arch.h Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 10/26] x86/sgx: Add SGX2 ENCLS leaf definitions (EAUG, EMODPR and EMODT) Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 11/26] x86/sgx: Add encls_faulted() helper Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 12/26] x86/sgx: Add helper to update SGX_LEPUBKEYHASHn MSRs Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 13/26] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM Kai Huang
2021-02-08 10:54 ` [RFC PATCH v4 14/26] x86/sgx: Move provisioning device creation out of SGX driver Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 15/26] KVM: VMX: Convert vcpu_vmx.exit_reason to a union Kai Huang
2021-02-08 11:11 ` Kai Huang
2021-02-08 14:39 ` Xiaoyao Li
2021-02-09 0:09 ` Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 16/26] KVM: x86: Export kvm_mmu_gva_to_gpa_{read,write}() for SGX (VMX) Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 17/26] KVM: x86: Define new #PF SGX error code bit Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 18/26] KVM: x86: Add support for reverse CPUID lookup of scattered features Kai Huang
2021-02-08 11:05 ` Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 19/26] KVM: x86: Add reverse-CPUID lookup support for scattered SGX features Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 20/26] KVM: VMX: Add basic handling of VM-Exit from SGX enclave Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 21/26] KVM: VMX: Frame in ENCLS handler for SGX virtualization Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 22/26] KVM: VMX: Add SGX ENCLS[ECREATE] handler to enforce CPUID restrictions Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 23/26] KVM: VMX: Add emulation of SGX Launch Control LE hash MSRs Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 24/26] KVM: VMX: Add ENCLS[EINIT] handler to support SGX Launch Control (LC) Kai Huang
2021-02-08 10:55 ` [RFC PATCH v4 25/26] KVM: VMX: Enable SGX virtualization for SGX1, SGX2 and LC Kai Huang
2021-02-08 10:56 ` [RFC PATCH v4 26/26] KVM: x86: Add capability to grant VM access to privileged SGX attribute Kai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211121216.bb9a9430eee1f2fd43702e93@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=haitao.huang@intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).