From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Igor Zhbanov <izh1979@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler
Date: Sun, 5 Mar 2023 20:00:32 -0800 [thread overview]
Message-ID: <20230306040037.20350-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20230306040037.20350-1-rdunlap@infradead.org>
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from nmi_debug_setup().
Fixes: 1e1030dccb10 ("sh: nmi_debug support.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <izh1979@gmail.com>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: stable@vger.kernel.org
---
v2: add more Cc's;
refresh and resend;
v3: add Arnd to Cc: list
v4: update Cc: list, refresh & resend
arch/sh/kernel/nmi_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/arch/sh/kernel/nmi_debug.c b/arch/sh/kernel/nmi_debug.c
--- a/arch/sh/kernel/nmi_debug.c
+++ b/arch/sh/kernel/nmi_debug.c
@@ -49,7 +49,7 @@ static int __init nmi_debug_setup(char *
register_die_notifier(&nmi_debug_nb);
if (*str != '=')
- return 0;
+ return 1;
for (p = str + 1; *p; p = sep + 1) {
sep = strchr(p, ',');
@@ -70,6 +70,6 @@ static int __init nmi_debug_setup(char *
break;
}
- return 0;
+ return 1;
}
__setup("nmi_debug", nmi_debug_setup);
next prev parent reply other threads:[~2023-03-06 4:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 4:00 [PATCH 0/7 v4] sh: various doc, build, init fixes Randy Dunlap
2023-03-06 4:00 ` [PATCH 1/7 v4] sh: SH2007: drop the bad URL info Randy Dunlap
2023-03-19 19:22 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` Randy Dunlap [this message]
2023-03-19 19:32 ` [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 3/7 v4] sh: init: use OF_EARLY_FLATTREE for early init Randy Dunlap
2023-03-19 19:48 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning Randy Dunlap
2023-03-19 19:49 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 5/7 v4] sh: remove sh5/sh64 last fragments Randy Dunlap
2023-03-16 13:23 ` John Paul Adrian Glaubitz
2023-03-16 16:44 ` Randy Dunlap
2023-03-16 16:52 ` John Paul Adrian Glaubitz
2023-03-16 20:43 ` Randy Dunlap
2023-03-16 20:46 ` John Paul Adrian Glaubitz
2023-03-17 7:31 ` Geert Uytterhoeven
2023-03-17 7:51 ` John Paul Adrian Glaubitz
2023-03-19 19:50 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 6/7 v4] sh: fix Kconfig entry for NUMA => SMP Randy Dunlap
2023-03-19 20:20 ` John Paul Adrian Glaubitz
2023-03-20 20:13 ` John Paul Adrian Glaubitz
2023-03-20 20:17 ` Randy Dunlap
2023-03-07 15:18 ` [PATCH 0/7 v4] sh: various doc, build, init fixes John Paul Adrian Glaubitz
2023-03-16 13:26 ` John Paul Adrian Glaubitz
[not found] ` <20230306040037.20350-8-rdunlap@infradead.org>
2023-03-19 20:49 ` [PATCH 7/7 v4] sh: mcount.S: fix build error when PRINTK is not enabled John Paul Adrian Glaubitz
[not found] ` <CAMuHMdU+tsKuONm9iPqqTFSnRT2zaV3zogYgc-+vCp6x-ruQ_w@mail.gmail.com>
[not found] ` <01f84314b2499b6859a4826ecf7363635e66a4fc.camel@physik.fu-berlin.de>
[not found] ` <CAMuHMdVR78EXTVd7ThUEv6rxL8aHSyAoC_5z8KyAPmiTyww85w@mail.gmail.com>
2023-03-20 12:43 ` Geert Uytterhoeven
2023-03-20 13:32 ` John Paul Adrian Glaubitz
2023-03-20 20:09 ` John Paul Adrian Glaubitz
2023-03-23 9:41 ` [PATCH 0/7 v4] sh: various doc, build, init fixes John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306040037.20350-3-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=izh1979@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).