From: Randy Dunlap <rdunlap@infradead.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6/7 v4] sh: fix Kconfig entry for NUMA => SMP
Date: Mon, 20 Mar 2023 13:17:16 -0700 [thread overview]
Message-ID: <bc1afc02-967b-73b3-49a0-b8d22cb96b35@infradead.org> (raw)
In-Reply-To: <c9a748cb2ee6145a3ffe85ca55a28b990f6be68c.camel@physik.fu-berlin.de>
On 3/20/23 13:13, John Paul Adrian Glaubitz wrote:
> Hi Randy!
>
> On Sun, 2023-03-19 at 21:20 +0100, John Paul Adrian Glaubitz wrote:
>> On Sun, 2023-03-05 at 20:00 -0800, Randy Dunlap wrote:
>>> Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select
>>> SYS_SUPPORTS_SMP and SMP.
>>>
>>> kernel/sched/topology.c is only built for CONFIG_SMP and then the NUMA
>>> code + data inside topology.c is only built when CONFIG_NUMA is
>>> set/enabled, so these arch/sh/ configs need to select SMP and
>>> SYS_SUPPORTS_SMP to build the NUMA support.
>>>
>>> Fixes this build error in multiple SUPERH configs:
>>>
>>> mm/page_alloc.o: In function `get_page_from_freelist':
>>> page_alloc.c:(.text+0x2ca8): undefined reference to `node_reclaim_distance'
>>>
>>> Fixes: 357d59469c11 ("sh: Tidy up dependencies for SH-2 build.")
>>> Fixes: 9109a30e5a54 ("sh: add support for sh7366 processor")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>>> Cc: Rich Felker <dalias@libc.org>
>>> Cc: linux-sh@vger.kernel.org
>>> Cc: stable@vger.kernel.org
>>> ---
>>> v2: skipped
>>> v3: skipped
>>> v4: refresh & resend
>>>
>>> arch/sh/Kconfig | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff -- a/arch/sh/Kconfig b/arch/sh/Kconfig
>>> --- a/arch/sh/Kconfig
>>> +++ b/arch/sh/Kconfig
>>> @@ -477,6 +477,8 @@ config CPU_SUBTYPE_SH7722
>>> select CPU_SHX2
>>> select ARCH_SHMOBILE
>>> select ARCH_SPARSEMEM_ENABLE
>>> + select SYS_SUPPORTS_SMP
>>> + select SMP
>>> select SYS_SUPPORTS_NUMA
>>> select SYS_SUPPORTS_SH_CMT
>>> select PINCTRL
>>> @@ -487,6 +489,8 @@ config CPU_SUBTYPE_SH7366
>>> select CPU_SHX2
>>> select ARCH_SHMOBILE
>>> select ARCH_SPARSEMEM_ENABLE
>>> + select SYS_SUPPORTS_SMP
>>> + select SMP
>>> select SYS_SUPPORTS_NUMA
>>> select SYS_SUPPORTS_SH_CMT
>>>
>>
>> It seems that we need this change for these configurations as well:
>>
>> - config CPU_SHX3
>> - config CPU_SUBTYPE_SH7785
>>
>> Although I can trigger a build failure for CPU_SUBTYPE_SH7785 only when
>> setting CONFIG_NUMA=y:
>>
>> CC net/ipv6/addrconf_core.o
>> mm/slab.c: In function 'slab_memory_callback':
>> mm/slab.c:1127:23: error: implicit declaration of function 'init_cache_node_node'; did you mean 'drain_cache_node_node'? [-Werror=implicit-function-declaration]
>> 1127 | ret = init_cache_node_node(nid);
>> | ^~~~~~~~~~~~~~~~~~~~
>> | drain_cache_node_node
>>
>> I would expect this error to be reproducible for CPU_SHX3 as well when
>> CONFIG_NUMA=y but CONFIG_SMP=n. But for some reason, I am not seeing
>> the error then.
>
> Can you make this change for config CPU_SUBTYPE_SH7785 as well?
>
> Then the change should be fine.
Will do. Thanks.
--
~Randy
next prev parent reply other threads:[~2023-03-20 20:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 4:00 [PATCH 0/7 v4] sh: various doc, build, init fixes Randy Dunlap
2023-03-06 4:00 ` [PATCH 1/7 v4] sh: SH2007: drop the bad URL info Randy Dunlap
2023-03-19 19:22 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler Randy Dunlap
2023-03-19 19:32 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 3/7 v4] sh: init: use OF_EARLY_FLATTREE for early init Randy Dunlap
2023-03-19 19:48 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning Randy Dunlap
2023-03-19 19:49 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 5/7 v4] sh: remove sh5/sh64 last fragments Randy Dunlap
2023-03-16 13:23 ` John Paul Adrian Glaubitz
2023-03-16 16:44 ` Randy Dunlap
2023-03-16 16:52 ` John Paul Adrian Glaubitz
2023-03-16 20:43 ` Randy Dunlap
2023-03-16 20:46 ` John Paul Adrian Glaubitz
2023-03-17 7:31 ` Geert Uytterhoeven
2023-03-17 7:51 ` John Paul Adrian Glaubitz
2023-03-19 19:50 ` John Paul Adrian Glaubitz
2023-03-06 4:00 ` [PATCH 6/7 v4] sh: fix Kconfig entry for NUMA => SMP Randy Dunlap
2023-03-19 20:20 ` John Paul Adrian Glaubitz
2023-03-20 20:13 ` John Paul Adrian Glaubitz
2023-03-20 20:17 ` Randy Dunlap [this message]
2023-03-07 15:18 ` [PATCH 0/7 v4] sh: various doc, build, init fixes John Paul Adrian Glaubitz
2023-03-16 13:26 ` John Paul Adrian Glaubitz
[not found] ` <20230306040037.20350-8-rdunlap@infradead.org>
2023-03-19 20:49 ` [PATCH 7/7 v4] sh: mcount.S: fix build error when PRINTK is not enabled John Paul Adrian Glaubitz
[not found] ` <CAMuHMdU+tsKuONm9iPqqTFSnRT2zaV3zogYgc-+vCp6x-ruQ_w@mail.gmail.com>
[not found] ` <01f84314b2499b6859a4826ecf7363635e66a4fc.camel@physik.fu-berlin.de>
[not found] ` <CAMuHMdVR78EXTVd7ThUEv6rxL8aHSyAoC_5z8KyAPmiTyww85w@mail.gmail.com>
2023-03-20 12:43 ` Geert Uytterhoeven
2023-03-20 13:32 ` John Paul Adrian Glaubitz
2023-03-20 20:09 ` John Paul Adrian Glaubitz
2023-03-23 9:41 ` [PATCH 0/7 v4] sh: various doc, build, init fixes John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1afc02-967b-73b3-49a0-b8d22cb96b35@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).