linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Add missing FORCE prerequisites in Makefile
Date: Sun, 19 Sep 2021 11:02:04 +0900	[thread overview]
Message-ID: <CAK7LNARTCU12W=nKOrjM8_5aGhkUPhiOqWBgwROsLKcZ80fy3Q@mail.gmail.com> (raw)
In-Reply-To: <0771f164fcbba2fb425bf525400b8fab7079e539.1631781770.git.geert+renesas@glider.be>

On Thu, Sep 16, 2021 at 5:43 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> make:
>
>     arch/sh/boot/Makefile:87: FORCE prerequisite is missing
>
> Add the missing FORCE prerequisites for all build targets identified by
> "make help".
>
> Fixes: e1f86d7b4b2a5213 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---


Applied to linux-kbuild. Thanks.

>  arch/sh/boot/Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/sh/boot/Makefile b/arch/sh/boot/Makefile
> index dded61296c9a00da..5c123f5b2797c08a 100644
> --- a/arch/sh/boot/Makefile
> +++ b/arch/sh/boot/Makefile
> @@ -80,30 +80,30 @@ $(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
>  $(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
>         $(call if_changed,lzo)
>
> -$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2
> +$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2 FORCE
>         $(call if_changed,uimage,bzip2)
>
> -$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz
> +$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz FORCE
>         $(call if_changed,uimage,gzip)
>
> -$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma
> +$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma FORCE
>         $(call if_changed,uimage,lzma)
>
> -$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz
> +$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz FORCE
>         $(call if_changed,uimage,xz)
>
> -$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo
> +$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo FORCE
>         $(call if_changed,uimage,lzo)
>
> -$(obj)/uImage.bin: $(obj)/vmlinux.bin
> +$(obj)/uImage.bin: $(obj)/vmlinux.bin FORCE
>         $(call if_changed,uimage,none)
>
>  OBJCOPYFLAGS_vmlinux.srec := -I binary -O srec
> -$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux
> +$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux FORCE
>         $(call if_changed,objcopy)
>
>  OBJCOPYFLAGS_uImage.srec := -I binary -O srec
> -$(obj)/uImage.srec: $(obj)/uImage
> +$(obj)/uImage.srec: $(obj)/uImage FORCE
>         $(call if_changed,objcopy)
>
>  $(obj)/uImage: $(obj)/uImage.$(suffix-y)
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2021-09-19  2:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  8:43 [PATCH] sh: Add missing FORCE prerequisites in Makefile Geert Uytterhoeven
2021-09-19  2:02 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNARTCU12W=nKOrjM8_5aGhkUPhiOqWBgwROsLKcZ80fy3Q@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=dalias@libc.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).