* Re: Kernel crash when syncing to usb-storage
[not found] ` <0133c4fc-81a9-7d8a-8aee-3756bd6d34a2@physik.fu-berlin.de>
@ 2020-11-19 10:58 ` Rob Landley
0 siblings, 0 replies; 5+ messages in thread
From: Rob Landley @ 2020-11-19 10:58 UTC (permalink / raw)
To: John Paul Adrian Glaubitz; +Cc: Linux-sh list
On 11/18/20 4:09 AM, John Paul Adrian Glaubitz wrote:
> Hi Rob!
>
> On 11/18/20 11:11 AM, Rob Landley wrote:
>>> Recently, I have started to see crashes when I try to sync a FAT filesystem
>>> on a USB pen drive. The crash is reproducible and seems to have been introduced
>>> in the 5.10 development cycle. I have not bisected the issue yet.
>>
>> Which board is this on? (Kernel config?)
>
> SH-7785LCR, I'm attaching the kernel configuration for 5.9. I don't have the one
> for 5.10 at hand right now, but I used the same configuration for 5.9 and 5.10.
>
>> Is it immediate or a ways into the backup?
>
> It happens the moment the kernel tries to write the data to the USB drive.
Smells like an incorrectly initialized field in the interrupt state. Let's see...
# IRQ chip support
#
# end of IRQ chip support
# Interrupt controller options
#
CONFIG_INTC_USERIMASK=y
# CONFIG_INTC_MAPPING_DEBUG is not set
# end of SuperH / SH-Mobile Driver Options
# end of Kernel features
Very helpful.
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_IRQ_WORK=y
I wonder what those do? I don't remember either...
> 5.9 is not affected, so it must be a regression with 5.10. I will bisect later
> this week.
There are many irq patches to choose from. And the DMA patches have potential
IRQ impact too (CONFIG_SH_DMA_IRQ_MULTI=y).
>> The stack trace says the idle tasks is handling an interrupt and crashing in the
>> interrupt controller code? Let's see...
>>
>> git log --no-merges v5.9..master arch/sh drivers/irqchip drivers/sh drivers/dma/sh
>>
>> This may not be a fat OR usb issue, there were some plumbing changes recently in
>> IRQ controllers and such, ala b388bdf2bac7 and f9ac7bbd6e45 and a7480c5d725c and
>> a00e85b581fd and 57733e009f0c and...
>
> I will report back once I have found the culprit. I haven't had the time for bisecting
> yet.
Thanks.
I'm in Tokyo this month far _far_ away from my little blue board, and it's been
long enough since I've re-kerneled that I don't actually remember how anyway. (I
should poke you for a walkthrough over christmas...)
> Adrian
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kernel crash when syncing to usb-storage
[not found] <d89a074e-c0ed-5d8b-a58e-ce3d420f579e@physik.fu-berlin.de>
[not found] ` <3a807d90-44c6-7c97-ae1d-89a3f3414baf@landley.net>
@ 2020-11-29 16:42 ` John Paul Adrian Glaubitz
2020-11-29 20:41 ` Rob Landley
2020-12-18 22:06 ` John Paul Adrian Glaubitz
2 siblings, 1 reply; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2020-11-29 16:42 UTC (permalink / raw)
To: Linux-sh list
On 11/17/20 10:39 PM, John Paul Adrian Glaubitz wrote:
> Recently, I have started to see crashes when I try to sync a FAT filesystem
> on a USB pen drive. The crash is reproducible and seems to have been introduced
> in the 5.10 development cycle. I have not bisected the issue yet.
I tried bisecting this but I failed twice because git is chocking on the merge
commits. Currently out of ideas but I'm pasting the git bisect logs in case
anyone has got any idea.
glaubitz@epyc:..glaubitz/linux-git> cat ~/sh4-bisect-5.10-regression.txt
git bisect start
# good: [bbf5c979011a099af5dc76498918ed7df445635b] Linux 5.9
git bisect good bbf5c979011a099af5dc76498918ed7df445635b
# bad: [aae5ab854e38151e69f261dbf0e3b7e396403178] Merge tag 'riscv-for-linus-5.10-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
git bisect bad aae5ab854e38151e69f261dbf0e3b7e396403178
# bad: [4d0e9df5e43dba52d38b251e3b909df8fa1110be] lib, uaccess: add failure injection to usercopy functions
git bisect bad 4d0e9df5e43dba52d38b251e3b909df8fa1110be
# bad: [f888bdf9823c85fe945c4eb3ba353f749dec3856] Merge tag 'devicetree-for-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
git bisect bad f888bdf9823c85fe945c4eb3ba353f749dec3856
# bad: [57218d7f2e87069f73c7a841b6ed6c1cc7acf616] Merge tag 'regmap-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
git bisect bad 57218d7f2e87069f73c7a841b6ed6c1cc7acf616
# bad: [39a5101f989e8d2be557136704d53990f9b402c8] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect bad 39a5101f989e8d2be557136704d53990f9b402c8
# bad: [ed016af52ee3035b4799ebd7d53f9ae59d5782c4] Merge tag 'locking-core-2020-10-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad ed016af52ee3035b4799ebd7d53f9ae59d5782c4
# bad: [f94ab231136c53ee26b1ddda76b29218018834ff] Merge tag 'x86_cleanups_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad f94ab231136c53ee26b1ddda76b29218018834ff
# good: [baab853229ec1f291cec6a70ed61ce93159d0997] Merge branch 'for-next/mte' into for-next/core
git bisect good baab853229ec1f291cec6a70ed61ce93159d0997
# bad: [ca1b66922a702316734bcd5ea2100e5fb8f3caa3] Merge tag 'ras_updates_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad ca1b66922a702316734bcd5ea2100e5fb8f3caa3
# bad: [af9db1d6632b726a2351426ab8f34374f6f38690] Merge tag 'm68k-for-v5.10-tag1' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k
git bisect bad af9db1d6632b726a2351426ab8f34374f6f38690
# bad: [6734e20e39207556e17d72b5c4950d8f3a4f2de2] Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
git bisect bad 6734e20e39207556e17d72b5c4950d8f3a4f2de2
# good: [d433ab42fdc2c8a32e5df7d53833310f0ab9822c] arm64: random: Remove no longer needed prototypes
git bisect good d433ab42fdc2c8a32e5df7d53833310f0ab9822c
# bad: [55707d531af62bd87c1b7e8d66fd9798094f9b3b] tpm_tis: Add a check for invalid status
git bisect bad 55707d531af62bd87c1b7e8d66fd9798094f9b3b
# bad: [a4c3049784551f6622be7f9a0a2dc993d4ba3149] dt-bindings: Add SynQucer TPM MMIO as a trivial device
git bisect bad a4c3049784551f6622be7f9a0a2dc993d4ba3149
# bad: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
git bisect bad d5ae56a4fe5178e289e763450362d87800f9dcac
# first bad commit: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
glaubitz@epyc:..glaubitz/linux-git>
glaubitz@epyc:..glaubitz/linux-git> cat ~/sh4-bisect-5.10-regression-2.txt
git bisect start
# good: [d433ab42fdc2c8a32e5df7d53833310f0ab9822c] arm64: random: Remove no longer needed prototypes
git bisect good d433ab42fdc2c8a32e5df7d53833310f0ab9822c
# bad: [55707d531af62bd87c1b7e8d66fd9798094f9b3b] tpm_tis: Add a check for invalid status
git bisect bad 55707d531af62bd87c1b7e8d66fd9798094f9b3b
# good: [f75aef392f869018f78cfedf3c320a6b3fcfda6b] Linux 5.9-rc3
git bisect good f75aef392f869018f78cfedf3c320a6b3fcfda6b
# bad: [6c7247f6258b2dba353c885a1b00d795a380cc85] Merge tag 'staging-5.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
git bisect bad 6c7247f6258b2dba353c885a1b00d795a380cc85
# good: [d824e0809ce3c9e935f3aa37381cda7fd4184f12] Merge tag 'libata-5.9-2020-09-04' of git://git.kernel.dk/linux-block
git bisect good d824e0809ce3c9e935f3aa37381cda7fd4184f12
# good: [d67f2ec1f5fed849d9773cd783ea161df842bbae] Merge tag 'drm-fixes-2020-09-11' of git://anongit.freedesktop.org/drm/drm
git bisect good d67f2ec1f5fed849d9773cd783ea161df842bbae
# good: [b952e974300be3184049a125e7cba112fe659017] Merge tag 'for-linus' of git://github.com/openrisc/linux
git bisect good b952e974300be3184049a125e7cba112fe659017
# good: [2a1a4bee5ef277c7dc2906d9268db61478876288] Merge tag 'char-misc-5.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
git bisect good 2a1a4bee5ef277c7dc2906d9268db61478876288
# bad: [54f82df2ba86e2a8e9cbf4036d192366e3905c89] iio:adc:ti-adc081c Fix alignment and data leak issues
git bisect bad 54f82df2ba86e2a8e9cbf4036d192366e3905c89
# bad: [95ad67577de4ea08eb8e441394e698aa4addcc0b] iio: accel: kxsd9: Fix alignment of local buffer.
git bisect bad 95ad67577de4ea08eb8e441394e698aa4addcc0b
# bad: [336306790b2bbf7ce837625fa3b24ba724d05838] iio: cros_ec: Set Gyroscope default frequency to 25Hz
git bisect bad 336306790b2bbf7ce837625fa3b24ba724d05838
# bad: [fea22e159d51c766ba70473f473a0ec914cc7e92] staging: wlan-ng: fix out of bounds read in prism2sta_probe_usb()
git bisect bad fea22e159d51c766ba70473f473a0ec914cc7e92
# bad: [b15b4da88be52e7455acc59318f6c97b8740b329] staging: greybus: audio: Uninitialized variable in gbaudio_remove_controls()
git bisect bad b15b4da88be52e7455acc59318f6c97b8740b329
# first bad commit: [b15b4da88be52e7455acc59318f6c97b8740b329] staging: greybus: audio: Uninitialized variable in gbaudio_remove_controls()
glaubitz@epyc:..glaubitz/linux-git>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kernel crash when syncing to usb-storage
2020-11-29 16:42 ` John Paul Adrian Glaubitz
@ 2020-11-29 20:41 ` Rob Landley
2020-11-29 22:07 ` John Paul Adrian Glaubitz
0 siblings, 1 reply; 5+ messages in thread
From: Rob Landley @ 2020-11-29 20:41 UTC (permalink / raw)
To: John Paul Adrian Glaubitz, Linux-sh list
On 11/29/20 10:42 AM, John Paul Adrian Glaubitz wrote:
> On 11/17/20 10:39 PM, John Paul Adrian Glaubitz wrote:
>> Recently, I have started to see crashes when I try to sync a FAT filesystem
>> on a USB pen drive. The crash is reproducible and seems to have been introduced
>> in the 5.10 development cycle. I have not bisected the issue yet.
>
> I tried bisecting this but I failed twice because git is chocking on the merge
> commits. Currently out of ideas but I'm pasting the git bisect logs in case
> anyone has got any idea.
Choking as in... doesn't compile?
> glaubitz@epyc:..glaubitz/linux-git> cat ~/sh4-bisect-5.10-regression.txt
> git bisect start
> # good: [bbf5c979011a099af5dc76498918ed7df445635b] Linux 5.9
> git bisect good bbf5c979011a099af5dc76498918ed7df445635b
> # bad: [aae5ab854e38151e69f261dbf0e3b7e396403178] Merge tag 'riscv-for-linus-5.10-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
> git bisect bad aae5ab854e38151e69f261dbf0e3b7e396403178
> # bad: [4d0e9df5e43dba52d38b251e3b909df8fa1110be] lib, uaccess: add failure injection to usercopy functions
> git bisect bad 4d0e9df5e43dba52d38b251e3b909df8fa1110be
> # bad: [f888bdf9823c85fe945c4eb3ba353f749dec3856] Merge tag 'devicetree-for-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
> git bisect bad f888bdf9823c85fe945c4eb3ba353f749dec3856
> # bad: [57218d7f2e87069f73c7a841b6ed6c1cc7acf616] Merge tag 'regmap-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
> git bisect bad 57218d7f2e87069f73c7a841b6ed6c1cc7acf616
> # bad: [39a5101f989e8d2be557136704d53990f9b402c8] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
> git bisect bad 39a5101f989e8d2be557136704d53990f9b402c8
> # bad: [ed016af52ee3035b4799ebd7d53f9ae59d5782c4] Merge tag 'locking-core-2020-10-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> git bisect bad ed016af52ee3035b4799ebd7d53f9ae59d5782c4
> # bad: [f94ab231136c53ee26b1ddda76b29218018834ff] Merge tag 'x86_cleanups_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> git bisect bad f94ab231136c53ee26b1ddda76b29218018834ff
> # good: [baab853229ec1f291cec6a70ed61ce93159d0997] Merge branch 'for-next/mte' into for-next/core
> git bisect good baab853229ec1f291cec6a70ed61ce93159d0997
> # bad: [ca1b66922a702316734bcd5ea2100e5fb8f3caa3] Merge tag 'ras_updates_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> git bisect bad ca1b66922a702316734bcd5ea2100e5fb8f3caa3
> # bad: [af9db1d6632b726a2351426ab8f34374f6f38690] Merge tag 'm68k-for-v5.10-tag1' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k
> git bisect bad af9db1d6632b726a2351426ab8f34374f6f38690
> # bad: [6734e20e39207556e17d72b5c4950d8f3a4f2de2] Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
> git bisect bad 6734e20e39207556e17d72b5c4950d8f3a4f2de2
> # good: [d433ab42fdc2c8a32e5df7d53833310f0ab9822c] arm64: random: Remove no longer needed prototypes
> git bisect good d433ab42fdc2c8a32e5df7d53833310f0ab9822c
> # bad: [55707d531af62bd87c1b7e8d66fd9798094f9b3b] tpm_tis: Add a check for invalid status
> git bisect bad 55707d531af62bd87c1b7e8d66fd9798094f9b3b
> # bad: [a4c3049784551f6622be7f9a0a2dc993d4ba3149] dt-bindings: Add SynQucer TPM MMIO as a trivial device
> git bisect bad a4c3049784551f6622be7f9a0a2dc993d4ba3149
> # bad: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
> git bisect bad d5ae56a4fe5178e289e763450362d87800f9dcac
> # first bad commit: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
> glaubitz@epyc:..glaubitz/linux-git>
Hmmm... the "bad" before your last "good" is not an ancestor of that good.
> glaubitz@epyc:..glaubitz/linux-git> cat ~/sh4-bisect-5.10-regression-2.txt
> git bisect start
> # good: [d433ab42fdc2c8a32e5df7d53833310f0ab9822c] arm64: random: Remove no longer needed prototypes
> git bisect good d433ab42fdc2c8a32e5df7d53833310f0ab9822c
> # bad: [55707d531af62bd87c1b7e8d66fd9798094f9b3b] tpm_tis: Add a check for invalid status
> git bisect bad 55707d531af62bd87c1b7e8d66fd9798094f9b3b
> # good: [f75aef392f869018f78cfedf3c320a6b3fcfda6b] Linux 5.9-rc3
> git bisect good f75aef392f869018f78cfedf3c320a6b3fcfda6b
> # bad: [6c7247f6258b2dba353c885a1b00d795a380cc85] Merge tag 'staging-5.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
> git bisect bad 6c7247f6258b2dba353c885a1b00d795a380cc85
> # good: [d824e0809ce3c9e935f3aa37381cda7fd4184f12] Merge tag 'libata-5.9-2020-09-04' of git://git.kernel.dk/linux-block
> git bisect good d824e0809ce3c9e935f3aa37381cda7fd4184f12
> # good: [d67f2ec1f5fed849d9773cd783ea161df842bbae] Merge tag 'drm-fixes-2020-09-11' of git://anongit.freedesktop.org/drm/drm
> git bisect good d67f2ec1f5fed849d9773cd783ea161df842bbae
> # good: [b952e974300be3184049a125e7cba112fe659017] Merge tag 'for-linus' of git://github.com/openrisc/linux
> git bisect good b952e974300be3184049a125e7cba112fe659017
> # good: [2a1a4bee5ef277c7dc2906d9268db61478876288] Merge tag 'char-misc-5.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
> git bisect good 2a1a4bee5ef277c7dc2906d9268db61478876288
> # bad: [54f82df2ba86e2a8e9cbf4036d192366e3905c89] iio:adc:ti-adc081c Fix alignment and data leak issues
> git bisect bad 54f82df2ba86e2a8e9cbf4036d192366e3905c89
> # bad: [95ad67577de4ea08eb8e441394e698aa4addcc0b] iio: accel: kxsd9: Fix alignment of local buffer.
> git bisect bad 95ad67577de4ea08eb8e441394e698aa4addcc0b
> # bad: [336306790b2bbf7ce837625fa3b24ba724d05838] iio: cros_ec: Set Gyroscope default frequency to 25Hz
> git bisect bad 336306790b2bbf7ce837625fa3b24ba724d05838
> # bad: [fea22e159d51c766ba70473f473a0ec914cc7e92] staging: wlan-ng: fix out of bounds read in prism2sta_probe_usb()
> git bisect bad fea22e159d51c766ba70473f473a0ec914cc7e92
> # bad: [b15b4da88be52e7455acc59318f6c97b8740b329] staging: greybus: audio: Uninitialized variable in gbaudio_remove_controls()
> git bisect bad b15b4da88be52e7455acc59318f6c97b8740b329
> # first bad commit: [b15b4da88be52e7455acc59318f6c97b8740b329] staging: greybus: audio: Uninitialized variable in gbaudio_remove_controls()
> glaubitz@epyc:..glaubitz/linux-git>
This implies it doesn't occur 100% of the time. You may need to run 3 tests each
time before declaring "good". (Good just says you didn't see it, not that it
isn't there. Race conditions, uninitialized variables, incompletely initialized
registers in hardware...)
Another thing I've sometimes done when git bisect gets confused by merges is:
git log --no-merges v5.9..master | grep '^commit'
and then manually bisect through THAT (pick a commit in the middle to try, but
only trim "after this bad" from the list. You're specifically looking for the
oldest commit where the problem manifests, which can have runs of "good" after
it due to branches. But nothing after a bad you've found can matter, and you can
usually get to one where "git log" back from that earliest bad commit you
identified is a smallish number of commits until the next known/tested good in
the history.
(Every once in a while something IS introduced by a merge commit, but you can
use that technique to prove it in an understandable way, instead of the bisect
black box.)
I'd try this myself, except for the can't reproduce the failure to distinguish
good from bad part...
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kernel crash when syncing to usb-storage
2020-11-29 20:41 ` Rob Landley
@ 2020-11-29 22:07 ` John Paul Adrian Glaubitz
0 siblings, 0 replies; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2020-11-29 22:07 UTC (permalink / raw)
To: Rob Landley; +Cc: Linux-sh list
On 11/29/20 9:41 PM, Rob Landley wrote:
> On 11/29/20 10:42 AM, John Paul Adrian Glaubitz wrote:
>> On 11/17/20 10:39 PM, John Paul Adrian Glaubitz wrote:
>>> Recently, I have started to see crashes when I try to sync a FAT filesystem
>>> on a USB pen drive. The crash is reproducible and seems to have been introduced
>>> in the 5.10 development cycle. I have not bisected the issue yet.
>>
>> I tried bisecting this but I failed twice because git is chocking on the merge
>> commits. Currently out of ideas but I'm pasting the git bisect logs in case
>> anyone has got any idea.
>
> Choking as in... doesn't compile?
No, I simply can't finding the bad commit and the bisect ends in different bad
commits which are completely unrelated changes.
>> glaubitz@epyc:..glaubitz/linux-git> cat ~/sh4-bisect-5.10-regression.txt
>> git bisect start
>> # good: [bbf5c979011a099af5dc76498918ed7df445635b] Linux 5.9
>> git bisect good bbf5c979011a099af5dc76498918ed7df445635b
>> # bad: [aae5ab854e38151e69f261dbf0e3b7e396403178] Merge tag 'riscv-for-linus-5.10-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
>> git bisect bad aae5ab854e38151e69f261dbf0e3b7e396403178
>> # bad: [4d0e9df5e43dba52d38b251e3b909df8fa1110be] lib, uaccess: add failure injection to usercopy functions
>> git bisect bad 4d0e9df5e43dba52d38b251e3b909df8fa1110be
>> # bad: [f888bdf9823c85fe945c4eb3ba353f749dec3856] Merge tag 'devicetree-for-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
>> git bisect bad f888bdf9823c85fe945c4eb3ba353f749dec3856
>> # bad: [57218d7f2e87069f73c7a841b6ed6c1cc7acf616] Merge tag 'regmap-v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
>> git bisect bad 57218d7f2e87069f73c7a841b6ed6c1cc7acf616
>> # bad: [39a5101f989e8d2be557136704d53990f9b402c8] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
>> git bisect bad 39a5101f989e8d2be557136704d53990f9b402c8
>> # bad: [ed016af52ee3035b4799ebd7d53f9ae59d5782c4] Merge tag 'locking-core-2020-10-12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
>> git bisect bad ed016af52ee3035b4799ebd7d53f9ae59d5782c4
>> # bad: [f94ab231136c53ee26b1ddda76b29218018834ff] Merge tag 'x86_cleanups_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
>> git bisect bad f94ab231136c53ee26b1ddda76b29218018834ff
>> # good: [baab853229ec1f291cec6a70ed61ce93159d0997] Merge branch 'for-next/mte' into for-next/core
>> git bisect good baab853229ec1f291cec6a70ed61ce93159d0997
>> # bad: [ca1b66922a702316734bcd5ea2100e5fb8f3caa3] Merge tag 'ras_updates_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
>> git bisect bad ca1b66922a702316734bcd5ea2100e5fb8f3caa3
>> # bad: [af9db1d6632b726a2351426ab8f34374f6f38690] Merge tag 'm68k-for-v5.10-tag1' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k
>> git bisect bad af9db1d6632b726a2351426ab8f34374f6f38690
>> # bad: [6734e20e39207556e17d72b5c4950d8f3a4f2de2] Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
>> git bisect bad 6734e20e39207556e17d72b5c4950d8f3a4f2de2
>> # good: [d433ab42fdc2c8a32e5df7d53833310f0ab9822c] arm64: random: Remove no longer needed prototypes
>> git bisect good d433ab42fdc2c8a32e5df7d53833310f0ab9822c
>> # bad: [55707d531af62bd87c1b7e8d66fd9798094f9b3b] tpm_tis: Add a check for invalid status
>> git bisect bad 55707d531af62bd87c1b7e8d66fd9798094f9b3b
>> # bad: [a4c3049784551f6622be7f9a0a2dc993d4ba3149] dt-bindings: Add SynQucer TPM MMIO as a trivial device
>> git bisect bad a4c3049784551f6622be7f9a0a2dc993d4ba3149
>> # bad: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
>> git bisect bad d5ae56a4fe5178e289e763450362d87800f9dcac
>> # first bad commit: [d5ae56a4fe5178e289e763450362d87800f9dcac] tpm: tis: add support for MMIO TPM on SynQuacer
>> glaubitz@epyc:..glaubitz/linux-git>
>
> Hmmm... the "bad" before your last "good" is not an ancestor of that good.
I might have messed up there. I will try again.
> This implies it doesn't occur 100% of the time. You may need to run 3 tests each
> time before declaring "good". (Good just says you didn't see it, not that it
> isn't there. Race conditions, uninitialized variables, incompletely initialized
> registers in hardware...)
No, it's 100% reproducible. The moment the kernel writes to USB, it crashes.
> Another thing I've sometimes done when git bisect gets confused by merges is:
>
> git log --no-merges v5.9..master | grep '^commit'
>
> and then manually bisect through THAT (pick a commit in the middle to try, but
> only trim "after this bad" from the list. You're specifically looking for the
> oldest commit where the problem manifests, which can have runs of "good" after
> it due to branches. But nothing after a bad you've found can matter, and you can
> usually get to one where "git log" back from that earliest bad commit you
> identified is a smallish number of commits until the next known/tested good in
> the history.
Thanks. I will try the bisect between v5.9 and HEAD again. Your first comment has
convinced I might have mis-tagged one or two commits as bad/good.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Kernel crash when syncing to usb-storage
[not found] <d89a074e-c0ed-5d8b-a58e-ce3d420f579e@physik.fu-berlin.de>
[not found] ` <3a807d90-44c6-7c97-ae1d-89a3f3414baf@landley.net>
2020-11-29 16:42 ` John Paul Adrian Glaubitz
@ 2020-12-18 22:06 ` John Paul Adrian Glaubitz
2 siblings, 0 replies; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2020-12-18 22:06 UTC (permalink / raw)
To: Linux-sh list; +Cc: Rob Landley
Hi!
On 11/17/20 10:39 PM, John Paul Adrian Glaubitz wrote:
> Recently, I have started to see crashes when I try to sync a FAT filesystem
> on a USB pen drive. The crash is reproducible and seems to have been introduced
> in the 5.10 development cycle. I have not bisected the issue yet.
I can no longer produce this on Linus' latest tree (v5.10-11864-ga087241716a6),
so it looks like the bug got fixed in the meantime.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-18 22:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <d89a074e-c0ed-5d8b-a58e-ce3d420f579e@physik.fu-berlin.de>
[not found] ` <3a807d90-44c6-7c97-ae1d-89a3f3414baf@landley.net>
[not found] ` <0133c4fc-81a9-7d8a-8aee-3756bd6d34a2@physik.fu-berlin.de>
2020-11-19 10:58 ` Kernel crash when syncing to usb-storage Rob Landley
2020-11-29 16:42 ` John Paul Adrian Glaubitz
2020-11-29 20:41 ` Rob Landley
2020-11-29 22:07 ` John Paul Adrian Glaubitz
2020-12-18 22:06 ` John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).