From: kirill@shutemov.name (Kirill A. Shutemov)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture page table helpers
Date: Fri, 13 Sep 2019 12:13:05 +0300 [thread overview]
Message-ID: <20190913091305.rkds4f3fqv3yjhjy@box> (raw)
In-Reply-To: <502c497a-9bf1-7d2e-95f2-cfebcd9cf1d9@arm.com>
On Fri, Sep 13, 2019@02:32:04PM +0530, Anshuman Khandual wrote:
>
> On 09/12/2019 10:44 PM, Christophe Leroy wrote:
> >
> >
> > Le 12/09/2019 ? 08:02, Anshuman Khandual a ?crit?:
> >> This adds a test module which will validate architecture page table helpers
> >> and accessors regarding compliance with generic MM semantics expectations.
> >> This will help various architectures in validating changes to the existing
> >> page table helpers or addition of new ones.
> >>
> >> Test page table and memory pages creating it's entries at various level are
> >> all allocated from system memory with required alignments. If memory pages
> >> with required size and alignment could not be allocated, then all depending
> >> individual tests are skipped.
> >>
> >
> > [...]
> >
> >>
> >> Suggested-by: Catalin Marinas <catalin.marinas at arm.com>
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual at arm.com>
> >> ---
> >> ? arch/x86/include/asm/pgtable_64_types.h |?? 2 +
> >> ? mm/Kconfig.debug??????????????????????? |? 14 +
> >> ? mm/Makefile???????????????????????????? |?? 1 +
> >> ? mm/arch_pgtable_test.c????????????????? | 429 ++++++++++++++++++++++++
> >> ? 4 files changed, 446 insertions(+)
> >> ? create mode 100644 mm/arch_pgtable_test.c
> >>
> >> diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h
> >> index 52e5f5f2240d..b882792a3999 100644
> >> --- a/arch/x86/include/asm/pgtable_64_types.h
> >> +++ b/arch/x86/include/asm/pgtable_64_types.h
> >> @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void)
> >> ? #define pgtable_l5_enabled() 0
> >> ? #endif /* CONFIG_X86_5LEVEL */
> >> ? +#define mm_p4d_folded(mm) (!pgtable_l5_enabled())
> >> +
> >
> > This is specific to x86, should go in a separate patch.
>
> Thought about it but its just a single line. Kirill suggested this in the
> previous version. There is a generic fallback definition but s390 has it's
> own. This change overrides the generic one for x86 probably as a fix or as
> an improvement. Kirill should be able to help classify it in which case it
> can be a separate patch.
I don't think it worth a separate patch.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-09-13 9:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 6:02 [PATCH V2 0/2] mm/debug: Add tests for architecture exported page table helpers Anshuman Khandual
2019-09-12 6:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture " Anshuman Khandual
2019-09-12 11:00 ` Kirill A. Shutemov
2019-09-12 12:09 ` Anshuman Khandual
2019-09-12 15:00 ` Christophe Leroy
2019-09-12 15:36 ` Christophe Leroy
2019-09-12 15:52 ` Christophe Leroy
2019-09-13 6:30 ` Christophe Leroy
2019-09-12 17:14 ` Christophe Leroy
2019-09-13 6:23 ` [PATCH] mm/pgtable/debug: Fix " Christophe Leroy
2019-09-13 6:58 ` Anshuman Khandual
2019-09-13 7:03 ` Christophe Leroy
2019-09-13 7:11 ` Christophe Leroy
2019-09-13 8:42 ` Anshuman Khandual
2019-09-13 8:51 ` Kirill A. Shutemov
2019-09-18 7:32 ` Anshuman Khandual
2019-09-19 5:44 ` Christophe Leroy
2019-09-13 9:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add " Anshuman Khandual
2019-09-13 9:13 ` Kirill A. Shutemov [this message]
2019-09-13 10:01 ` Christophe Leroy
2019-09-18 5:04 ` Anshuman Khandual
2019-09-18 16:26 ` Christophe Leroy
2019-09-18 18:22 ` Gerald Schaefer
2019-09-20 4:06 ` Anshuman Khandual
2019-09-19 4:56 ` Anshuman Khandual
2019-09-19 5:41 ` Christophe Leroy
2019-09-12 14:42 ` [PATCH V2 0/2] mm/debug: Add tests for architecture exported " Christophe Leroy
2019-09-13 6:24 ` Anshuman Khandual
2019-09-13 6:32 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913091305.rkds4f3fqv3yjhjy@box \
--to=kirill@shutemov.name \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).