* Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy
[not found] <20230405093945.3549491-1-michael.wei.hong.sit@intel.com>
@ 2023-04-05 10:07 ` Shahab Vahedi
2023-04-05 10:10 ` Shahab Vahedi
2023-04-05 10:53 ` Marek Szyprowski
0 siblings, 2 replies; 4+ messages in thread
From: Shahab Vahedi @ 2023-04-05 10:07 UTC (permalink / raw)
To: Michael Sit Wei Hong, Giuseppe Cavallaro, Alexandre Torgue,
Jose Abreu, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Ong Boon Leong, netdev,
linux-stm32, linux-arm-kernel, linux-kernel, linux, hkallweit1,
andrew, Martin Blumenstingl, Shahab Vahedi, Marek Szyprowski
Cc: Looi Hong Aun, Voon Weifeng, Lai Peter Jun Ann,
Zulkifli Muhammad Husaini, Tan Tee Min, hock.leong.kweh,
Vineet Gupta, linux-snps-arc
On 4/5/23 11:39, Michael Sit Wei Hong wrote:
> Some DT devices already have phy device configured in the DT/ACPI.
> Current implementation scans for a phy unconditionally even though
> there is a phy listed in the DT/ACPI and already attached.
>
> We should check the fwnode if there is any phy device listed in
> fwnode and decide whether to scan for a phy to attach to.y
>
> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
> ---
Works fine on ARC HSDK board.
Tested-by: Shahab Vahedi <shahab@synopsys.com>
--
Shahab
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy
2023-04-05 10:07 ` [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Shahab Vahedi
@ 2023-04-05 10:10 ` Shahab Vahedi
2023-04-05 10:53 ` Marek Szyprowski
1 sibling, 0 replies; 4+ messages in thread
From: Shahab Vahedi @ 2023-04-05 10:10 UTC (permalink / raw)
To: Michael Sit Wei Hong, Giuseppe Cavallaro, Alexandre Torgue,
Jose Abreu, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Ong Boon Leong, netdev,
linux-stm32, linux-arm-kernel, linux-kernel, linux, hkallweit1,
andrew, Martin Blumenstingl, Marek Szyprowski
Cc: Looi Hong Aun, Voon Weifeng, Lai Peter Jun Ann,
Zulkifli Muhammad Husaini, Tan Tee Min, hock.leong.kweh,
linux-snps-arc, Vineet Gupta
Cc Vineet Gupta
On 4/5/23 12:07, Shahab Vahedi wrote:
> On 4/5/23 11:39, Michael Sit Wei Hong wrote:
>> Some DT devices already have phy device configured in the DT/ACPI.
>> Current implementation scans for a phy unconditionally even though
>> there is a phy listed in the DT/ACPI and already attached.
>>
>> We should check the fwnode if there is any phy device listed in
>> fwnode and decide whether to scan for a phy to attach to.y
>>
>> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
>> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
>> ---
>
> Works fine on ARC HSDK board.
> Tested-by: Shahab Vahedi <shahab@synopsys.com>
>
--
Shahab
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy
2023-04-05 10:07 ` [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Shahab Vahedi
2023-04-05 10:10 ` Shahab Vahedi
@ 2023-04-05 10:53 ` Marek Szyprowski
2023-04-05 13:03 ` Looi, Hong Aun
1 sibling, 1 reply; 4+ messages in thread
From: Marek Szyprowski @ 2023-04-05 10:53 UTC (permalink / raw)
To: Shahab Vahedi, Michael Sit Wei Hong, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Ong Boon Leong,
netdev, linux-stm32, linux-arm-kernel, linux-kernel, linux,
hkallweit1, andrew, Martin Blumenstingl
Cc: Looi Hong Aun, Voon Weifeng, Lai Peter Jun Ann,
Zulkifli Muhammad Husaini, Tan Tee Min, hock.leong.kweh,
Vineet Gupta, linux-snps-arc
On 05.04.2023 12:07, Shahab Vahedi wrote:
> On 4/5/23 11:39, Michael Sit Wei Hong wrote:
>> Some DT devices already have phy device configured in the DT/ACPI.
>> Current implementation scans for a phy unconditionally even though
>> there is a phy listed in the DT/ACPI and already attached.
>>
>> We should check the fwnode if there is any phy device listed in
>> fwnode and decide whether to scan for a phy to attach to.y
>>
>> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
>> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
>> ---
> Works fine on ARC HSDK board.
> Tested-by: Shahab Vahedi <shahab@synopsys.com>
Tested-by: Marek Szyprowski
Works fine on Khadas VIM3, Odroid-C4 and Odroid-M1.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy
2023-04-05 10:53 ` Marek Szyprowski
@ 2023-04-05 13:03 ` Looi, Hong Aun
0 siblings, 0 replies; 4+ messages in thread
From: Looi, Hong Aun @ 2023-04-05 13:03 UTC (permalink / raw)
To: Marek Szyprowski, Shahab Vahedi, Sit, Michael Wei Hong,
Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Maxime Coquelin, Ong, Boon Leong, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, linux, hkallweit1, andrew,
Martin Blumenstingl
Cc: Voon, Weifeng, Lai, Peter Jun Ann, Zulkifli, Muhammad Husaini,
Tan, Tee Min, Kweh, Hock Leong, Vineet Gupta, linux-snps-arc
> On 05.04.2023 12:07, Shahab Vahedi wrote:
> > On 4/5/23 11:39, Michael Sit Wei Hong wrote:
> >> Some DT devices already have phy device configured in the DT/ACPI.
> >> Current implementation scans for a phy unconditionally even though
> >> there is a phy listed in the DT/ACPI and already attached.
> >>
> >> We should check the fwnode if there is any phy device listed in
> >> fwnode and decide whether to scan for a phy to attach to.y
> >>
> >> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a
> >> PHY")
> >> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
> >> ---
> > Works fine on ARC HSDK board.
> > Tested-by: Shahab Vahedi <shahab@synopsys.com>
>
> Tested-by: Marek Szyprowski
>
> Works fine on Khadas VIM3, Odroid-C4 and Odroid-M1.
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
Please fix the minor typo at the end of your commit message.
Regards,
Hong Aun
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-05 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230405093945.3549491-1-michael.wei.hong.sit@intel.com>
2023-04-05 10:07 ` [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy Shahab Vahedi
2023-04-05 10:10 ` Shahab Vahedi
2023-04-05 10:53 ` Marek Szyprowski
2023-04-05 13:03 ` Looi, Hong Aun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).