* [PATCH] dissect: use show_ident() to print dctx->ident
@ 2020-02-12 9:21 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2020-02-12 9:21 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: Alexey Gladkov, linux-sparse
I didn't know show_ident() uses 4 buffers for the string it returns and
thus it is safe to call it twice in a row.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
dissect.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/dissect.c b/dissect.c
index 499e0a0..6706690 100644
--- a/dissect.c
+++ b/dissect.c
@@ -617,16 +617,13 @@ static inline struct symbol *do_symbol(struct symbol *sym)
break; case SYM_FN:
stmt = sym->ctype.modifiers & MOD_INLINE
- ? type->inline_stmt
- : type->stmt;
+ ? type->inline_stmt : type->stmt;
if (!stmt)
break;
if (dctx)
- sparse_error(dctx->pos,
- "dissect_ctx change %.*s -> %s",
- dctx->ident->len, dctx->ident->name,
- show_ident(sym->ident));
+ sparse_error(dctx->pos, "dissect_ctx change %s -> %s",
+ show_ident(dctx->ident), show_ident(sym->ident));
dissect_ctx = sym;
do_sym_list(type->arguments);
--
2.5.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-12 9:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 9:21 [PATCH] dissect: use show_ident() to print dctx->ident Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).