* [PATCH] ir-validate: remove orphan comments
@ 2020-06-18 14:09 garritfra
2020-06-18 18:58 ` Luc Van Oostenryck
0 siblings, 1 reply; 2+ messages in thread
From: garritfra @ 2020-06-18 14:09 UTC (permalink / raw)
To: luc.vanoostenryck, linux-sparse; +Cc: garritfra
Please let me know if these comments have a right to be there, but I
think they are orphans and can be removed.
Signed-off-by: Garrit Franke <garritfranke@gmail.com>
---
optimize.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/optimize.c b/optimize.c
index e8cb7fc3..31d94e61 100644
--- a/optimize.c
+++ b/optimize.c
@@ -75,7 +75,6 @@ repeat:
*/
do {
simplify_memops(ep);
- //ir_validate(ep);
do {
repeat_phase = 0;
clean_up_insns(ep);
@@ -86,15 +85,11 @@ repeat:
if (repeat_phase & REPEAT_SYMBOL_CLEANUP)
simplify_memops(ep);
- //ir_validate(ep);
} while (repeat_phase);
pack_basic_blocks(ep);
- //ir_validate(ep);
if (repeat_phase & REPEAT_CFG_CLEANUP)
kill_unreachable_bbs(ep);
- //ir_validate(ep);
} while (repeat_phase);
- //ir_validate(ep);
vrfy_flow(ep);
@@ -111,13 +106,11 @@ repeat:
* again
*/
if (simplify_flow(ep)) {
- //ir_validate(ep);
clear_liveness(ep);
if (repeat_phase & REPEAT_CFG_CLEANUP)
kill_unreachable_bbs(ep);
goto repeat;
}
- //ir_validate(ep);
/* Finally, add deathnotes to pseudos now that we have them */
if (dbg_dead)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ir-validate: remove orphan comments
2020-06-18 14:09 [PATCH] ir-validate: remove orphan comments garritfra
@ 2020-06-18 18:58 ` Luc Van Oostenryck
0 siblings, 0 replies; 2+ messages in thread
From: Luc Van Oostenryck @ 2020-06-18 18:58 UTC (permalink / raw)
To: garritfra; +Cc: linux-sparse
On Thu, Jun 18, 2020 at 04:09:14PM +0200, garritfra wrote:
Hi,
> Please let me know if these comments have a right to be there, but I
> think they are orphans and can be removed.
Indeed, they have been commited more or less by error and have
never been removed.
Thanks for the patch.
-- Luc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-18 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 14:09 [PATCH] ir-validate: remove orphan comments garritfra
2020-06-18 18:58 ` Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).