* [PATCH] sindex: avoid a warning with 'case -1:'
@ 2020-07-04 23:54 Luc Van Oostenryck
2020-07-05 11:12 ` Alexey Gladkov
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2020-07-04 23:54 UTC (permalink / raw)
To: Alexey Gladkov; +Cc: linux-sparse, Luc Van Oostenryck
When parsing the format, there is a 'case -1:' which:
* seems to be there only for the following label (but mixing
labels with cases, like here, is OK).
* on architectures where chars are unsigned, the compiler complains:
warning: case label value is less than minimum value for type
So, remove the unneeded 'case -1:' and use an explicit 'default:'
to catch invalid formats. Also, align the label with the cases,
it looks nicer so.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
sindex.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sindex.c b/sindex.c
index ea092a4a434b..22836a957213 100644
--- a/sindex.c
+++ b/sindex.c
@@ -970,8 +970,8 @@ static int search_query_callback(void *data, int argc, char **argv, char **colna
print_file_line(argv[0], atoi(argv[1]));
fmt++;
break;
- case -1:
-print_string:
+
+ print_string:
if (n) {
printf("%.*s", n, buf);
n = 0;
@@ -979,6 +979,9 @@ print_string:
printf("%s", argv[colnum]);
fmt++;
break;
+ default:
+ break;
+
}
if (pos == fmt)
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sindex: avoid a warning with 'case -1:'
2020-07-04 23:54 [PATCH] sindex: avoid a warning with 'case -1:' Luc Van Oostenryck
@ 2020-07-05 11:12 ` Alexey Gladkov
2020-07-05 11:45 ` Luc Van Oostenryck
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Gladkov @ 2020-07-05 11:12 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: linux-sparse
On Sun, Jul 05, 2020 at 01:54:53AM +0200, Luc Van Oostenryck wrote:
> When parsing the format, there is a 'case -1:' which:
> * seems to be there only for the following label (but mixing
> labels with cases, like here, is OK).
> * on architectures where chars are unsigned, the compiler complains:
> warning: case label value is less than minimum value for type
>
> So, remove the unneeded 'case -1:' and use an explicit 'default:'
> to catch invalid formats. Also, align the label with the cases,
> it looks nicer so.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Looks good :)
Reviewed-by: Alexey Gladkov <gladkov.alexey@gmail.com>
> ---
> sindex.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/sindex.c b/sindex.c
> index ea092a4a434b..22836a957213 100644
> --- a/sindex.c
> +++ b/sindex.c
> @@ -970,8 +970,8 @@ static int search_query_callback(void *data, int argc, char **argv, char **colna
> print_file_line(argv[0], atoi(argv[1]));
> fmt++;
> break;
> - case -1:
> -print_string:
> +
> + print_string:
> if (n) {
> printf("%.*s", n, buf);
> n = 0;
> @@ -979,6 +979,9 @@ print_string:
> printf("%s", argv[colnum]);
> fmt++;
> break;
> + default:
> + break;
> +
> }
>
> if (pos == fmt)
> --
> 2.27.0
>
--
Rgrds, legion
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 23:54 [PATCH] sindex: avoid a warning with 'case -1:' Luc Van Oostenryck
2020-07-05 11:12 ` Alexey Gladkov
2020-07-05 11:45 ` Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).