linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix diagnostic source path from command line
@ 2020-08-02 14:40 Luc Van Oostenryck
  0 siblings, 0 replies; only message in thread
From: Luc Van Oostenryck @ 2020-08-02 14:40 UTC (permalink / raw)
  To: linux-sparse; +Cc: Luc Van Oostenryck

Now, diagnostic messages are prepended with the source path.
But if the problem comes from a file included directly from
the command line like:
	sparse -include some-buggy-file.c

the prepended message will be:
	(null): note: in included file ...

because there isn't a source path yet.

So, initialize the source path to "command-line".

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 lib.c                                         |  2 ++
 validation/preprocessor/bad-cmdline-include.c | 11 +++++++++++
 2 files changed, 13 insertions(+)
 create mode 100644 validation/preprocessor/bad-cmdline-include.c

diff --git a/lib.c b/lib.c
index 2b600fee26cc..4bc5cd028781 100644
--- a/lib.c
+++ b/lib.c
@@ -383,6 +383,8 @@ struct symbol_list *sparse_initialize(int argc, char **argv, struct string_list
 	char **args;
 	struct symbol_list *list;
 
+	base_filename = "command-line";
+
 	// Initialize symbol stream first, so that we can add defines etc
 	init_symbols();
 
diff --git a/validation/preprocessor/bad-cmdline-include.c b/validation/preprocessor/bad-cmdline-include.c
new file mode 100644
index 000000000000..e4ee03f450c4
--- /dev/null
+++ b/validation/preprocessor/bad-cmdline-include.c
@@ -0,0 +1,11 @@
+#error some random error
+
+/*
+ * check-name: bad-cmdline-include
+ * check-command: sparse -include $file
+ *
+ * check-error-start
+command-line: note: in included file (through builtin):
+preprocessor/bad-cmdline-include.c:1:2: error: some random error
+ * check-error-end
+ */
-- 
2.28.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-02 14:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 14:40 [PATCH] fix diagnostic source path from command line Luc Van Oostenryck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).