[GIT PULL] SPDX update for 5.2-rc3 - round 2

[GIT PULL] SPDX update for 5.2-rc3 - round 2

[Greg KH]

The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:

  Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2

for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:

  treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)

----------------------------------------------------------------
SPDX fixes for 5.2-rc3, round 2

Here are just two small patches, that fix up some found SPDX identifier
issues.

The first patch fixes an error in a previous SPDX fixup patch, that
causes build errors when doing 'make clean' on the tree (the fact that
almost no one noticed it reflects the fact that kernel developers don't
like doing that option very often...)

The second patch fixes up a number of places in the tree where people
mistyped the string "SPDX-License-Identifier".  Given that people can
not even type their own name all the time without mistakes, this was
bound to happen, and odds are, we will have to add some type of check
for this to checkpatch.pl to catch this happening in the future.

Both of these have passed testing by 0-day.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

----------------------------------------------------------------
Alex Xu (Hello71) (1):
      crypto: ux500 - fix license comment syntax error

Masahiro Yamada (1):
      treewide: fix typos of SPDX-License-Identifier

 arch/arm/kernel/bugs.c                | 2 +-
 drivers/crypto/ux500/cryp/Makefile    | 2 +-
 drivers/phy/st/phy-stm32-usbphyc.c    | 2 +-
 drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
 lib/test_stackinit.c                  | 2 +-
 sound/soc/codecs/max9759.c            | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Masahiro Yamada]

On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
>
>   Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
>
> for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
>
>   treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
>
> ----------------------------------------------------------------
> SPDX fixes for 5.2-rc3, round 2
>
> Here are just two small patches, that fix up some found SPDX identifier
> issues.
>
> The first patch fixes an error in a previous SPDX fixup patch, that
> causes build errors when doing 'make clean' on the tree (the fact that
> almost no one noticed it reflects the fact that kernel developers don't
> like doing that option very often...)

This paragraph is not precise.

Not only "make clean", but also the normal build is broken.
In fact, ARCH=arm allmodconfig is broken.


$ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
  [ snip ]
$ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
  [ snip ]
drivers/crypto/ux500/cryp/Makefile:5: *** missing separator.  Stop.
make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
make[1]: *** Waiting for unfinished jobs....



The 0-day bot should check allmodconfig for all arches,
but surprisingly it was not caught before the merge.



> The second patch fixes up a number of places in the tree where people
> mistyped the string "SPDX-License-Identifier".  Given that people can
> not even type their own name all the time without mistakes, this was
> bound to happen, and odds are, we will have to add some type of check
> for this to checkpatch.pl to catch this happening in the future.

checkpatch.pl already warns
"Missing or malformed SPDX-License-Identifier tag"
unless correctly typed "SPDX-License-Identifier" is found in the file.

No more check is needed for this, I think.

Not all developers run scripts/checkpatch.pl before patch submission.
Not all maintainers run scripts/checkpatch.pl before commit.

Thanks.


> Both of these have passed testing by 0-day.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ----------------------------------------------------------------
> Alex Xu (Hello71) (1):
>       crypto: ux500 - fix license comment syntax error
>
> Masahiro Yamada (1):
>       treewide: fix typos of SPDX-License-Identifier
>
>  arch/arm/kernel/bugs.c                | 2 +-
>  drivers/crypto/ux500/cryp/Makefile    | 2 +-
>  drivers/phy/st/phy-stm32-usbphyc.c    | 2 +-
>  drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
>  lib/test_stackinit.c                  | 2 +-
>  sound/soc/codecs/max9759.c            | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)



-- 
Best Regards
Masahiro Yamada

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Joe Perches]

On Sun, 2019-06-02 at 08:39 +0200, Greg KH wrote:
> The second patch fixes up a number of places in the tree where people
> mistyped the string "SPDX-License-Identifier".  Given that people can
> not even type their own name all the time without mistakes, this was
> bound to happen, and odds are, we will have to add some type of check
> for this to checkpatch.pl to catch this happening in the future.
[]
>  arch/arm/kernel/bugs.c                | 2 +-
>  drivers/crypto/ux500/cryp/Makefile    | 2 +-
>  drivers/phy/st/phy-stm32-usbphyc.c    | 2 +-
>  drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
>  lib/test_stackinit.c                  | 2 +-
>  sound/soc/codecs/max9759.c            | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)

checkpatch already gives a warning for each of these files
except the Makefile as it has no filename extension.
Filenames without extensions are not checked.

$ ./scripts/checkpatch.pl -f --types=SPDX_LICENSE_TAG --nosummary --terse \
	arch/arm/kernel/bugs.c \
	drivers/crypto/ux500/cryp/Makefile \
	drivers/phy/st/phy-stm32-usbphyc.c \
	drivers/pinctrl/sh-pfc/pfc-r8a77980.c \
	lib/test_stackinit.c \
	sound/soc/codecs/max9759.c
arch/arm/kernel/bugs.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
drivers/phy/st/phy-stm32-usbphyc.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
drivers/pinctrl/sh-pfc/pfc-r8a77980.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
lib/test_stackinit.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
sound/soc/codecs/max9759.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Greg KH]

On Sun, Jun 02, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote:
> On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
> >
> >   Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
> >
> > for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
> >
> >   treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
> >
> > ----------------------------------------------------------------
> > SPDX fixes for 5.2-rc3, round 2
> >
> > Here are just two small patches, that fix up some found SPDX identifier
> > issues.
> >
> > The first patch fixes an error in a previous SPDX fixup patch, that
> > causes build errors when doing 'make clean' on the tree (the fact that
> > almost no one noticed it reflects the fact that kernel developers don't
> > like doing that option very often...)
> 
> This paragraph is not precise.
> 
> Not only "make clean", but also the normal build is broken.
> In fact, ARCH=arm allmodconfig is broken.
> 
> 
> $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
>   [ snip ]
> $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>   [ snip ]
> drivers/crypto/ux500/cryp/Makefile:5: *** missing separator.  Stop.
> make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
> make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
> make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 
> 
> 
> The 0-day bot should check allmodconfig for all arches,
> but surprisingly it was not caught before the merge.

Ah, good catch, odd that 0-day missed it.  Maybe it is not building
32bit builds these days :(

> > The second patch fixes up a number of places in the tree where people
> > mistyped the string "SPDX-License-Identifier".  Given that people can
> > not even type their own name all the time without mistakes, this was
> > bound to happen, and odds are, we will have to add some type of check
> > for this to checkpatch.pl to catch this happening in the future.
> 
> checkpatch.pl already warns
> "Missing or malformed SPDX-License-Identifier tag"
> unless correctly typed "SPDX-License-Identifier" is found in the file.
> 
> No more check is needed for this, I think.

Ok, thanks, I thought it was not caught which is why it snuck in.

> Not all developers run scripts/checkpatch.pl before patch submission.
> Not all maintainers run scripts/checkpatch.pl before commit.

Very true :(

thanks,

greg k-h

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[pr-tracker-bot]

The pull request you sent on Sun, 2 Jun 2019 08:39:05 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a68dc6188242e1cc6f72eb3361e71633b4bc02a7

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Masahiro Yamada]

On Mon, Jun 3, 2019 at 2:15 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Jun 02, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote:
> > On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
> > >
> > >   Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
> > >
> > > for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
> > >
> > >   treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
> > >
> > > ----------------------------------------------------------------
> > > SPDX fixes for 5.2-rc3, round 2
> > >
> > > Here are just two small patches, that fix up some found SPDX identifier
> > > issues.
> > >
> > > The first patch fixes an error in a previous SPDX fixup patch, that
> > > causes build errors when doing 'make clean' on the tree (the fact that
> > > almost no one noticed it reflects the fact that kernel developers don't
> > > like doing that option very often...)
> >
> > This paragraph is not precise.
> >
> > Not only "make clean", but also the normal build is broken.
> > In fact, ARCH=arm allmodconfig is broken.
> >
> >
> > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
> >   [ snip ]
> > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >   [ snip ]
> > drivers/crypto/ux500/cryp/Makefile:5: *** missing separator.  Stop.
> > make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
> > make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
> > make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> >
> >
> >
> > The 0-day bot should check allmodconfig for all arches,
> > but surprisingly it was not caught before the merge.
>
> Ah, good catch, odd that 0-day missed it.  Maybe it is not building
> 32bit builds these days :(


I noticed the SPDX patches were submitted to
linux-spdx@vger.kernel.org
but not to linux-kernel@vger.kernel.org

Maybe, the reason is why 0-day bot is not subscribing to
linux-spdx@vger.kernel.org


You picked up them and sent a pull request immediately,
so the 0-day bot was not given time to test your branch either.



>> Not all developers run scripts/checkpatch.pl before patch submission.
>> Not all maintainers run scripts/checkpatch.pl before commit.
>
>Very true :(


If we really want to improve the situation,
perhaps can we ask Intel to run scripts/checkpatch.pl in the 0-day bot?

checkpatch.pl may warn false positives,
but at least "Missing or malformed SPDX-License-Identifier tag"
is a good checker.  Just my two cents.

-- 
Best Regards
Masahiro Yamada

Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Greg KH]

On Mon, Jun 03, 2019 at 09:15:08AM +0900, Masahiro Yamada wrote:
> On Mon, Jun 3, 2019 at 2:15 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, Jun 02, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote:
> > > On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
> > > >
> > > >   Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
> > > >
> > > > for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
> > > >
> > > >   treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > SPDX fixes for 5.2-rc3, round 2
> > > >
> > > > Here are just two small patches, that fix up some found SPDX identifier
> > > > issues.
> > > >
> > > > The first patch fixes an error in a previous SPDX fixup patch, that
> > > > causes build errors when doing 'make clean' on the tree (the fact that
> > > > almost no one noticed it reflects the fact that kernel developers don't
> > > > like doing that option very often...)
> > >
> > > This paragraph is not precise.
> > >
> > > Not only "make clean", but also the normal build is broken.
> > > In fact, ARCH=arm allmodconfig is broken.
> > >
> > >
> > > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
> > >   [ snip ]
> > > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> > >   [ snip ]
> > > drivers/crypto/ux500/cryp/Makefile:5: *** missing separator.  Stop.
> > > make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
> > > make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
> > > make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
> > > make[1]: *** Waiting for unfinished jobs....
> > >
> > >
> > >
> > > The 0-day bot should check allmodconfig for all arches,
> > > but surprisingly it was not caught before the merge.
> >
> > Ah, good catch, odd that 0-day missed it.  Maybe it is not building
> > 32bit builds these days :(
> 
> 
> I noticed the SPDX patches were submitted to
> linux-spdx@vger.kernel.org
> but not to linux-kernel@vger.kernel.org
> 
> Maybe, the reason is why 0-day bot is not subscribing to
> linux-spdx@vger.kernel.org
> 
> 
> You picked up them and sent a pull request immediately,
> so the 0-day bot was not given time to test your branch either.

No, I got a response from the 0-day bot, it said it tested my branch but
timed out doing more tests because it was busy.  It seems the bot is not
working that well at the moment as it is giving me this same "limited"
testing for all of my trees right now :(

> >> Not all developers run scripts/checkpatch.pl before patch submission.
> >> Not all maintainers run scripts/checkpatch.pl before commit.
> >
> >Very true :(
> 
> 
> If we really want to improve the situation,
> perhaps can we ask Intel to run scripts/checkpatch.pl in the 0-day bot?
> 
> checkpatch.pl may warn false positives,
> but at least "Missing or malformed SPDX-License-Identifier tag"
> is a good checker.  Just my two cents.

Sounds like something good to be added to 0-day, please propose it to
the developers.  But let them fix whatever is currently not working with
it first :)

thanks,

greg k-h