From: Emil Velikov <emil.l.velikov@gmail.com>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, corbet@lwn.net, airlied@linux.ie,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, rfontana@redhat.com,
gregkh@linuxfoundation.org, joe@perches.com,
linux-spdx@archiver.kernel.org, tglx@linutronix.de,
sean@poorly.run
Subject: Re: [PATCH v3] gpu/drm_memory: fix a few warnings
Date: Mon, 15 Jul 2019 12:02:28 +0100 [thread overview]
Message-ID: <20190715110228.GD20839@arch-x1c3> (raw)
In-Reply-To: <1562960735.8510.30.camel@lca.pw>
Hi Qian,
On 2019/07/12, Qian Cai wrote:
> Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
> about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
> this as there is no feedback from any of them for months since v1.
>
AFAICT there are a couple of reasons why this has gone unnoticed:
- summary is the pretty ambiguous
- commit does two thigs
Another thing to consider is that this patch touches a single file,
while the exact same issue is also present in many other files.
Quick look at the following lists:
head -n2 drivers/gpu/drm/drm_*[ch] | less
drm_agpsupport.c
drm_dma.c
drm_legacy_misc.c
drm_lock.c
drm_memory.c
drm_scatter.c
drm_vm.c
If you can fixup the s|/**|/*| in the above, I'd gladly merge the patch.
On the topic of SPDX - no objection on my end, but it should be a
separate patch, which replaces the explicit verbose license text with
the tag.
Thanks
Emil
prev parent reply other threads:[~2019-07-15 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 15:13 [PATCH v3] gpu/drm_memory: fix a few warnings Qian Cai
2019-07-12 19:45 ` Qian Cai
2019-07-15 11:02 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715110228.GD20839@arch-x1c3 \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@archiver.kernel.org \
--cc=rfontana@redhat.com \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).