Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license
@ 2019-10-18  4:50 Masahiro Yamada
  2019-10-18 10:15 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2019-10-18  4:50 UTC (permalink / raw)
  To: Thomas Gleixner, Greg Kroah-Hartman, linux-kernel, linux-spdx
  Cc: Masahiro Yamada

Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
identifier to files with no license") took care of a lot of files
without any license information.

These headers were not processed by the tool perhaps because they
contain "GPL" in the code.

I do not see any license boilerplate in them, so they fall back to
GPL version 2 only, which is the project default.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/asm-generic/export.h | 1 +
 include/linux/export.h       | 1 +
 include/linux/license.h      | 1 +
 include/linux/module.h       | 7 +++++--
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
index a3983e2ce0fd..afddc5442e92 100644
--- a/include/asm-generic/export.h
+++ b/include/asm-generic/export.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
 #ifndef __ASM_GENERIC_EXPORT_H
 #define __ASM_GENERIC_EXPORT_H
 
diff --git a/include/linux/export.h b/include/linux/export.h
index 621158ecd2e2..f86ba7b11c1f 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
 #ifndef _LINUX_EXPORT_H
 #define _LINUX_EXPORT_H
 
diff --git a/include/linux/license.h b/include/linux/license.h
index decdbf43cb5c..7cce390f120b 100644
--- a/include/linux/license.h
+++ b/include/linux/license.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
 #ifndef __LICENSE_H
 #define __LICENSE_H
 
diff --git a/include/linux/module.h b/include/linux/module.h
index 6d20895e7739..bd165ba68617 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -1,11 +1,14 @@
-#ifndef _LINUX_MODULE_H
-#define _LINUX_MODULE_H
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * Dynamic loading of modules into the kernel.
  *
  * Rewritten by Richard Henderson <rth@tamu.edu> Dec 1996
  * Rewritten again by Rusty Russell, 2002
  */
+
+#ifndef _LINUX_MODULE_H
+#define _LINUX_MODULE_H
+
 #include <linux/list.h>
 #include <linux/stat.h>
 #include <linux/compiler.h>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license
  2019-10-18  4:50 [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license Masahiro Yamada
@ 2019-10-18 10:15 ` Greg Kroah-Hartman
  2019-11-13 11:46   ` Masahiro Yamada
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-10-18 10:15 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Thomas Gleixner, linux-kernel, linux-spdx

On Fri, Oct 18, 2019 at 01:50:53PM +0900, Masahiro Yamada wrote:
> Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
> identifier to files with no license") took care of a lot of files
> without any license information.
> 
> These headers were not processed by the tool perhaps because they
> contain "GPL" in the code.
> 
> I do not see any license boilerplate in them, so they fall back to
> GPL version 2 only, which is the project default.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Ah, nice catch!

I'll queue this up to my spdx tree if no one objects.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license
  2019-10-18 10:15 ` Greg Kroah-Hartman
@ 2019-11-13 11:46   ` Masahiro Yamada
  2019-11-14  3:32     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2019-11-13 11:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Thomas Gleixner, Linux Kernel Mailing List, linux-spdx

On Fri, Oct 18, 2019 at 7:15 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Oct 18, 2019 at 01:50:53PM +0900, Masahiro Yamada wrote:
> > Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
> > identifier to files with no license") took care of a lot of files
> > without any license information.
> >
> > These headers were not processed by the tool perhaps because they
> > contain "GPL" in the code.
> >
> > I do not see any license boilerplate in them, so they fall back to
> > GPL version 2 only, which is the project default.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Ah, nice catch!
>
> I'll queue this up to my spdx tree if no one objects.
>
> thanks,
>
> greg k-h


No objection (comment) so far.

I think it is OK to apply this.



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license
  2019-11-13 11:46   ` Masahiro Yamada
@ 2019-11-14  3:32     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-14  3:32 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Thomas Gleixner, Linux Kernel Mailing List, linux-spdx

On Wed, Nov 13, 2019 at 08:46:11PM +0900, Masahiro Yamada wrote:
> On Fri, Oct 18, 2019 at 7:15 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Oct 18, 2019 at 01:50:53PM +0900, Masahiro Yamada wrote:
> > > Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
> > > identifier to files with no license") took care of a lot of files
> > > without any license information.
> > >
> > > These headers were not processed by the tool perhaps because they
> > > contain "GPL" in the code.
> > >
> > > I do not see any license boilerplate in them, so they fall back to
> > > GPL version 2 only, which is the project default.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >
> > Ah, nice catch!
> >
> > I'll queue this up to my spdx tree if no one objects.
> >
> > thanks,
> >
> > greg k-h
> 
> 
> No objection (comment) so far.
> 
> I think it is OK to apply this.

Ok, will go do so, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18  4:50 [PATCH] export,module: add SPDX GPL-2.0 license identifier to headers with no license Masahiro Yamada
2019-10-18 10:15 ` Greg Kroah-Hartman
2019-11-13 11:46   ` Masahiro Yamada
2019-11-14  3:32     ` Greg Kroah-Hartman

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org
	public-inbox-index linux-spdx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git