* [PATCH] scripts/spdxcheck-test.sh: Drop python2
@ 2021-07-07 21:06 Nishanth Menon
0 siblings, 0 replies; only message in thread
From: Nishanth Menon @ 2021-07-07 21:06 UTC (permalink / raw)
To: Greg Kroah-Hartman, Thomas Gleixner
Cc: linux-kernel, linux-spdx, Nishanth Menon, Bert Vermeulen
Since commit d0259c42abff ("spdxcheck.py: Use Python 3"), spdxcheck.py
explicitly expects to run as python3 script, there is no further point
in attempting to test with python2.
Cc: Bert Vermeulen <bert@biot.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Also see checkpatch.pl patch
https://lore.kernel.org/lkml/20210505211720.447111-1-linux@roeck-us.net/
PS: While it may be debatable if *ever* there is going to be a python4
and hence leave the for loop alone (in addition to reducing the
diffstat). I just took the path where I hope if we ever see that day,
we pick one version.
scripts/spdxcheck-test.sh | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
index cfea6a0d1cc0..cb76324756bd 100644
--- a/scripts/spdxcheck-test.sh
+++ b/scripts/spdxcheck-test.sh
@@ -1,12 +1,10 @@
#!/bin/sh
-for PYTHON in python2 python3; do
- # run check on a text and a binary file
- for FILE in Makefile Documentation/logo.gif; do
- $PYTHON scripts/spdxcheck.py $FILE
- $PYTHON scripts/spdxcheck.py - < $FILE
- done
-
- # run check on complete tree to catch any other issues
- $PYTHON scripts/spdxcheck.py > /dev/null
+# run check on a text and a binary file
+for FILE in Makefile Documentation/logo.gif; do
+ python3 scripts/spdxcheck.py $FILE
+ python3 scripts/spdxcheck.py - < $FILE
done
+
+# run check on complete tree to catch any other issues
+python3 scripts/spdxcheck.py > /dev/null
--
2.32.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-07 21:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 21:06 [PATCH] scripts/spdxcheck-test.sh: Drop python2 Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).