* [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 @ 2019-06-05 14:10 Thomas Gleixner 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Thomas Gleixner @ 2019-06-05 14:10 UTC (permalink / raw) To: linux-spdx This is the fifth variant of disclaimer modifications. Standard disclaimer: this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose Modified disclaimer: this software is provided as is and without any express or implied warranties including without limitation the implied warranties of merchantability and fitness for a particular purpose So as with the previous 4, I don't see anything contradicting or substantially different. In case we agree on that, I would amend the changelogs of the individual patches with a paragraph explaining our conclusion. Something along the lines: The pattern deviates from the standard GPLv2 disclaimer, but the modifications do not expand beyond the standard disclaimer and the NO WARRANTY section of the GPLv2. So replacing the license notice including the modified disclaimer with the SPDX license identifier results in the same protections and conditions. Feel free to suggest better wording or deeper explanation. Thanks, tglx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 2019-06-05 14:10 [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Thomas Gleixner @ 2019-06-05 14:10 ` Thomas Gleixner 2019-06-05 17:05 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 2019-06-05 14:10 ` [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 Thomas Gleixner 2019-06-08 19:42 ` [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Allison Randal 2 siblings, 2 replies; 9+ messages in thread From: Thomas Gleixner @ 2019-06-05 14:10 UTC (permalink / raw) To: linux-spdx From: Thomas Gleixner tglx@linutronix.de Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation you should have received a copy of the gnu general public license along with this program if not see http www gnu org licenses this software is provided as is and without any express or implied warranties including without limitation the implied warranties of merchantability and fitness for a particular purpose extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 15 file(s). Bucket: ASIS-5 Signed-off-by: Thomas Gleixner <tglx@linutronix.de> diff --git a/drivers/net/ethernet/chelsio/cxgb/common.h b/drivers/net/ethernet/chelsio/cxgb/common.h index 94b9482f14a5..cd8514bbc3f2 100644 --- a/drivers/net/ethernet/chelsio/cxgb/common.h https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=asis-5&id=8f9d721711fa --- +++ b/drivers/net/ethernet/chelsio/cxgb/common.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: common.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/cphy.h b/drivers/net/ethernet/chelsio/cxgb/cphy.h index bf43da6c6a63..12639b688ddc 100644 --- a/drivers/net/ethernet/chelsio/cxgb/cphy.h +++ b/drivers/net/ethernet/chelsio/cxgb/cphy.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: cphy.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h b/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h index 5249686afe71..4397448c997b 100644 --- a/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h +++ b/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: cpl5_cmd.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c index 0ccdde366ae1..53e5415e41d6 100644 --- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c +++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: cxgb2.c * @@ -6,16 +7,6 @@ * Description: * * Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/elmer0.h b/drivers/net/ethernet/chelsio/cxgb/elmer0.h index 81526ad36339..793302604c9c 100644 --- a/drivers/net/ethernet/chelsio/cxgb/elmer0.h +++ b/drivers/net/ethernet/chelsio/cxgb/elmer0.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: elmer0.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/espi.c b/drivers/net/ethernet/chelsio/cxgb/espi.c index 3e182eee799e..ef70569435be 100644 --- a/drivers/net/ethernet/chelsio/cxgb/espi.c +++ b/drivers/net/ethernet/chelsio/cxgb/espi.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: espi.c * @@ -7,16 +8,6 @@ * Ethernet SPI functionality. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/espi.h b/drivers/net/ethernet/chelsio/cxgb/espi.h index 162de5259df9..f588e9f3b37a 100644 --- a/drivers/net/ethernet/chelsio/cxgb/espi.h +++ b/drivers/net/ethernet/chelsio/cxgb/espi.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: espi.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/gmac.h b/drivers/net/ethernet/chelsio/cxgb/gmac.h index dfa77491a910..98ead0cf2e72 100644 --- a/drivers/net/ethernet/chelsio/cxgb/gmac.h +++ b/drivers/net/ethernet/chelsio/cxgb/gmac.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: gmac.h * @@ -7,16 +8,6 @@ * Generic MAC functionality. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c b/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c index 7ddb301bcba0..556c8ad68fa8 100644 --- a/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c +++ b/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: mv88x201x.c * @@ -7,16 +8,6 @@ * Marvell PHY (mv88x201x) functionality. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/pm3393.c b/drivers/net/ethernet/chelsio/cxgb/pm3393.c index c27908e66f5e..d01da64d67ef 100644 --- a/drivers/net/ethernet/chelsio/cxgb/pm3393.c +++ b/drivers/net/ethernet/chelsio/cxgb/pm3393.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: pm3393.c * @@ -7,16 +8,6 @@ * PMC/SIERRA (pm3393) MAC-PHY functionality. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/regs.h b/drivers/net/ethernet/chelsio/cxgb/regs.h index 964ce59ee169..f751e680cf7d 100644 --- a/drivers/net/ethernet/chelsio/cxgb/regs.h +++ b/drivers/net/ethernet/chelsio/cxgb/regs.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: regs.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.c b/drivers/net/ethernet/chelsio/cxgb/sge.c index 47b5c8e2104b..f35fc1576a6c 100644 --- a/drivers/net/ethernet/chelsio/cxgb/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb/sge.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: sge.c * @@ -7,16 +8,6 @@ * DMA engine. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.h b/drivers/net/ethernet/chelsio/cxgb/sge.h index a1ba591b3431..793cca414a66 100644 --- a/drivers/net/ethernet/chelsio/cxgb/sge.h +++ b/drivers/net/ethernet/chelsio/cxgb/sge.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: sge.h * @@ -6,16 +7,6 @@ * Description: * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/subr.c b/drivers/net/ethernet/chelsio/cxgb/subr.c index ea0f8741d7cf..99372cc40fde 100644 --- a/drivers/net/ethernet/chelsio/cxgb/subr.c +++ b/drivers/net/ethernet/chelsio/cxgb/subr.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /***************************************************************************** * * * File: subr.c * @@ -7,16 +8,6 @@ * Various subroutines (intr,pio,etc.) used by Chelsio 10G Ethernet driver. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * diff --git a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h index 7f79cc7ceb75..a0a2f720f158 100644 --- a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h +++ b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /***************************************************************************** * * * File: suni1x10gexp_regs.h * @@ -7,16 +8,6 @@ * PMC/SIERRA (pm3393) MAC-PHY functionality. * * part of the Chelsio 10Gb Ethernet Driver. * * * - * This program is free software; you can redistribute it and/or modify * - * it under the terms of the GNU General Public License, version 2, as * - * published by the Free Software Foundation. * - * * - * You should have received a copy of the GNU General Public License along * - * with this program; if not, see <http://www.gnu.org/licenses/>. * - * * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * * * * http://www.chelsio.com * * * ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner @ 2019-06-05 17:05 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 1 sibling, 0 replies; 9+ messages in thread From: Enrico Weigelt, metux IT consult @ 2019-06-05 17:05 UTC (permalink / raw) To: Thomas Gleixner, linux-spdx On 05.06.19 14:10, Thomas Gleixner wrote: > From: Thomas Gleixner tglx@linutronix.de > > Based on 1 normalized pattern(s): > > this program is free software you can redistribute it and or modify > it under the terms of the gnu general public license version 2 as > published by the free software foundation you should have received a > copy of the gnu general public license along with this program if > not see http www gnu org licenses this software is provided as is > and without any express or implied warranties including without > limitation the implied warranties of merchantability and fitness for > a particular purpose > > extracted by the scancode license scanner the SPDX license identifier > > GPL-2.0-only > > has been chosen to replace the boilerplate/reference in 15 file(s). > > Bucket: ASIS-5 > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > diff --git a/drivers/net/ethernet/chelsio/cxgb/common.h b/drivers/net/ethernet/chelsio/cxgb/common.h > index 94b9482f14a5..cd8514bbc3f2 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/common.h > https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=asis-5&id=8f9d721711fa > --- > +++ b/drivers/net/ethernet/chelsio/cxgb/common.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: common.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/cphy.h b/drivers/net/ethernet/chelsio/cxgb/cphy.h > index bf43da6c6a63..12639b688ddc 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/cphy.h > +++ b/drivers/net/ethernet/chelsio/cxgb/cphy.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: cphy.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h b/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h > index 5249686afe71..4397448c997b 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h > +++ b/drivers/net/ethernet/chelsio/cxgb/cpl5_cmd.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: cpl5_cmd.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c > index 0ccdde366ae1..53e5415e41d6 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c > +++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: cxgb2.c * > @@ -6,16 +7,6 @@ > * Description: * > * Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/elmer0.h b/drivers/net/ethernet/chelsio/cxgb/elmer0.h > index 81526ad36339..793302604c9c 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/elmer0.h > +++ b/drivers/net/ethernet/chelsio/cxgb/elmer0.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: elmer0.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/espi.c b/drivers/net/ethernet/chelsio/cxgb/espi.c > index 3e182eee799e..ef70569435be 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/espi.c > +++ b/drivers/net/ethernet/chelsio/cxgb/espi.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: espi.c * > @@ -7,16 +8,6 @@ > * Ethernet SPI functionality. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/espi.h b/drivers/net/ethernet/chelsio/cxgb/espi.h > index 162de5259df9..f588e9f3b37a 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/espi.h > +++ b/drivers/net/ethernet/chelsio/cxgb/espi.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: espi.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/gmac.h b/drivers/net/ethernet/chelsio/cxgb/gmac.h > index dfa77491a910..98ead0cf2e72 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/gmac.h > +++ b/drivers/net/ethernet/chelsio/cxgb/gmac.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: gmac.h * > @@ -7,16 +8,6 @@ > * Generic MAC functionality. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c b/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c > index 7ddb301bcba0..556c8ad68fa8 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c > +++ b/drivers/net/ethernet/chelsio/cxgb/mv88x201x.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: mv88x201x.c * > @@ -7,16 +8,6 @@ > * Marvell PHY (mv88x201x) functionality. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/pm3393.c b/drivers/net/ethernet/chelsio/cxgb/pm3393.c > index c27908e66f5e..d01da64d67ef 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/pm3393.c > +++ b/drivers/net/ethernet/chelsio/cxgb/pm3393.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: pm3393.c * > @@ -7,16 +8,6 @@ > * PMC/SIERRA (pm3393) MAC-PHY functionality. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/regs.h b/drivers/net/ethernet/chelsio/cxgb/regs.h > index 964ce59ee169..f751e680cf7d 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/regs.h > +++ b/drivers/net/ethernet/chelsio/cxgb/regs.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: regs.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.c b/drivers/net/ethernet/chelsio/cxgb/sge.c > index 47b5c8e2104b..f35fc1576a6c 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/sge.c > +++ b/drivers/net/ethernet/chelsio/cxgb/sge.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: sge.c * > @@ -7,16 +8,6 @@ > * DMA engine. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.h b/drivers/net/ethernet/chelsio/cxgb/sge.h > index a1ba591b3431..793cca414a66 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/sge.h > +++ b/drivers/net/ethernet/chelsio/cxgb/sge.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: sge.h * > @@ -6,16 +7,6 @@ > * Description: * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/subr.c b/drivers/net/ethernet/chelsio/cxgb/subr.c > index ea0f8741d7cf..99372cc40fde 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/subr.c > +++ b/drivers/net/ethernet/chelsio/cxgb/subr.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /***************************************************************************** > * * > * File: subr.c * > @@ -7,16 +8,6 @@ > * Various subroutines (intr,pio,etc.) used by Chelsio 10G Ethernet driver. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > diff --git a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h > index 7f79cc7ceb75..a0a2f720f158 100644 > --- a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h > +++ b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /***************************************************************************** > * * > * File: suni1x10gexp_regs.h * > @@ -7,16 +8,6 @@ > * PMC/SIERRA (pm3393) MAC-PHY functionality. * > * part of the Chelsio 10Gb Ethernet Driver. * > * * > - * This program is free software; you can redistribute it and/or modify * > - * it under the terms of the GNU General Public License, version 2, as * > - * published by the Free Software Foundation. * > - * * > - * You should have received a copy of the GNU General Public License along * > - * with this program; if not, see <http://www.gnu.org/licenses/>. * > - * * > - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR IMPLIED * > - * WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF * > - * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. * > * * > * http://www.chelsio.com * > * * > > Reviewed-By: Enrico Weigelt <info@metux.net> -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner 2019-06-05 17:05 ` Enrico Weigelt, metux IT consult @ 2019-06-08 19:44 ` Allison Randal 1 sibling, 0 replies; 9+ messages in thread From: Allison Randal @ 2019-06-08 19:44 UTC (permalink / raw) To: linux-spdx On 6/5/19 10:10 AM, Thomas Gleixner wrote: > From: Thomas Gleixner tglx@linutronix.de > > Based on 1 normalized pattern(s): > > this program is free software you can redistribute it and or modify > it under the terms of the gnu general public license version 2 as > published by the free software foundation you should have received a > copy of the gnu general public license along with this program if > not see http www gnu org licenses this software is provided as is > and without any express or implied warranties including without > limitation the implied warranties of merchantability and fitness for > a particular purpose > > extracted by the scancode license scanner the SPDX license identifier > > GPL-2.0-only > > has been chosen to replace the boilerplate/reference in 15 file(s). > > Bucket: ASIS-5 > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Allison Randal <allison@lohutok.net> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 2019-06-05 14:10 [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Thomas Gleixner 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner @ 2019-06-05 14:10 ` Thomas Gleixner 2019-06-05 17:06 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 2019-06-08 19:42 ` [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Allison Randal 2 siblings, 2 replies; 9+ messages in thread From: Thomas Gleixner @ 2019-06-05 14:10 UTC (permalink / raw) To: linux-spdx From: Thomas Gleixner tglx@linutronix.de Based on 1 normalized pattern(s): this package is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this package is provided as is and without any express or implied warranties including without limitation the implied warranties of merchantibility and fitness for a particular purpose extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 3 file(s). Bucket: ASIS-5 Signed-off-by: Thomas Gleixner <tglx@linutronix.de> diff --git a/arch/arm/mach-omap1/board-sx1.h b/arch/arm/mach-omap1/board-sx1.h index 355adbdaae33..fafe54a2e444 100644 --- a/arch/arm/mach-omap1/board-sx1.h https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=asis-5&id=526b95cbf823 --- +++ b/arch/arm/mach-omap1/board-sx1.h @@ -1,15 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ /* * Siemens SX1 board definitions * * Copyright: Vovan888 at gmail com - * - * This package is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. */ #ifndef __ASM_ARCH_SX1_I2C_CHIPS_H diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c index 817be3c41863..f5809ddf0b00 100644 --- a/drivers/gpu/drm/omapdrm/tcm-sita.c +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /* * SImple Tiler Allocator (SiTA): 2D and 1D allocation(reservation) algorithm * @@ -6,15 +7,6 @@ * Andy Gross <andy.gross@ti.com> * * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ - * - * This package is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. - * */ #include <linux/init.h> #include <linux/module.h> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 195c18c2f426..3a8dbe76d70b 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-only /* * BQ27xxx battery driver * @@ -9,14 +10,6 @@ * * Based on a previous work by Copyright (C) 2008 Texas Instruments, Inc. * - * This package is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - * - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. - * * Datasheets: * http://www.ti.com/product/bq27000 * http://www.ti.com/product/bq27200 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 2019-06-05 14:10 ` [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 Thomas Gleixner @ 2019-06-05 17:06 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 1 sibling, 0 replies; 9+ messages in thread From: Enrico Weigelt, metux IT consult @ 2019-06-05 17:06 UTC (permalink / raw) To: Thomas Gleixner, linux-spdx On 05.06.19 14:10, Thomas Gleixner wrote: > From: Thomas Gleixner tglx@linutronix.de > > Based on 1 normalized pattern(s): > > this package is free software you can redistribute it and or modify > it under the terms of the gnu general public license version 2 as > published by the free software foundation this package is provided > as is and without any express or implied warranties including > without limitation the implied warranties of merchantibility and > fitness for a particular purpose > > extracted by the scancode license scanner the SPDX license identifier > > GPL-2.0-only > > has been chosen to replace the boilerplate/reference in 3 file(s). > > Bucket: ASIS-5 > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > diff --git a/arch/arm/mach-omap1/board-sx1.h b/arch/arm/mach-omap1/board-sx1.h > index 355adbdaae33..fafe54a2e444 100644 > --- a/arch/arm/mach-omap1/board-sx1.h > https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=asis-5&id=526b95cbf823 > --- > +++ b/arch/arm/mach-omap1/board-sx1.h > @@ -1,15 +1,8 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > /* > * Siemens SX1 board definitions > * > * Copyright: Vovan888 at gmail com > - * > - * This package is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED > - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. > */ > > #ifndef __ASM_ARCH_SX1_I2C_CHIPS_H > diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c b/drivers/gpu/drm/omapdrm/tcm-sita.c > index 817be3c41863..f5809ddf0b00 100644 > --- a/drivers/gpu/drm/omapdrm/tcm-sita.c > +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * SImple Tiler Allocator (SiTA): 2D and 1D allocation(reservation) algorithm > * > @@ -6,15 +7,6 @@ > * Andy Gross <andy.gross@ti.com> > * > * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ > - * > - * This package is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED > - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. > - * > */ > #include <linux/init.h> > #include <linux/module.h> > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c > index 195c18c2f426..3a8dbe76d70b 100644 > --- a/drivers/power/supply/bq27xxx_battery.c > +++ b/drivers/power/supply/bq27xxx_battery.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * BQ27xxx battery driver > * > @@ -9,14 +10,6 @@ > * > * Based on a previous work by Copyright (C) 2008 Texas Instruments, Inc. > * > - * This package is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED > - * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. > - * > * Datasheets: > * http://www.ti.com/product/bq27000 > * http://www.ti.com/product/bq27200 > > Reviewed-By: Enrico Weigelt <info@metux.net> -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 2019-06-05 14:10 ` [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 Thomas Gleixner 2019-06-05 17:06 ` Enrico Weigelt, metux IT consult @ 2019-06-08 19:44 ` Allison Randal 1 sibling, 0 replies; 9+ messages in thread From: Allison Randal @ 2019-06-08 19:44 UTC (permalink / raw) To: linux-spdx On 6/5/19 10:10 AM, Thomas Gleixner wrote: > From: Thomas Gleixner tglx@linutronix.de > > Based on 1 normalized pattern(s): > > this package is free software you can redistribute it and or modify > it under the terms of the gnu general public license version 2 as > published by the free software foundation this package is provided > as is and without any express or implied warranties including > without limitation the implied warranties of merchantibility and > fitness for a particular purpose > > extracted by the scancode license scanner the SPDX license identifier > > GPL-2.0-only > > has been chosen to replace the boilerplate/reference in 3 file(s). > > Bucket: ASIS-5 > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Allison Randal <allison@lohutok.net> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 2019-06-05 14:10 [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Thomas Gleixner 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner 2019-06-05 14:10 ` [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 Thomas Gleixner @ 2019-06-08 19:42 ` Allison Randal 2019-06-12 4:58 ` Richard Fontana 2 siblings, 1 reply; 9+ messages in thread From: Allison Randal @ 2019-06-08 19:42 UTC (permalink / raw) To: linux-spdx On 6/5/19 10:10 AM, Thomas Gleixner wrote: > This is the fifth variant of disclaimer modifications. > > Standard disclaimer: > > this program is distributed in the hope that it will be useful > but without any warranty without even the implied warranty of > merchantability or fitness for a particular purpose > > Modified disclaimer: > > this software is provided as is and without any express or implied > warranties including without limitation the implied warranties of > merchantability and fitness for a particular purpose > > So as with the previous 4, I don't see anything contradicting or > substantially different. The added wording "as is" and "express or implied" was copied from GPLv2, and so doesn't add any additional disclaimers. Allison ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 2019-06-08 19:42 ` [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Allison Randal @ 2019-06-12 4:58 ` Richard Fontana 0 siblings, 0 replies; 9+ messages in thread From: Richard Fontana @ 2019-06-12 4:58 UTC (permalink / raw) To: Allison Randal; +Cc: linux-spdx On Sat, Jun 8, 2019 at 3:42 PM Allison Randal <allison@lohutok.net> wrote: > > On 6/5/19 10:10 AM, Thomas Gleixner wrote: > > This is the fifth variant of disclaimer modifications. > > > > Standard disclaimer: > > > > this program is distributed in the hope that it will be useful > > but without any warranty without even the implied warranty of > > merchantability or fitness for a particular purpose > > > > Modified disclaimer: > > > > this software is provided as is and without any express or implied > > warranties including without limitation the implied warranties of > > merchantability and fitness for a particular purpose > > > > So as with the previous 4, I don't see anything contradicting or > > substantially different. > > The added wording "as is" and "express or implied" was copied from > GPLv2, and so doesn't add any additional disclaimers. So "as is" is in theory this legally magical phrase that can have the effect of disclaiming implied warranties, and this is associated with UCC Article 2 (which concerns sales of goods) where it is somewhat confusingly presented. I might ultimately agree with the view that the "as is" variant of the GNU source file disclaimer can be subsumed into the SPDX license identifier notice. But I don't think the issue is as simple as you may be assuming. This is a little like my concern about getting rid of explicit disclaimers of the implied warranties of title and non-infringement, although less significant. The person (or some original person) who decided to use the "as is" variant probably did so because they thought there was something deficient about the absence of "as is" in the traditional license notice, despite their (presumed) knowledge that there was a copy of GPLv2 that the recipient would also be getting that they could look at and have notice of. We should not forget that this is a GPL compliance issue, because GPLv2 says you have to "keep intact all the notices that refer . . . to the absence of any warranty". You are saying that because GPLv2 itself has the "as is" language, you can delete the "as is" language in this notice without effectively violating that clause of GPLv2, though literally of course you *are* violating it. I am just saying that I'm not sure yet whether I agree with that interpretation. I guess this also raises the question why I am not really bothered by getting rid of the traditional GNU license notice warranty disclaimer language. I don't have a super good answer for that, other than that the language is just boilerplate recommended by the GPL text itself and has been prevalent for a really long time. Anytime some contributor just parrotted the GNU boilerplate, it can be seen as relatively meaningless. But when a contributor deliberately departed from the widely-used boilerplate in ways that arguably were motivated by legal concerns, I am more troubled by the idea that the warranty disclaimer language can be deleted without the permission of the copyright holder who originally included that modified warranty disclaimer language. Richard ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-12 4:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-06-05 14:10 [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Thomas Gleixner 2019-06-05 14:10 ` [ASIS-5 patch 1/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 298 Thomas Gleixner 2019-06-05 17:05 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 2019-06-05 14:10 ` [ASIS-5 patch 2/2] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 302 Thomas Gleixner 2019-06-05 17:06 ` Enrico Weigelt, metux IT consult 2019-06-08 19:44 ` Allison Randal 2019-06-08 19:42 ` [ASIS-5 patch 0/2] Deep review of 'AS IS' disclaimers - part 5 Allison Randal 2019-06-12 4:58 ` Richard Fontana
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).