Re: [PATCH] crypto: frcypt Fix checkpatch warnings

* Re: [PATCH] crypto: frcypt Fix checkpatch warnings
       [not found] <20230606111042.96855-1-franziska.naepelt@gmail.com>
@ 2023-06-06 11:36 ` Bagas Sanjaya
  0 siblings, 0 replies; only message in thread
From: Bagas Sanjaya @ 2023-06-06 11:36 UTC (permalink / raw)
  To: Franziska Naepelt, linux-crypto
  Cc: herbert, davem, linux-kernel, Franziska Naepelt,
	Linux SPDX Licenses, Linux Kernel Janitors, David Howells

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

[Also Cc: linux-spdx list and original author mentioned in the license
boilerplate]

On Tue, Jun 06, 2023 at 01:10:42PM +0200, Franziska Naepelt wrote:
> The following checkpatch warnings have been fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - WARNING: Block comments use a trailing */ on a separate line

Two different logical changes in a patch - please break them into a
2-patch series, with each patch do one job. And please write the patch
description in imperative mood instead (e.g. "Do foo").

> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* FCrypt encryption algorithm
>   *
>   * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved.

NAK!

There is also BSD 3-clause boilerplate (from original code that fcrypt.c
is based on). Thus, the proper SPDX tag should have been:

```
// SPDX-License-Identifier: GPL-2.0-or-later AND BSD-3-Clause
```

And please also delete the boilerplate.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] only message in thread