From: Thomas Gleixner <tglx@linutronix.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-spdx@vger.kernel.org
Subject: Re: [patch 0/4] SPDX: First batch of patches
Date: Wed, 8 May 2019 08:25:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1905080818130.1796@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190507185816.GC17205@kroah.com>
Greg,
On Tue, 7 May 2019, Greg KH wrote:
>
> Anyway, glad to help out if you want me to.
Running the scripts is one thing. The more important thing is to figure out
how we are going to review these patches and agree that the conclusion is
correct. Ideally we have lots of Reviewed-by's on each of them.
Yes, it's 500+ and some of them are really large, but the point is that at
least in my opinion it's enough to carefully review the 'normalized'
patterns which are in the change log.
I have some postprocessing checks (not yet in utils) which verify that
author/copyright notices which are in the middle of the removed crap are
preserved.
The other issue which I worked on yesterday night (krobot finding a few
corner cases where the patcher did not handle some odd comment formatting
correctly) should be gone. I just started a new full run to verify that.
Apropos changelog. You said they need some care. If you check out the utils
repo, there are templates in the step2/3 directories and the subdirectories
of step1. If you could work on them that would be appreciated.
Thanks,
tglx
next prev parent reply other threads:[~2019-05-08 6:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 12:19 [patch 0/4] SPDX: First batch of patches Thomas Gleixner
2019-05-07 12:19 ` [patch 2/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2 Thomas Gleixner
2019-05-07 12:19 ` [patch 3/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 3 Thomas Gleixner
2019-05-07 12:19 ` [patch 4/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 4 Thomas Gleixner
2019-05-07 13:59 ` [patch 0/4] SPDX: First batch of patches Thomas Gleixner
2019-05-07 14:03 ` [patch 1/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1 Thomas Gleixner
2019-05-07 14:17 ` [patch 0/4] SPDX: First batch of patches Greg KH
2019-05-07 14:19 ` Thomas Gleixner
2019-05-07 18:14 ` Greg KH
2019-05-07 18:43 ` Thomas Gleixner
2019-05-07 18:58 ` Greg KH
2019-05-08 6:25 ` Thomas Gleixner [this message]
2019-05-08 6:46 ` Greg KH
2019-05-08 9:26 ` Thomas Gleixner
2019-05-08 9:51 ` Greg KH
2019-05-08 10:09 ` Greg KH
2019-05-08 20:40 ` Thomas Gleixner
2019-05-08 17:29 ` Allison Randal
2019-05-08 20:23 ` Thomas Gleixner
2019-05-08 21:25 ` Allison Randal
2019-05-08 21:29 ` Thomas Gleixner
2019-05-08 21:33 ` Allison Randal
2019-05-08 21:36 ` J Lovejoy
2019-05-08 21:58 ` Thomas Gleixner
2019-05-09 4:04 ` J Lovejoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1905080818130.1796@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-spdx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).