From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-spdx@vger.kernel.org
Subject: Re: [patch 0/4] SPDX: First batch of patches
Date: Tue, 7 May 2019 20:58:17 +0200 [thread overview]
Message-ID: <20190507185816.GC17205@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1905072041170.1796@nanos.tec.linutronix.de>
On Tue, May 07, 2019 at 08:43:44PM +0200, Thomas Gleixner wrote:
> On Tue, 7 May 2019, Greg KH wrote:
> > On Tue, May 07, 2019 at 04:19:35PM +0200, Thomas Gleixner wrote:
> > > On Tue, 7 May 2019, Greg KH wrote:
> > > > On Tue, May 07, 2019 at 02:19:52PM +0200, Thomas Gleixner wrote:
> > > > > Hi!
> > > > >
> > > > > As promised here are the first 4 automatically generated patches. Each
> > > > > patch handles exactly one match pattern (rule).
> > > > >
> > > > > While reviewing the patch (actual code change) might be massively time
> > > > > consuming, the quick and important part is to look at the patterns and
> > > > > verify whether the license conclusion is correct. The tooling which
> > > > > replaces exactly those patterns is pretty solid by now. But if you really
> > > > > insists on looking at each individual file change, you're welcome. :)
> > > > >
> > > > > Note that some of the patterns contain obscure things like:
> > > > >
> > > > > [no]_[pad]_[ctrl]
> > > > >
> > > > > in the middle. This one is a clear copy and paste artifact which happens to
> > > > > be in arch/arm/mach-imx/iomux-mx35.h:
> > > > >
> > > > > * of the License, or (at your option, NO_PAD_CTRL) any later version.
> > > > >
> > > > > Oh well.....
> > > >
> > > > What's the diffstat of all 4 of these patches? How many files are you
> > > > fixing up here?
> > >
> > > Oops. Forgot to add that.
> > >
> > > 305 files changed, 311 insertions(+), 2789 deletions(-)
> >
> > Nice, but I would have expected more files to be touched here :)
>
> It's 4 out of 514 patches on the step2 branch.
>
> step1-3 result with all patches applied in:
>
> 24524 files changed, 24721 insertions(+), 184320 deletions(-)
That's better :)
> > Anyway, these all look good to me. I'm guessing the subject lines will
> > be tweaked. If there's anything I can do to run the script and send out
> > patches, please let me know.
>
> You have a big enough machine?
I think I do:
$ free -h
total used free shared buff/cache available
Mem: 118Gi 994Mi 113Gi 1.0Mi 3.3Gi 115Gi
Swap: 4.0Gi 0B 4.0Gi
It's what I do my stable kernel build testing on :)
Anyway, glad to help out if you want me to.
greg k-h
next prev parent reply other threads:[~2019-05-07 18:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 12:19 [patch 0/4] SPDX: First batch of patches Thomas Gleixner
2019-05-07 12:19 ` [patch 2/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2 Thomas Gleixner
2019-05-07 12:19 ` [patch 3/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 3 Thomas Gleixner
2019-05-07 12:19 ` [patch 4/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 4 Thomas Gleixner
2019-05-07 13:59 ` [patch 0/4] SPDX: First batch of patches Thomas Gleixner
2019-05-07 14:03 ` [patch 1/4] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1 Thomas Gleixner
2019-05-07 14:17 ` [patch 0/4] SPDX: First batch of patches Greg KH
2019-05-07 14:19 ` Thomas Gleixner
2019-05-07 18:14 ` Greg KH
2019-05-07 18:43 ` Thomas Gleixner
2019-05-07 18:58 ` Greg KH [this message]
2019-05-08 6:25 ` Thomas Gleixner
2019-05-08 6:46 ` Greg KH
2019-05-08 9:26 ` Thomas Gleixner
2019-05-08 9:51 ` Greg KH
2019-05-08 10:09 ` Greg KH
2019-05-08 20:40 ` Thomas Gleixner
2019-05-08 17:29 ` Allison Randal
2019-05-08 20:23 ` Thomas Gleixner
2019-05-08 21:25 ` Allison Randal
2019-05-08 21:29 ` Thomas Gleixner
2019-05-08 21:33 ` Allison Randal
2019-05-08 21:36 ` J Lovejoy
2019-05-08 21:58 ` Thomas Gleixner
2019-05-09 4:04 ` J Lovejoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507185816.GC17205@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-spdx@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).