* Re: [PATCH v6 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking
[not found] <20231116024338.337304-1-acelan.kao@canonical.com>
@ 2023-11-17 9:32 ` Tudor Ambarus
0 siblings, 0 replies; only message in thread
From: Tudor Ambarus @ 2023-11-17 9:32 UTC (permalink / raw)
To: AceLan Kao, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Mika Westerberg,
Dhruva Gole, linux-mtd, Mark Brown, Kamal Dasu,
Jonathan Neuschäfer, Mario Kicherer, Chuanhong Guo,
linux-kernel, linux-spi
I included linux-spi@vger.kernel.org. Please do the same if you're going
to send a new version.
On 11/16/23 02:43, AceLan Kao wrote:
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -323,7 +323,7 @@ int spi_mem_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> return ret;
>
> if (!spi_mem_internal_supports_op(mem, op))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
this will break user-space if someone uses the return code of
unsupported operations, but I'm not against taking the risk and changing
the return code, as I doubt it's used. Anyway, if we're taking this
path, please specify the risk in the commit message and why we're taking
this risk.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-17 9:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20231116024338.337304-1-acelan.kao@canonical.com>
2023-11-17 9:32 ` [PATCH v6 1/2] spi: Replace -ENOTSUPP with -EOPNOTSUPP in op checking Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).