pxa2xx_spi: PXA27x SSP1 doesn't work with DMA

pxa2xx_spi: PXA27x SSP1 doesn't work with DMA

[Stephen Street]

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]


This is fine.  When I get more time, I will re-think handling of PXA2xx
version differences.

Stephen


[-- Attachment #2: Type: text/x-patch, Size: 2007 bytes --]

pxa2xx_spi: add SSP types for the PXA27x

The PXA27x's SSP1 is not like the PXA25x's SSP, so add some more PXA27x
specific types so SSP1 works with DMA.

Signed-off-by: David Vrabel <david.vrabel-kQvG35nSl+M@public.gmane.org>
Signed-off-by: Stephen Street <stephen-nl6u4wocdmy51APUEpUfAkEOCMrvLtNR@public.gmane.org>

diff -u linux-2.6.16.28/drivers/spi/pxa2xx_spi.c linux-2.6.16.28/drivers/spi/pxa2xx_spi.c
--- linux-2.6.16.28/drivers/spi/pxa2xx_spi.c
+++ linux-2.6.16.28/drivers/spi/pxa2xx_spi.c
@@ -1260,18 +1260,20 @@
 
 		switch (platform_info->ssp_type) {
 			case PXA25x_SSP:
+			case PXA27x_SSP1:
 				DRCMRRXSSDR = DRCMR_MAPVLD
 						| drv_data->rx_channel;
 				DRCMRTXSSDR = DRCMR_MAPVLD
 						| drv_data->tx_channel;
 				break;
 			case PXA25x_NSSP:
+			case PXA27x_SSP2:
 				DRCMRRXSS2DR = DRCMR_MAPVLD
 						| drv_data->rx_channel;
 				DRCMRTXSS2DR = DRCMR_MAPVLD
 						| drv_data->tx_channel;
 				break;
-			case PXA27x_SSP:
+			case PXA27x_SSP3:
 				DRCMRRXSS3DR = DRCMR_MAPVLD
 						| drv_data->rx_channel;
 				DRCMRTXSS3DR = DRCMR_MAPVLD
@@ -1359,14 +1361,16 @@
 	if (drv_data->master_info->enable_dma) {
 		switch (drv_data->ssp_type) {
 			case PXA25x_SSP:
+			case PXA27x_SSP1:
 				DRCMRRXSSDR = 0;
 				DRCMRTXSSDR = 0;
 				break;
 			case PXA25x_NSSP:
+			case PXA27x_SSP2:
 				DRCMRRXSS2DR = 0;
 				DRCMRTXSS2DR = 0;
 				break;
-			case PXA27x_SSP:
+			case PXA27x_SSP3:
 				DRCMRRXSS3DR = 0;
 				DRCMRTXSS3DR = 0;
 				break;
diff -u linux-2.6.16.28/include/asm-arm/arch-pxa/pxa2xx_spi.h linux-2.6.16.28/include/asm-arm/arch-pxa/pxa2xx_spi.h
--- linux-2.6.16.28/include/asm-arm/arch-pxa/pxa2xx_spi.h
+++ linux-2.6.16.28/include/asm-arm/arch-pxa/pxa2xx_spi.h
@@ -25,7 +25,10 @@
 	SSP_UNDEFINED = 0,
 	PXA25x_SSP,  /* pxa 210, 250, 255, 26x */
 	PXA25x_NSSP, /* pxa 255, 26x (including ASSP) */
-	PXA27x_SSP,
+	PXA27x_SSP1,
+	PXA27x_SSP2,
+	PXA27x_SSP3,
+	PXA27x_SSP = PXA27x_SSP3, /* for compatibility */
 };
 
 /* device.platform_data for SSP controller devices */

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 210 bytes --]

_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: pxa2xx_spi: PXA27x SSP1 doesn't work with DMA

[David Brownell]

On Wednesday 11 July 2007, Stephen Street wrote:
> This is fine.  When I get more time, I will re-think handling of PXA2xx
> version differences.

Except it's against 2.6.16 and doesn't apply against 2.6.22 ... which
doesn't have those switch statements!  

David, could you provide a fix for current kernels?

- Dave


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: pxa2xx_spi: PXA27x SSP1 doesn't work with DMA

[David Vrabel]

David Brownell wrote:
> On Wednesday 11 July 2007, Stephen Street wrote:
>> This is fine.  When I get more time, I will re-think handling of PXA2xx
>> version differences.
> 
> Except it's against 2.6.16 and doesn't apply against 2.6.22 ... which
> doesn't have those switch statements!

Oops.  I checked to see if this driver had changed but thought it hadn't...

> David, could you provide a fix for current kernels?

I could, but I couldn't test it :(

David


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

Re: pxa2xx_spi: PXA27x SSP1 doesn't work with DMA

[Stephen Street]

On Wed, 2007-07-11 at 10:08 -0700, David Brownell wrote:
> On Wednesday 11 July 2007, Stephen Street wrote:
> > This is fine.  When I get more time, I will re-think handling of PXA2xx
> > version differences.
> 
> Except it's against 2.6.16 and doesn't apply against 2.6.22 ... which
> doesn't have those switch statements!  
Yikes,  I did not look at this closely enough... I look at this also.
Give me a couple of days.

Stephen



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/