[PATCH V2] spi: Enable SPI driver for S5P6440 and S5P6450

[PATCH V2] spi: Enable SPI driver for S5P6440 and S5P6450

[Kukjin Kim]

From: Abhilash Kesavan <a.kesavan@samsung.com>

This patch enables the existing S3C64XX series SPI driver for S5P64X0
and removed dependency on EXPERIMENTAL because we don't need it now.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Cc: Jassi Brar <jassi.brar@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
Changes since v1:
- Removed dependency on EXPERIMENTAL

Hi David and Grant,

I missed that send to you when I have got this via Linux Samsung SoC mailing list.
Hmm...I know, it's 38 merge winodw...so I'm not sure can be handled now.

Anyway if any problems, please let me know.

Thanks and Happy New year :)

Best regards,
Kgene.

 drivers/spi/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1906840..37aec5e 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -310,8 +310,8 @@ config SPI_S3C24XX_GPIO
 
 config SPI_S3C64XX
 	tristate "Samsung S3C64XX series type SPI"
-	depends on ARCH_S3C64XX && EXPERIMENTAL
-	select S3C64XX_DMA
+	depends on (ARCH_S3C64XX || ARCH_S5P64X0)
+	select S3C64XX_DMA if !ARCH_S5P64X0
 	help
 	  SPI driver for Samsung S3C64XX and newer SoCs.
 
-- 
1.6.2.5

Re: [PATCH V2] spi: Enable SPI driver for S5P6440 and S5P6450

[Jassi Brar]

On Wed, Jan 12, 2011 at 2:20 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> From: Abhilash Kesavan <a.kesavan@samsung.com>
>
> This patch enables the existing S3C64XX series SPI driver for S5P64X0
> and removed dependency on EXPERIMENTAL because we don't need it now.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> Cc: Jassi Brar <jassi.brar@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> Changes since v1:
> - Removed dependency on EXPERIMENTAL
>
> Hi David and Grant,
>
> I missed that send to you when I have got this via Linux Samsung SoC mailing list.
> Hmm...I know, it's 38 merge winodw...so I'm not sure can be handled now.
>
> Anyway if any problems, please let me know.
>
> Thanks and Happy New year :)
>
> Best regards,
> Kgene.
>
>  drivers/spi/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 1906840..37aec5e 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -310,8 +310,8 @@ config SPI_S3C24XX_GPIO
>
>  config SPI_S3C64XX
>        tristate "Samsung S3C64XX series type SPI"
> -       depends on ARCH_S3C64XX && EXPERIMENTAL
> -       select S3C64XX_DMA
> +       depends on (ARCH_S3C64XX || ARCH_S5P64X0)
> +       select S3C64XX_DMA if !ARCH_S5P64X0
>        help
>          SPI driver for Samsung S3C64XX and newer SoCs.

Since SoCs newer than S3C64xx use different DMAC, it would be
more efficient to do
     select S3C64XX_DMA if ARCH_S3C64XX
otherwise we would have to add lots of !ARCH_S5Pxxx as more SoCs
are enabled.

RE: [PATCH V2] spi: Enable SPI driver for S5P6440 and S5P6450

[Kukjin Kim]

Jassi Brar wrote:
> 
> On Wed, Jan 12, 2011 at 2:20 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > From: Abhilash Kesavan <a.kesavan@samsung.com>
> >
> > This patch enables the existing S3C64XX series SPI driver for S5P64X0
> > and removed dependency on EXPERIMENTAL because we don't need it now.
> >
> > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> > Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> > Cc: Jassi Brar <jassi.brar@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > Changes since v1:
> > - Removed dependency on EXPERIMENTAL
> >
> > Hi David and Grant,
> >
> > I missed that send to you when I have got this via Linux Samsung SoC
> mailing list.
> > Hmm...I know, it's 38 merge winodw...so I'm not sure can be handled now.
> >
> > Anyway if any problems, please let me know.
> >
> > Thanks and Happy New year :)
> >
> > Best regards,
> > Kgene.
> >
> >  drivers/spi/Kconfig |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index 1906840..37aec5e 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -310,8 +310,8 @@ config SPI_S3C24XX_GPIO
> >
> >  config SPI_S3C64XX
> >        tristate "Samsung S3C64XX series type SPI"
> > -       depends on ARCH_S3C64XX && EXPERIMENTAL
> > -       select S3C64XX_DMA
> > +       depends on (ARCH_S3C64XX || ARCH_S5P64X0)
> > +       select S3C64XX_DMA if !ARCH_S5P64X0
> >        help
> >          SPI driver for Samsung S3C64XX and newer SoCs.
> 
> Since SoCs newer than S3C64xx use different DMAC, it would be
> more efficient to do
>      select S3C64XX_DMA if ARCH_S3C64XX
> otherwise we would have to add lots of !ARCH_S5Pxxx as more SoCs
> are enabled.

Yes, you're right.
Will fix it soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.