From: Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
Subject: [PATCH spi 7/7] spi-ep93xx: remove duplicate check on resource
Date: Tue, 21 Oct 2014 15:35:50 +0530 [thread overview]
Message-ID: <1413885950-24208-7-git-send-email-varkab@cdac.in> (raw)
In-Reply-To: <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-ep93xx.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index d7bac60..9a4c435 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -1077,20 +1077,14 @@ static int ep93xx_spi_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "unable to get iomem resource\n");
- error = -ENODEV;
- goto fail_put_clock;
- }
-
- espi->sspdr_phys = res->start + SSPDR;
-
espi->regs_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(espi->regs_base)) {
error = PTR_ERR(espi->regs_base);
goto fail_put_clock;
}
+ espi->sspdr_phys = res->start + SSPDR;
+
error = devm_request_irq(&pdev->dev, irq, ep93xx_spi_interrupt,
0, "ep93xx-spi", espi);
if (error) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-21 10:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 10:05 [PATCH spi 1/7] spi-tegra20-slink: remove duplicate check on resource Varka Bhadram
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
2014-10-21 10:05 ` [PATCH spi 2/7] spi-tegra20-sflash: " Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 3/7] spi-sirf: " Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 4/7] spi-s3c64xx: " Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 5/7] spi-omap2-mcspi: " Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 6/7] spi-mxs: " Varka Bhadram
2014-10-21 10:05 ` Varka Bhadram [this message]
2014-10-28 4:59 ` [PATCH spi 1/7] spi-tegra20-slink: " Varka Bhadram
[not found] ` <544F22C8.8040106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-25 14:08 ` Mark Brown
[not found] ` <20150525140806.GX21391-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-25 14:43 ` Varka Bhadram
[not found] ` <55633524.2060704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-25 17:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413885950-24208-7-git-send-email-varkab@cdac.in \
--to=varkabhadram-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=varkab-If5XQcfNmg0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).