* [PATCH spi 2/7] spi-tegra20-sflash: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 3/7] spi-sirf: " Varka Bhadram
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-tegra20-sflash.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 3d6a12b..3748445 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -511,11 +511,6 @@ static int tegra_sflash_probe(struct platform_device *pdev)
spin_lock_init(&tsd->lock);
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!r) {
- dev_err(&pdev->dev, "No IO memory resource\n");
- ret = -ENODEV;
- goto exit_free_master;
- }
tsd->base = devm_ioremap_resource(&pdev->dev, r);
if (IS_ERR(tsd->base)) {
ret = PTR_ERR(tsd->base);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH spi 3/7] spi-sirf: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
2014-10-21 10:05 ` [PATCH spi 2/7] spi-tegra20-sflash: " Varka Bhadram
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 4/7] spi-s3c64xx: " Varka Bhadram
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-sirf.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/spi/spi-sirf.c b/drivers/spi/spi-sirf.c
index f59d417..ee85da2 100644
--- a/drivers/spi/spi-sirf.c
+++ b/drivers/spi/spi-sirf.c
@@ -502,12 +502,6 @@ static int spi_sirfsoc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, master);
sspi = spi_master_get_devdata(master);
- mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!mem_res) {
- dev_err(&pdev->dev, "Unable to get IO resource\n");
- ret = -ENODEV;
- goto free_master;
- }
master->num_chipselect = num_cs;
for (i = 0; i < master->num_chipselect; i++) {
@@ -534,6 +528,7 @@ static int spi_sirfsoc_probe(struct platform_device *pdev)
}
}
+ mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sspi->base = devm_ioremap_resource(&pdev->dev, mem_res);
if (IS_ERR(sspi->base)) {
ret = PTR_ERR(sspi->base);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH spi 4/7] spi-s3c64xx: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
2014-10-21 10:05 ` [PATCH spi 2/7] spi-tegra20-sflash: " Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 3/7] spi-sirf: " Varka Bhadram
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 5/7] spi-omap2-mcspi: " Varka Bhadram
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-s3c64xx.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 4188b2f..5a0ce49 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1176,12 +1176,6 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
return -ENODEV;
}
- mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (mem_res == NULL) {
- dev_err(&pdev->dev, "Unable to get SPI MEM resource\n");
- return -ENXIO;
- }
-
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_warn(&pdev->dev, "Failed to get IRQ: %d\n", irq);
@@ -1250,6 +1244,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
/* the spi->mode bits understood by this driver: */
master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH;
+ mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sdd->regs = devm_ioremap_resource(&pdev->dev, mem_res);
if (IS_ERR(sdd->regs)) {
ret = PTR_ERR(sdd->regs);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH spi 5/7] spi-omap2-mcspi: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
` (2 preceding siblings ...)
2014-10-21 10:05 ` [PATCH spi 4/7] spi-s3c64xx: " Varka Bhadram
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 6/7] spi-mxs: " Varka Bhadram
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-omap2-mcspi.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 893c3d7..305c649 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1213,8 +1213,9 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
regs_offset = pdata->regs_offset;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (r == NULL) {
- status = -ENODEV;
+ mcspi->base = devm_ioremap_resource(&pdev->dev, r);
+ if (IS_ERR(mcspi->base)) {
+ status = PTR_ERR(mcspi->base);
goto free_master;
}
@@ -1222,12 +1223,6 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
r->end += regs_offset;
mcspi->phys = r->start;
- mcspi->base = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(mcspi->base)) {
- status = PTR_ERR(mcspi->base);
- goto free_master;
- }
-
mcspi->dev = &pdev->dev;
INIT_LIST_HEAD(&mcspi->ctx.cs);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH spi 6/7] spi-mxs: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
` (3 preceding siblings ...)
2014-10-21 10:05 ` [PATCH spi 5/7] spi-omap2-mcspi: " Varka Bhadram
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-21 10:05 ` [PATCH spi 7/7] spi-ep93xx: " Varka Bhadram
2014-10-28 4:59 ` [PATCH spi 1/7] spi-tegra20-slink: " Varka Bhadram
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-mxs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 22a0af0..778cb98 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -536,15 +536,15 @@ static int mxs_spi_probe(struct platform_device *pdev)
const int clk_freq_default = 160000000;
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- irq_err = platform_get_irq(pdev, 0);
- irq_dma = platform_get_irq(pdev, 1);
- if (!iores || irq_err < 0 || irq_dma < 0)
- return -EINVAL;
-
base = devm_ioremap_resource(&pdev->dev, iores);
if (IS_ERR(base))
return PTR_ERR(base);
+ irq_err = platform_get_irq(pdev, 0);
+ irq_dma = platform_get_irq(pdev, 1);
+ if (irq_err < 0 || irq_dma < 0)
+ return -EINVAL;
+
pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
if (IS_ERR(pinctrl))
return PTR_ERR(pinctrl);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH spi 7/7] spi-ep93xx: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
` (4 preceding siblings ...)
2014-10-21 10:05 ` [PATCH spi 6/7] spi-mxs: " Varka Bhadram
@ 2014-10-21 10:05 ` Varka Bhadram
2014-10-28 4:59 ` [PATCH spi 1/7] spi-tegra20-slink: " Varka Bhadram
6 siblings, 0 replies; 11+ messages in thread
From: Varka Bhadram @ 2014-10-21 10:05 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: Varka Bhadram
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
---
drivers/spi/spi-ep93xx.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index d7bac60..9a4c435 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -1077,20 +1077,14 @@ static int ep93xx_spi_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "unable to get iomem resource\n");
- error = -ENODEV;
- goto fail_put_clock;
- }
-
- espi->sspdr_phys = res->start + SSPDR;
-
espi->regs_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(espi->regs_base)) {
error = PTR_ERR(espi->regs_base);
goto fail_put_clock;
}
+ espi->sspdr_phys = res->start + SSPDR;
+
error = devm_request_irq(&pdev->dev, irq, ep93xx_spi_interrupt,
0, "ep93xx-spi", espi);
if (error) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH spi 1/7] spi-tegra20-slink: remove duplicate check on resource
[not found] ` <1413885950-24208-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
` (5 preceding siblings ...)
2014-10-21 10:05 ` [PATCH spi 7/7] spi-ep93xx: " Varka Bhadram
@ 2014-10-28 4:59 ` Varka Bhadram
[not found] ` <544F22C8.8040106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
6 siblings, 1 reply; 11+ messages in thread
From: Varka Bhadram @ 2014-10-28 4:59 UTC (permalink / raw)
To: linux-spi-u79uwXL29TY76Z2rM5mHXA; +Cc: varkab-If5XQcfNmg0
On 10/21/2014 03:35 PM, Varka Bhadram wrote:
> Sanity check on resource happening with devm_ioremap_resource().
>
> Signed-off-by: Varka Bhadram <varkab-If5XQcfNmg0@public.gmane.org>
> ---
> drivers/spi/spi-tegra20-slink.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index a829563..59a85cc 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1154,18 +1154,14 @@ static int tegra_slink_probe(struct platform_device *pdev)
> spin_lock_init(&tspi->lock);
>
> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!r) {
> - dev_err(&pdev->dev, "No IO memory resource\n");
> - ret = -ENODEV;
> - goto exit_free_master;
> - }
> - tspi->phys = r->start;
> tspi->base = devm_ioremap_resource(&pdev->dev, r);
> if (IS_ERR(tspi->base)) {
> ret = PTR_ERR(tspi->base);
> goto exit_free_master;
> }
>
> + tspi->phys = r->start;
> +
> spi_irq = platform_get_irq(pdev, 0);
> tspi->irq = spi_irq;
> ret = request_threaded_irq(tspi->irq, tegra_slink_isr,
Ping...
--
Regards,
Varka Bhadram.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread