From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org
Subject: [PATCH 3/4] spi: xlp: Fix module autoload for OF registration
Date: Wed, 23 Nov 2016 13:37:10 -0300 [thread overview]
Message-ID: <1479919031-5112-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1479919031-5112-1-git-send-email-javier@osg.samsung.com>
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
After this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
alias: of:N*T*Cnetlogic,xlp832-spiC*
alias: of:N*T*Cnetlogic,xlp832-spi
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/spi/spi-xlp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c
index 4071a729eb2f..bea7a93a6046 100644
--- a/drivers/spi/spi-xlp.c
+++ b/drivers/spi/spi-xlp.c
@@ -451,6 +451,7 @@ static const struct of_device_id xlp_spi_dt_id[] = {
{ .compatible = "netlogic,xlp832-spi" },
{ },
};
+MODULE_DEVICE_TABLE(of, xlp_spi_dt_id);
static struct platform_driver xlp_spi_driver = {
.probe = xlp_spi_probe,
--
2.7.4
next prev parent reply other threads:[~2016-11-23 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 16:37 [PATCH 0/4] spi: Fix module autoload for different platform drivers Javier Martinez Canillas
[not found] ` <1479919031-5112-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-23 16:37 ` [PATCH 1/4] spi: spi-axi: Fix module autoload Javier Martinez Canillas
[not found] ` <1479919031-5112-2-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-25 13:10 ` Applied "spi: spi-axi: Fix module autoload" to the spi tree Mark Brown
2016-11-23 16:37 ` [PATCH 2/4] spi: jcore: Fix module autoload for OF registration Javier Martinez Canillas
2016-11-25 13:10 ` Applied "spi: jcore: Fix module autoload for OF registration" to the spi tree Mark Brown
2016-11-23 16:37 ` Javier Martinez Canillas [this message]
2016-11-25 13:10 ` Applied "spi: xlp: " Mark Brown
2016-11-23 16:37 ` [PATCH 4/4] spi: ath79: Fix module autoload for OF registration Javier Martinez Canillas
[not found] ` <1479919031-5112-5-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-25 13:10 ` Applied "spi: ath79: Fix module autoload for OF registration" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479919031-5112-4-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).