linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Add QSPI flash support to iwg23s
@ 2018-11-08 17:04 Fabrizio Castro
  2018-11-08 17:04 ` [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d Fabrizio Castro
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Fabrizio Castro @ 2018-11-08 17:04 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, Mark Rutland, Marek Vasut,
	David Woodhouse, Brian Norris, Boris Brezillon,
	Geert Uytterhoeven, Simon Horman, Richard Weinberger
  Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
	linux-spi, linux-renesas-soc, linux-mtd, Biju Das

Dear All,

this series includes all that is necessary to add QSPI flash
support to the iwg23s board powered by the RZ/G1C SoC (a.k.a.
r8a77470). The second version of this series is to address
a comment made by both Simon and Geert on one of the patches.

This series applies on top of renesas-devel-20181108v3-v4.20-rc1

Thanks,
Fab

Fabrizio Castro (3):
  mtd: spi-nor: Add support for is25lp016d
  ARM: dts: r8a77470: Add QSPI support
  ARM: dts: iwg23s-sbc: Add QSPI flash support

 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 26 +++++++++++++++++++++++++
 arch/arm/boot/dts/r8a77470.dtsi           | 32 +++++++++++++++++++++++++++++++
 drivers/mtd/spi-nor/spi-nor.c             |  2 ++
 3 files changed, 60 insertions(+)

-- 
2.7.4


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d
  2018-11-08 17:04 [PATCH v2 0/3] Add QSPI flash support to iwg23s Fabrizio Castro
@ 2018-11-08 17:04 ` Fabrizio Castro
  2018-12-08 12:30   ` [v2,1/3] " Boris Brezillon
  2018-11-08 17:04 ` [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support Fabrizio Castro
  2018-11-08 17:04 ` [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support Fabrizio Castro
  2 siblings, 1 reply; 9+ messages in thread
From: Fabrizio Castro @ 2018-11-08 17:04 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, Mark Rutland, Marek Vasut,
	David Woodhouse, Brian Norris, Boris Brezillon,
	Geert Uytterhoeven, Simon Horman, Richard Weinberger
  Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
	linux-spi, linux-renesas-soc, linux-mtd, Biju Das

The is25lp016d is found on the iwg23s from iWave, therefore
add driver support for it so that we can upstream board support.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
v1->v2:
* No change

 drivers/mtd/spi-nor/spi-nor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 9407ca5..85d869b 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1352,6 +1352,8 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "is25cd512",  INFO(0x7f9d20, 0, 32 * 1024,   2, SECT_4K) },
 	{ "is25lq040b", INFO(0x9d4013, 0, 64 * 1024,   8,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+	{ "is25lp016d", INFO(0x9d6015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "is25lp080d", INFO(0x9d6014, 0, 64 * 1024,  16,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "is25lp128",  INFO(0x9d6018, 0, 64 * 1024, 256,
-- 
2.7.4


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support
  2018-11-08 17:04 [PATCH v2 0/3] Add QSPI flash support to iwg23s Fabrizio Castro
  2018-11-08 17:04 ` [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d Fabrizio Castro
@ 2018-11-08 17:04 ` Fabrizio Castro
  2018-11-09 10:05   ` Simon Horman
  2018-11-08 17:04 ` [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support Fabrizio Castro
  2 siblings, 1 reply; 9+ messages in thread
From: Fabrizio Castro @ 2018-11-08 17:04 UTC (permalink / raw)
  To: Geert Uytterhoeven, Simon Horman
  Cc: Fabrizio Castro, Mark Rutland, Chris Paterson, Boris Brezillon,
	Richard Weinberger, Mark Brown, Magnus Damm, linux-spi,
	linux-renesas-soc, Marek Vasut, devicetree, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

Add QSPI[01] support to the RZ/G1C SoC specific device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
v1->v2:
* Removed aliases

 arch/arm/boot/dts/r8a77470.dtsi | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 5c0e48d..f4e232b 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -460,6 +460,38 @@
 			status = "disabled";
 		};
 
+		qspi0: spi@e6b10000 {
+			compatible = "renesas,qspi-r8a77470", "renesas,qspi";
+			reg = <0 0xe6b10000 0 0x2c>;
+			interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 918>;
+			dmas = <&dmac0 0x17>, <&dmac0 0x18>,
+			       <&dmac1 0x17>, <&dmac1 0x18>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			num-cs = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			resets = <&cpg 918>;
+			status = "disabled";
+		};
+
+		qspi1: spi@ee200000 {
+			compatible = "renesas,qspi-r8a77470", "renesas,qspi";
+			reg = <0 0xee200000 0 0x2c>;
+			interrupts = <GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 917>;
+			dmas = <&dmac0 0xd1>, <&dmac0 0xd2>,
+			       <&dmac1 0xd1>, <&dmac1 0xd2>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			num-cs = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			resets = <&cpg 917>;
+			status = "disabled";
+		};
+
 		scif0: serial@e6e60000 {
 			compatible = "renesas,scif-r8a77470",
 				     "renesas,rcar-gen2-scif", "renesas,scif";
-- 
2.7.4


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support
  2018-11-08 17:04 [PATCH v2 0/3] Add QSPI flash support to iwg23s Fabrizio Castro
  2018-11-08 17:04 ` [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d Fabrizio Castro
  2018-11-08 17:04 ` [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support Fabrizio Castro
@ 2018-11-08 17:04 ` Fabrizio Castro
  2018-11-09 10:06   ` Simon Horman
  2 siblings, 1 reply; 9+ messages in thread
From: Fabrizio Castro @ 2018-11-08 17:04 UTC (permalink / raw)
  To: Geert Uytterhoeven, Simon Horman
  Cc: Fabrizio Castro, Mark Rutland, Chris Paterson, Boris Brezillon,
	Richard Weinberger, Mark Brown, Magnus Damm, linux-spi,
	linux-renesas-soc, Marek Vasut, devicetree, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

This commit adds QSPI flash support to the iwg23s board specific
device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
v1->v2:
* No Change

 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 52f23b8..40b7f98 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -96,6 +96,11 @@
 		power-source = <1800>;
 	};
 
+	qspi0_pins: qspi0 {
+		groups = "qspi0_ctrl", "qspi0_data2";
+		function = "qspi0";
+	};
+
 	scif1_pins: scif1 {
 		groups = "scif1_data_b";
 		function = "scif1";
@@ -114,6 +119,27 @@
 	};
 };
 
+&qspi0 {
+	pinctrl-0 = <&qspi0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	/* WARNING - This device contains the bootloader. Handle with care. */
+	flash: flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "issi,is25lp016d", "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <133000000>;
+		spi-tx-bus-width = <1>;
+		spi-rx-bus-width = <1>;
+		m25p,fast-read;
+		spi-cpol;
+		spi-cpha;
+	};
+};
+
 &rwdt {
 	timeout-sec = <60>;
 	status = "okay";
-- 
2.7.4


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support
  2018-11-08 17:04 ` [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support Fabrizio Castro
@ 2018-11-09 10:05   ` Simon Horman
  2018-11-13 14:35     ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2018-11-09 10:05 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
	Boris Brezillon, Richard Weinberger, Mark Brown, Magnus Damm,
	linux-spi, linux-renesas-soc, Marek Vasut, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

On Thu, Nov 08, 2018 at 05:04:42PM +0000, Fabrizio Castro wrote:
> Add QSPI[01] support to the RZ/G1C SoC specific device tree.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support
  2018-11-08 17:04 ` [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support Fabrizio Castro
@ 2018-11-09 10:06   ` Simon Horman
  2018-11-13 14:35     ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2018-11-09 10:06 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
	Boris Brezillon, Richard Weinberger, Mark Brown, Magnus Damm,
	linux-spi, linux-renesas-soc, Marek Vasut, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

On Thu, Nov 08, 2018 at 05:04:43PM +0000, Fabrizio Castro wrote:
> This commit adds QSPI flash support to the iwg23s board specific
> device tree.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support
  2018-11-09 10:05   ` Simon Horman
@ 2018-11-13 14:35     ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2018-11-13 14:35 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
	Boris Brezillon, Richard Weinberger, Mark Brown, Magnus Damm,
	linux-spi, linux-renesas-soc, Marek Vasut, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

On Fri, Nov 09, 2018 at 11:05:56AM +0100, Simon Horman wrote:
> On Thu, Nov 08, 2018 at 05:04:42PM +0000, Fabrizio Castro wrote:
> > Add QSPI[01] support to the RZ/G1C SoC specific device tree.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

Thanks again,

applied for v4.21.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support
  2018-11-09 10:06   ` Simon Horman
@ 2018-11-13 14:35     ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2018-11-13 14:35 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
	Boris Brezillon, Richard Weinberger, Mark Brown, Magnus Damm,
	linux-spi, linux-renesas-soc, Marek Vasut, Rob Herring,
	linux-mtd, Brian Norris, David Woodhouse, Biju Das

On Fri, Nov 09, 2018 at 11:06:07AM +0100, Simon Horman wrote:
> On Thu, Nov 08, 2018 at 05:04:43PM +0000, Fabrizio Castro wrote:
> > This commit adds QSPI flash support to the iwg23s board specific
> > device tree.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

Thanks again,

applied for v4.21.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [v2,1/3] mtd: spi-nor: Add support for is25lp016d
  2018-11-08 17:04 ` [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d Fabrizio Castro
@ 2018-12-08 12:30   ` Boris Brezillon
  0 siblings, 0 replies; 9+ messages in thread
From: Boris Brezillon @ 2018-12-08 12:30 UTC (permalink / raw)
  To: Fabrizio Castro, Mark Brown, Rob Herring, Mark Rutland,
	Marek Vasut, David Woodhouse, Brian Norris, Boris Brezillon,
	Geert Uytterhoeven, Simon Horman, Richard Weinberger
  Cc: devicetree, Chris Paterson, Magnus Damm, linux-spi,
	linux-renesas-soc, linux-mtd, Biju Das

On Thu, 2018-11-08 at 17:04:41 UTC, Fabrizio Castro wrote:
> The is25lp016d is found on the iwg23s from iWave, therefore
> add driver support for it so that we can upstream board support.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-12-08 12:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 17:04 [PATCH v2 0/3] Add QSPI flash support to iwg23s Fabrizio Castro
2018-11-08 17:04 ` [PATCH v2 1/3] mtd: spi-nor: Add support for is25lp016d Fabrizio Castro
2018-12-08 12:30   ` [v2,1/3] " Boris Brezillon
2018-11-08 17:04 ` [PATCH v2 2/3] ARM: dts: r8a77470: Add QSPI support Fabrizio Castro
2018-11-09 10:05   ` Simon Horman
2018-11-13 14:35     ` Simon Horman
2018-11-08 17:04 ` [PATCH v2 3/3] ARM: dts: iwg23s-sbc: Add QSPI flash support Fabrizio Castro
2018-11-09 10:06   ` Simon Horman
2018-11-13 14:35     ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).