Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC
       [not found] ` <20200721122436.31544-2-leilk.liu@mediatek.com>
@ 2020-07-21 22:44   ` Matthias Brugger
       [not found]     ` <1595407127.31408.3.camel@mhfsdcap03>
  0 siblings, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2020-07-21 22:44 UTC (permalink / raw)
  To: Leilk Liu, Mark Brown
  Cc: Mark Rutland, Sascha Hauer, devicetree, linux-kernel,
	linux-arm-kernel, linux-spi, linux-mediatek



On 21/07/2020 14:24, Leilk Liu wrote:
> From: "leilk.liu" <leilk.liu@mediatek.com>
> 
> This patch add spi support for mt8192 IC.
> 
> Signed-off-by: leilk.liu <leilk.liu@mediatek.com>
> ---
>   drivers/spi/spi-mt65xx.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> index 6783e12c40c2..3d0d69fe0c69 100644
> --- a/drivers/spi/spi-mt65xx.c
> +++ b/drivers/spi/spi-mt65xx.c
> @@ -170,6 +170,9 @@ static const struct of_device_id mtk_spi_of_match[] = {
>   	{ .compatible = "mediatek,mt8183-spi",
>   		.data = (void *)&mt8183_compat,
>   	},
> +	{ .compatible = "mediatek,mt8192-spi",
> +		.data = (void *)&mt6765_compat,
> +	},

That's not needed. We will use the fallback compatible which is 
"mediatek,mt6765-spi" which will take the correct DT data. If in the future we 
realize that mt8192 has a difference in the HW we can add the compatible. 
Otherwise with the binding description we should be fine

>   	{}
>   };
>   MODULE_DEVICE_TABLE(of, mtk_spi_of_match);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC
       [not found]     ` <1595407127.31408.3.camel@mhfsdcap03>
@ 2020-07-22 10:38       ` Matthias Brugger
  0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-07-22 10:38 UTC (permalink / raw)
  To: lei liu
  Cc: Mark Brown, Mark Rutland, Sascha Hauer, devicetree, linux-kernel,
	linux-arm-kernel, linux-spi, linux-mediatek



On 22/07/2020 10:38, lei liu wrote:
> On Wed, 2020-07-22 at 00:44 +0200, Matthias Brugger wrote:
>>
>> On 21/07/2020 14:24, Leilk Liu wrote:
>>> From: "leilk.liu" <leilk.liu@mediatek.com>
>>>
>>> This patch add spi support for mt8192 IC.
>>>
>>> Signed-off-by: leilk.liu <leilk.liu@mediatek.com>
>>> ---
>>>    drivers/spi/spi-mt65xx.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
>>> index 6783e12c40c2..3d0d69fe0c69 100644
>>> --- a/drivers/spi/spi-mt65xx.c
>>> +++ b/drivers/spi/spi-mt65xx.c
>>> @@ -170,6 +170,9 @@ static const struct of_device_id mtk_spi_of_match[] = {
>>>    	{ .compatible = "mediatek,mt8183-spi",
>>>    		.data = (void *)&mt8183_compat,
>>>    	},
>>> +	{ .compatible = "mediatek,mt8192-spi",
>>> +		.data = (void *)&mt6765_compat,
>>> +	},
>>
>> That's not needed. We will use the fallback compatible which is
>> "mediatek,mt6765-spi" which will take the correct DT data. If in the future we
>> realize that mt8192 has a difference in the HW we can add the compatible.
>> Otherwise with the binding description we should be fine
>>
> So you mean that only the following binding patch is needed?
> [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC
> 

Yes, exactly.

Regards,
Matthias

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC
       [not found] <20200721122436.31544-1-leilk.liu@mediatek.com>
       [not found] ` <20200721122436.31544-2-leilk.liu@mediatek.com>
@ 2020-07-22 10:39 ` Matthias Brugger
  2020-07-22 13:45 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-07-22 10:39 UTC (permalink / raw)
  To: Leilk Liu, Mark Brown
  Cc: Mark Rutland, Sascha Hauer, devicetree, linux-kernel,
	linux-arm-kernel, linux-spi, linux-mediatek



On 21/07/2020 14:24, Leilk Liu wrote:
> From: "leilk.liu" <leilk.liu@mediatek.com>
> 
> Add a DT binding documentation for the MT8192 soc.
> 
> Signed-off-by: leilk.liu <leilk.liu@mediatek.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index 3a8079eb18c8..9e43721fa7d6 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -11,6 +11,7 @@ Required properties:
>       - mediatek,mt8135-spi: for mt8135 platforms
>       - mediatek,mt8173-spi: for mt8173 platforms
>       - mediatek,mt8183-spi: for mt8183 platforms
> +    - "mediatek,mt8192-spi", "mediatek,mt6765-spi": for mt8192 platforms
>       - "mediatek,mt8516-spi", "mediatek,mt2712-spi": for mt8516 platforms
>   
>   - #address-cells: should be 1.
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC
       [not found] <20200721122436.31544-1-leilk.liu@mediatek.com>
       [not found] ` <20200721122436.31544-2-leilk.liu@mediatek.com>
  2020-07-22 10:39 ` [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC Matthias Brugger
@ 2020-07-22 13:45 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2020-07-22 13:45 UTC (permalink / raw)
  To: Leilk Liu
  Cc: devicetree, linux-spi, linux-mediatek, Sascha Hauer,
	Mark Rutland, linux-arm-kernel, Matthias Brugger, linux-kernel

On Tue, 21 Jul 2020 20:24:35 +0800, Leilk Liu wrote:
> Add a DT binding documentation for the MT8192 soc.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: update bindings for MT8192 SoC
      commit: 30962fe33ab5ed4bbd78c12f4b9e25a85c3e8d0b
[2/2] spi: mediatek: add spi support for mt8192 IC
      commit: 8cf125c403f4e0c7c7b78f34bbf9d7a7c55c1ff8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200721122436.31544-1-leilk.liu@mediatek.com>
     [not found] ` <20200721122436.31544-2-leilk.liu@mediatek.com>
2020-07-21 22:44   ` [PATCH v2 2/2] spi: mediatek: add spi support for mt8192 IC Matthias Brugger
     [not found]     ` <1595407127.31408.3.camel@mhfsdcap03>
2020-07-22 10:38       ` Matthias Brugger
2020-07-22 10:39 ` [PATCH v2 1/2] dt-bindings: spi: update bindings for MT8192 SoC Matthias Brugger
2020-07-22 13:45 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git