Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM/spi: spear: Drop PL022 num_chipselect
@ 2021-04-08  7:50 Linus Walleij
  2021-04-08  7:56 ` Viresh Kumar
  2021-04-08 16:54 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2021-04-08  7:50 UTC (permalink / raw)
  To: Mark Brown, linux-spi
  Cc: Linus Walleij, Viresh Kumar, Shiraz Hashim, linux-arm-kernel

A previous refactoring moved the chip select number handling
to the SPI core and we missed a leftover platform data user
in the ST spear platform. The spear is not using this
chipselect or PL022 for anything and should be using device
tree like the rest of the platform so just delete the
offending platform data.

Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Mark: please apply this as a fix to the SPI tree unless there
are protests.
---
 arch/arm/mach-spear/spear320.c |  2 --
 arch/arm/mach-spear/spear3xx.c | 10 ----------
 2 files changed, 12 deletions(-)

diff --git a/arch/arm/mach-spear/spear320.c b/arch/arm/mach-spear/spear320.c
index 0958f68a21e2..926d5a243238 100644
--- a/arch/arm/mach-spear/spear320.c
+++ b/arch/arm/mach-spear/spear320.c
@@ -195,14 +195,12 @@ static struct pl022_ssp_controller spear320_ssp_data[] = {
 		.dma_filter = pl08x_filter_id,
 		.dma_tx_param = "ssp1_tx",
 		.dma_rx_param = "ssp1_rx",
-		.num_chipselect = 2,
 	}, {
 		.bus_id = 2,
 		.enable_dma = 1,
 		.dma_filter = pl08x_filter_id,
 		.dma_tx_param = "ssp2_tx",
 		.dma_rx_param = "ssp2_rx",
-		.num_chipselect = 2,
 	}
 };
 
diff --git a/arch/arm/mach-spear/spear3xx.c b/arch/arm/mach-spear/spear3xx.c
index 8537fcffe5a8..f83321d5e353 100644
--- a/arch/arm/mach-spear/spear3xx.c
+++ b/arch/arm/mach-spear/spear3xx.c
@@ -30,16 +30,6 @@ struct pl022_ssp_controller pl022_plat_data = {
 	.dma_filter = pl08x_filter_id,
 	.dma_tx_param = "ssp0_tx",
 	.dma_rx_param = "ssp0_rx",
-	/*
-	 * This is number of spi devices that can be connected to spi. There are
-	 * two type of chipselects on which slave devices can work. One is chip
-	 * select provided by spi masters other is controlled through external
-	 * gpio's. We can't use chipselect provided from spi master (because as
-	 * soon as FIFO becomes empty, CS is disabled and transfer ends). So
-	 * this number now depends on number of gpios available for spi. each
-	 * slave on each master requires a separate gpio pin.
-	 */
-	.num_chipselect = 2,
 };
 
 /* dmac device registration */
-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM/spi: spear: Drop PL022 num_chipselect
  2021-04-08  7:50 [PATCH] ARM/spi: spear: Drop PL022 num_chipselect Linus Walleij
@ 2021-04-08  7:56 ` Viresh Kumar
  2021-04-08 16:54 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-04-08  7:56 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Mark Brown, linux-spi, Viresh Kumar, Shiraz Hashim, linux-arm-kernel

On 08-04-21, 09:50, Linus Walleij wrote:
> A previous refactoring moved the chip select number handling
> to the SPI core and we missed a leftover platform data user
> in the ST spear platform. The spear is not using this
> chipselect or PL022 for anything and should be using device
> tree like the rest of the platform so just delete the
> offending platform data.
> 
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Mark: please apply this as a fix to the SPI tree unless there
> are protests.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM/spi: spear: Drop PL022 num_chipselect
  2021-04-08  7:50 [PATCH] ARM/spi: spear: Drop PL022 num_chipselect Linus Walleij
  2021-04-08  7:56 ` Viresh Kumar
@ 2021-04-08 16:54 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-04-08 16:54 UTC (permalink / raw)
  To: Linus Walleij, linux-spi
  Cc: Mark Brown, Shiraz Hashim, Viresh Kumar, linux-arm-kernel

On Thu, 8 Apr 2021 09:50:45 +0200, Linus Walleij wrote:
> A previous refactoring moved the chip select number handling
> to the SPI core and we missed a leftover platform data user
> in the ST spear platform. The spear is not using this
> chipselect or PL022 for anything and should be using device
> tree like the rest of the platform so just delete the
> offending platform data.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] ARM/spi: spear: Drop PL022 num_chipselect
      commit: d570838efb6fb3154cbd08ab1b22d1f6442b1e78

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08  7:50 [PATCH] ARM/spi: spear: Drop PL022 num_chipselect Linus Walleij
2021-04-08  7:56 ` Viresh Kumar
2021-04-08 16:54 ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git