* [PATCH v4 00/39] Add support for sam9x7 SoC family
@ 2024-02-23 17:13 Varshini Rajendran
2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Varshini Rajendran @ 2024-02-23 17:13 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, herbert,
davem, andi.shyti, tglx, tudor.ambarus, miquel.raynal, richard,
vigneshr, edumazet, kuba, pabeni, linus.walleij, sre,
u.kleine-koenig, p.zabel, olivia, radu_nicolae.pirea,
richard.genoud, gregkh, jirislaby, lgirdwood, broonie, wim,
linux, linux, andrei.simion, mihai.sain, varshini.rajendran,
andre.przywara, neil.armstrong, tony, durai.manickamkr,
geert+renesas, arnd, Jason, rdunlap, rientjes, vbabka, mripard,
codrin.ciubotariu, eugen.hristev, devicetree, linux-arm-kernel,
linux-kernel, linux-clk, linux-crypto, linux-i2c, linux-mtd,
netdev, linux-gpio, linux-pm, linux-pwm, linux-rtc, linux-spi,
linux-serial, alsa-devel, linux-sound, linux-watchdog
This patch series adds support for the new SoC family - sam9x7.
- The device tree, configs and drivers are added
- Clock driver for sam9x7 is added
- Support for basic peripherals is added
- Target board SAM9X75 Curiosity is added
Changes in v4:
--------------
- Addressed all the review comments in the patches
- Picked up all Acked-by and Reviewed-by tags
- Dropped applied patches from the series
- Added pwm node and related dt binding documentation
- Added support for exporting some clocks to DT
- Dropped USB related patches and changes. See NOTE.
- All the specific changes are captured in the corresponding patches
NOTE: Owing to the discussion here
https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/
the USB related changes are dropped from this series in order to enable
us to work on the mentioned issues before adding new compatibles as
said. The issues/warnings will be addressed in subsequent patches.
After which the USB related support for sam9x7 SoCs will be added. Hope
this works out fine.
Changes in v3:
--------------
- Fixed the DT documentation errors pointed out in v2.
- Dropped Acked-by tag in tcb DT doc patch as it had to be adapted
according to sam9x7 correctly.
- Picked by the previously missed tags.
- Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names
property" as the warning was not found while validating DT-schema for
at91-sam9x75_curiosity.dtb.
- Dropped redundant words in the commit message.
- Fixed the CHECK_DTBS warnings validated against
at91-sam9x75_curiosity.dtb.
- Renamed dt nodes according to naming convention.
- Dropped unwanted status property in dts.
- Removed nodes that are not in use from the board dts.
- Removed spi DT doc patch from the series as it was already applied
and a fix patch was applied subsequently. Added a patch to remove the
compatible to adapt sam9x7.
- Added sam9x7 compatibles in usb dt documentation.
Changes in v2:
--------------
- Added sam9x7 specific compatibles in DT with fallbacks
- Documented all the newly added DT compatible strings
- Added device tree for the target board sam9x75 curiosity and
documented the same in the DT bindings documentation
- Removed the dt nodes that are not supported at the moment
- Removed the configs added by previous version that are not supported
at the moment
- Fixed all the corrections in the commit message
- Changed all the instances of copyright year to 2023
- Added sam9x7 flag in PIT64B configuration
- Moved macro definitions to header file
- Added another divider in mck characteristics in the pmc driver
- Fixed the memory leak in the pmc driver
- Dropped patches that are no longer needed
- Picked up Acked-by and Reviewed-by tags
Varshini Rajendran (39):
dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
dt-bindings: atmel-sysreg: add sam9x7
dt-bindings: crypto: add sam9x7 in Atmel AES
dt-bindings: crypto: add sam9x7 in Atmel SHA
dt-bindings: crypto: add sam9x7 in Atmel TDES
dt-bindings: i2c: at91: Add sam9x7 compatible string
dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
dt-bindings: atmel-nand: add microchip,sam9x7-pmecc
dt-bindings: pinctrl: at91: add sam9x7
dt-bindings: rng: atmel,at91-trng: add sam9x7 TRNG
dt-bindings: rtt: at91rm9260: add sam9x7 compatible
dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
ASoC: dt-bindings: atmel-classd: add sam9x7 compatible
dt-bindings: pwm: at91: Add sam9x7 compatible strings list
dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt
spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from
list
ASoC: dt-bindings: microchip: add sam9x7
ARM: at91: pm: add support for sam9x7 SoC family
ARM: at91: pm: add sam9x7 SoC init config
ARM: at91: add support in SoC driver for new sam9x7
dt-bindings: clk: at91: add sam9x7
dt-bindings: clk: at91: add sam9x7 clock controller
clk: at91: clk-sam9x60-pll: re-factor to support individual core freq
outputs
clk: at91: sam9x7: add support for HW PLL freq dividers
clk: at91: sama7g5: move mux table macros to header file
dt-bindings: clock: at91: Allow PLLs to be exported and referenced in
DT
clk: at91: sam9x7: add sam9x7 pmc driver
dt-bindings: irqchip/atmel-aic5: Add support for sam9x7 aic
irqchip/atmel-aic5: Add support to get nirqs from DT for sam9x60 &
sam9x7
power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
power: reset: at91-reset: add reset support for sam9x7 SoC
power: reset: at91-reset: add sdhwc support for sam9x7 SoC
dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7
ARM: at91: Kconfig: add config flag for SAM9X7 SoC
ARM: configs: at91: enable config flags for sam9x7 SoC family
ARM: dts: at91: sam9x7: add device tree for SoC
dt-bindings: arm: add sam9x75 curiosity board
ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board
.../devicetree/bindings/arm/atmel-at91.yaml | 6 +
.../devicetree/bindings/arm/atmel-sysregs.txt | 7 +-
.../bindings/clock/atmel,at91rm9200-pmc.yaml | 2 +
.../bindings/clock/atmel,at91sam9x5-sckc.yaml | 4 +-
.../crypto/atmel,at91sam9g46-aes.yaml | 6 +-
.../crypto/atmel,at91sam9g46-sha.yaml | 6 +-
.../crypto/atmel,at91sam9g46-tdes.yaml | 6 +-
.../bindings/i2c/atmel,at91sam-i2c.yaml | 4 +-
.../interrupt-controller/atmel,aic.txt | 2 +-
.../devicetree/bindings/misc/atmel-ssc.txt | 1 +
.../devicetree/bindings/mtd/atmel-nand.txt | 1 +
.../devicetree/bindings/net/cdns,macb.yaml | 5 +
.../bindings/pinctrl/atmel,at91-pinctrl.txt | 2 +
.../power/reset/atmel,sama5d2-shdwc.yaml | 3 +
.../bindings/pwm/atmel,at91sam-pwm.yaml | 3 +
.../reset/atmel,at91sam9260-reset.yaml | 4 +
.../bindings/rng/atmel,at91-trng.yaml | 4 +
.../bindings/rtc/atmel,at91sam9260-rtt.yaml | 4 +-
.../bindings/serial/atmel,at91-usart.yaml | 12 +-
.../bindings/sound/atmel,sama5d2-classd.yaml | 7 +-
.../sound/microchip,sama7g5-i2smcc.yaml | 11 +-
.../bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
.../bindings/watchdog/atmel,sama5d4-wdt.yaml | 12 +-
arch/arm/boot/dts/microchip/Makefile | 3 +
.../dts/microchip/at91-sam9x75_curiosity.dts | 309 +++++
arch/arm/boot/dts/microchip/sam9x60.dtsi | 1 +
arch/arm/boot/dts/microchip/sam9x7.dtsi | 1214 +++++++++++++++++
arch/arm/configs/at91_dt_defconfig | 1 +
arch/arm/mach-at91/Kconfig | 23 +-
arch/arm/mach-at91/Makefile | 1 +
arch/arm/mach-at91/generic.h | 2 +
arch/arm/mach-at91/pm.c | 35 +
arch/arm/mach-at91/sam9x7.c | 34 +
drivers/clk/at91/Makefile | 1 +
drivers/clk/at91/clk-sam9x60-pll.c | 50 +-
drivers/clk/at91/pmc.h | 18 +
drivers/clk/at91/sam9x60.c | 7 +
drivers/clk/at91/sam9x7.c | 946 +++++++++++++
drivers/clk/at91/sama7g5.c | 42 +-
drivers/irqchip/irq-atmel-aic5.c | 12 +-
drivers/power/reset/Kconfig | 4 +-
drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
drivers/soc/atmel/soc.c | 23 +
drivers/soc/atmel/soc.h | 9 +
include/dt-bindings/clock/at91.h | 4 +
45 files changed, 2788 insertions(+), 65 deletions(-)
create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi
create mode 100644 arch/arm/mach-at91/sam9x7.c
create mode 100644 drivers/clk/at91/sam9x7.c
--
2.25.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
@ 2024-02-23 17:25 ` Varshini Rajendran
2024-02-24 20:02 ` Conor Dooley
2024-02-23 17:26 ` [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
` (5 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Varshini Rajendran @ 2024-02-23 17:25 UTC (permalink / raw)
To: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
Cc: varshini.rajendran
Add sam9x7 compatible to DT bindings documentation.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
Changes in v4:
- Fixed the wrong addition of compatible
- Added further compatibles that are possible correct (as per DT)
---
.../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
index 65cb2e5c5eee..30af537e8e81 100644
--- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
+++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
@@ -23,11 +23,17 @@ properties:
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
- items:
- - const: microchip,sam9x60-usart
+ - enum:
+ - microchip,sam9x60-usart
+ - microchip,sam9x7-usart
- const: atmel,at91sam9260-usart
- items:
- - const: microchip,sam9x60-dbgu
- - const: microchip,sam9x60-usart
+ - enum:
+ - microchip,sam9x60-dbgu
+ - microchip,sam9x7-dbgu
+ - enum:
+ - microchip,sam9x60-usart
+ - microchip,sam9x7-usart
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran
@ 2024-02-23 17:26 ` Varshini Rajendran
2024-02-26 9:09 ` Tudor Ambarus
2024-02-24 1:18 ` (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family Mark Brown
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Varshini Rajendran @ 2024-02-23 17:26 UTC (permalink / raw)
To: broonie, robh+dt, krzysztof.kozlowski+dt, conor+dt,
nicolas.ferre, alexandre.belloni, claudiu.beznea, tudor.ambarus,
linux-spi, devicetree, linux-arm-kernel, linux-kernel
Cc: varshini.rajendran
Remove microchip,sam9x60-spi compatible from the list as the driver used
has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the
same compatible as fallback. So removing the microchip,sam9x60-spi
compatible from the list since it is not needed.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
Changes in v4:
- Elaborated the explanation in the commit message to justify the patch
---
Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
index 58367587bfbc..32e7c14033c2 100644
--- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
@@ -22,7 +22,6 @@ properties:
- const: atmel,at91rm9200-spi
- items:
- const: microchip,sam9x7-spi
- - const: microchip,sam9x60-spi
- const: atmel,at91rm9200-spi
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran
2024-02-23 17:26 ` [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
@ 2024-02-24 1:18 ` Mark Brown
2024-02-27 1:21 ` Andi Shyti
` (3 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2024-02-24 1:18 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, herbert,
davem, andi.shyti, tglx, tudor.ambarus, miquel.raynal, richard,
vigneshr, edumazet, kuba, pabeni, linus.walleij, sre,
u.kleine-koenig, p.zabel, olivia, radu_nicolae.pirea,
richard.genoud, gregkh, jirislaby, lgirdwood, wim, linux, linux,
andrei.simion, mihai.sain, andre.przywara, neil.armstrong, tony,
durai.manickamkr, geert+renesas, arnd, Jason, rdunlap, rientjes,
vbabka, mripard, codrin.ciubotariu, eugen.hristev, devicetree,
linux-arm-kernel, linux-kernel, linux-clk, linux-crypto,
linux-i2c, linux-mtd, netdev, linux-gpio, linux-pm, linux-pwm,
linux-rtc, linux-spi, linux-serial, alsa-devel, linux-sound,
linux-watchdog, Varshini Rajendran
On Fri, 23 Feb 2024 22:43:42 +0530, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
> - The device tree, configs and drivers are added
> - Clock driver for sam9x7 is added
> - Support for basic peripherals is added
> - Target board SAM9X75 Curiosity is added
>
> Changes in v4:
> --------------
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[13/39] ASoC: dt-bindings: atmel-classd: add sam9x7 compatible
commit: 89f3180d5915d4ea40e044ee102cd5c1ec81e7ef
[17/39] ASoC: dt-bindings: microchip: add sam9x7
commit: c06a7a8e885753a024163bbb0dfd7349e8054643
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran
@ 2024-02-24 20:02 ` Conor Dooley
2024-02-28 7:03 ` Varshini.Rajendran
0 siblings, 1 reply; 16+ messages in thread
From: Conor Dooley @ 2024-02-24 20:02 UTC (permalink / raw)
To: Varshini Rajendran
Cc: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]
On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote:
> Add sam9x7 compatible to DT bindings documentation.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> Changes in v4:
> - Fixed the wrong addition of compatible
> - Added further compatibles that are possible correct (as per DT)
> ---
> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> index 65cb2e5c5eee..30af537e8e81 100644
> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> @@ -23,11 +23,17 @@ properties:
> - const: atmel,at91sam9260-dbgu
> - const: atmel,at91sam9260-usart
> - items:
> - - const: microchip,sam9x60-usart
> + - enum:
> + - microchip,sam9x60-usart
> + - microchip,sam9x7-usart
> - const: atmel,at91sam9260-usart
> - items:
> - - const: microchip,sam9x60-dbgu
> - - const: microchip,sam9x60-usart
> + - enum:
> + - microchip,sam9x60-dbgu
> + - microchip,sam9x7-dbgu
> + - enum:
> + - microchip,sam9x60-usart
> + - microchip,sam9x7-usart
This doesn't make sense - this enum should be a const.
I don't really understand the idea behind of the original binding here that
allowed:
"microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
Specifically, I don't get the purpose of the "microchip,sam9x60-usart".
Either make it
- items:
- enum:
- microchip,sam9x60-dbgu
- microchip,sam9x7-dbgu
- const: microchip,sam9x60-usart
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
or add
- items:
- const: microchip,sam9x60-dbgu
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
or explain exactly why this needs to be
"chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu"
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
2024-02-23 17:26 ` [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
@ 2024-02-26 9:09 ` Tudor Ambarus
2024-02-28 9:28 ` Varshini.Rajendran
0 siblings, 1 reply; 16+ messages in thread
From: Tudor Ambarus @ 2024-02-26 9:09 UTC (permalink / raw)
To: Varshini Rajendran, broonie, robh+dt, krzysztof.kozlowski+dt,
conor+dt, nicolas.ferre, alexandre.belloni, claudiu.beznea,
linux-spi, devicetree, linux-arm-kernel, linux-kernel
On 23.02.2024 19:26, Varshini Rajendran wrote:
> Remove microchip,sam9x60-spi compatible from the list as the driver used
> has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the
> same compatible as fallback. So removing the microchip,sam9x60-spi
> compatible from the list since it is not needed.
>
I find this wrong. I though we shall add compatibles for each SoC. Are
the registers and fields the same for the SPI IPs in these 2 SoCs? Even
if they are the same, are you sure the IPs are integrated in the same way?
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> Changes in v4:
> - Elaborated the explanation in the commit message to justify the patch
> ---
> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> index 58367587bfbc..32e7c14033c2 100644
> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> @@ -22,7 +22,6 @@ properties:
> - const: atmel,at91rm9200-spi
> - items:
> - const: microchip,sam9x7-spi
> - - const: microchip,sam9x60-spi
> - const: atmel,at91rm9200-spi
>
> reg:
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
` (2 preceding siblings ...)
2024-02-24 1:18 ` (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family Mark Brown
@ 2024-02-27 1:21 ` Andi Shyti
2024-02-27 3:20 ` patchwork-bot+netdevbpf
` (2 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Andi Shyti @ 2024-02-27 1:21 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, herbert,
davem, tglx, tudor.ambarus, miquel.raynal, richard, vigneshr,
edumazet, kuba, pabeni, linus.walleij, sre, u.kleine-koenig,
p.zabel, olivia, radu_nicolae.pirea, richard.genoud, gregkh,
jirislaby, lgirdwood, broonie, wim, linux, linux, andrei.simion,
mihai.sain, andre.przywara, neil.armstrong, tony,
durai.manickamkr, geert+renesas, arnd, Jason, rdunlap, rientjes,
vbabka, mripard, codrin.ciubotariu, eugen.hristev, devicetree,
linux-arm-kernel, linux-kernel, linux-clk, linux-crypto,
linux-i2c, linux-mtd, netdev, linux-gpio, linux-pm, linux-pwm,
linux-rtc, linux-spi, linux-serial, alsa-devel, linux-sound,
linux-watchdog, Varshini Rajendran
Hi
On Fri, 23 Feb 2024 22:43:42 +0530, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
> - The device tree, configs and drivers are added
> - Clock driver for sam9x7 is added
> - Support for basic peripherals is added
> - Target board SAM9X75 Curiosity is added
>
> Changes in v4:
> --------------
>
> [...]
Applied to i2c/i2c-host on
git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
Thank you,
Andi
Patches applied
===============
[06/39] dt-bindings: i2c: at91: Add sam9x7 compatible string
commit: a856c9e6104f7b4619f09e19ab95903c7888da96
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 00/39] Add support for sam9x7 SoC family
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
` (3 preceding siblings ...)
2024-02-27 1:21 ` Andi Shyti
@ 2024-02-27 3:20 ` patchwork-bot+netdevbpf
2024-02-28 15:53 ` (subset) " Mark Brown
2024-03-01 10:51 ` Herbert Xu
6 siblings, 0 replies; 16+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-27 3:20 UTC (permalink / raw)
To: Varshini Rajendran
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, herbert,
davem, andi.shyti, tglx, tudor.ambarus, miquel.raynal, richard,
vigneshr, edumazet, kuba, pabeni, linus.walleij, sre,
u.kleine-koenig, p.zabel, olivia, radu_nicolae.pirea,
richard.genoud, gregkh, jirislaby, lgirdwood, broonie, wim,
linux, linux, andrei.simion, mihai.sain, andre.przywara,
neil.armstrong, tony, durai.manickamkr, geert+renesas, arnd,
Jason, rdunlap, rientjes, vbabka, mripard, codrin.ciubotariu,
eugen.hristev, devicetree, linux-arm-kernel, linux-kernel,
linux-clk, linux-crypto, linux-i2c, linux-mtd, netdev,
linux-gpio, linux-pm, linux-pwm, linux-rtc, linux-spi,
linux-serial, alsa-devel, linux-sound, linux-watchdog
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 23 Feb 2024 22:43:42 +0530 you wrote:
> This patch series adds support for the new SoC family - sam9x7.
> - The device tree, configs and drivers are added
> - Clock driver for sam9x7 is added
> - Support for basic peripherals is added
> - Target board SAM9X75 Curiosity is added
>
> Changes in v4:
>
> [...]
Here is the summary with links:
- [v4,01/39] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
https://git.kernel.org/netdev/net-next/c/5c237967e632
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-24 20:02 ` Conor Dooley
@ 2024-02-28 7:03 ` Varshini.Rajendran
2024-02-28 11:49 ` Conor Dooley
0 siblings, 1 reply; 16+ messages in thread
From: Varshini.Rajendran @ 2024-02-28 7:03 UTC (permalink / raw)
To: conor
Cc: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
Hi Conor,
On 25/02/24 1:32 am, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote:
>> Add sam9x7 compatible to DT bindings documentation.
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> Changes in v4:
>> - Fixed the wrong addition of compatible
>> - Added further compatibles that are possible correct (as per DT)
>> ---
>> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>> index 65cb2e5c5eee..30af537e8e81 100644
>> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>> @@ -23,11 +23,17 @@ properties:
>> - const: atmel,at91sam9260-dbgu
>> - const: atmel,at91sam9260-usart
>> - items:
>> - - const: microchip,sam9x60-usart
>> + - enum:
>> + - microchip,sam9x60-usart
>> + - microchip,sam9x7-usart
>> - const: atmel,at91sam9260-usart
>> - items:
>> - - const: microchip,sam9x60-dbgu
>> - - const: microchip,sam9x60-usart
>> + - enum:
>> + - microchip,sam9x60-dbgu
>> + - microchip,sam9x7-dbgu
>
>> + - enum:
>> + - microchip,sam9x60-usart
>> + - microchip,sam9x7-usart
>
> This doesn't make sense - this enum should be a const.
> I don't really understand the idea behind of the original binding here that
> allowed:
> "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
>
> Specifically, I don't get the purpose of the "microchip,sam9x60-usart".
> Either make it
> - items:
> - enum:
> - microchip,sam9x60-dbgu
> - microchip,sam9x7-dbgu
> - const: microchip,sam9x60-usart
> - const: atmel,at91sam9260-dbgu
> - const: atmel,at91sam9260-usart
> or add
> - items:
> - const: microchip,sam9x60-dbgu
> - const: atmel,at91sam9260-dbgu
> - const: atmel,at91sam9260-usart
> or explain exactly why this needs to be
> "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu"
The compatible has to be "chipa-usart", "chipb-usart", "chipa-dbgu",
"chipb-dbgu" for the device to work as a debug console over UART
wher the chipa-<periph> is the device specific compatible
and the chipb-<periph> is the fallback compatible that the driver
actually uses.
Maybe putting the 2 compatibles as 2 enums is not right. I will rephrase
it as below.
- items:
- const: microchip,sam9x60-dbgu
- const: microchip,sam9x60-usart
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
- items:
- const: microchip,sam9x7-dbgu
- const: microchip,sam9x7-usart
- const: atmel,at91sam9260-dbgu
- const: atmel,at91sam9260-usart
Hope this is fine.
>
> Thanks,
> Conor.
>
--
Thanks and Regards,
Varshini Rajendran.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
2024-02-26 9:09 ` Tudor Ambarus
@ 2024-02-28 9:28 ` Varshini.Rajendran
2024-02-28 9:38 ` Tudor Ambarus
0 siblings, 1 reply; 16+ messages in thread
From: Varshini.Rajendran @ 2024-02-28 9:28 UTC (permalink / raw)
To: tudor.ambarus, broonie, robh+dt, krzysztof.kozlowski+dt,
conor+dt, Nicolas.Ferre, alexandre.belloni, claudiu.beznea,
linux-spi, devicetree, linux-arm-kernel, linux-kernel
Hi Tudor,
On 26/02/24 2:39 pm, Tudor Ambarus wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 23.02.2024 19:26, Varshini Rajendran wrote:
>> Remove microchip,sam9x60-spi compatible from the list as the driver used
>> has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the
>> same compatible as fallback. So removing the microchip,sam9x60-spi
>> compatible from the list since it is not needed.
>>
>
> I find this wrong. I though we shall add compatibles for each SoC. Are
> the registers and fields the same for the SPI IPs in these 2 SoCs? Even
> if they are the same, are you sure the IPs are integrated in the same way?
Which two SoCs are you referring to ?
I am not removing the device specific compatible. I am only removing the
additional fallback compatible.
As in,
compatible = "microchip,sam9x7-spi", "atmel,at91rm9200-spi";
instead of,
compatible = "microchip,sam9x7-spi", "microchip,sam9x60-spi",
"atmel,at91rm9200-spi";
for the sam9x7 devices.
Hope this is clear. If I have it wrong please let me know.
>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> Changes in v4:
>> - Elaborated the explanation in the commit message to justify the patch
>> ---
>> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>> index 58367587bfbc..32e7c14033c2 100644
>> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>> @@ -22,7 +22,6 @@ properties:
>> - const: atmel,at91rm9200-spi
>> - items:
>> - const: microchip,sam9x7-spi
>> - - const: microchip,sam9x60-spi
>> - const: atmel,at91rm9200-spi
>>
>> reg:
--
Thanks and Regards,
Varshini Rajendran.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
2024-02-28 9:28 ` Varshini.Rajendran
@ 2024-02-28 9:38 ` Tudor Ambarus
0 siblings, 0 replies; 16+ messages in thread
From: Tudor Ambarus @ 2024-02-28 9:38 UTC (permalink / raw)
To: Varshini.Rajendran, broonie, robh+dt, krzysztof.kozlowski+dt,
conor+dt, Nicolas.Ferre, alexandre.belloni, claudiu.beznea,
linux-spi, devicetree, linux-arm-kernel, linux-kernel
On 2/28/24 09:28, Varshini.Rajendran@microchip.com wrote:
> Hi Tudor,
>
> On 26/02/24 2:39 pm, Tudor Ambarus wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 23.02.2024 19:26, Varshini Rajendran wrote:
>>> Remove microchip,sam9x60-spi compatible from the list as the driver used
>>> has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the
>>> same compatible as fallback. So removing the microchip,sam9x60-spi
>>> compatible from the list since it is not needed.
>>>
>>
>> I find this wrong. I though we shall add compatibles for each SoC. Are
>> the registers and fields the same for the SPI IPs in these 2 SoCs? Even
>> if they are the same, are you sure the IPs are integrated in the same way?
>
> Which two SoCs are you referring to ?
> I am not removing the device specific compatible. I am only removing the
> additional fallback compatible.
>
ah, I read it wrong, sorry
> As in,
>
> compatible = "microchip,sam9x7-spi", "atmel,at91rm9200-spi";
>
> instead of,
>
> compatible = "microchip,sam9x7-spi", "microchip,sam9x60-spi",
> "atmel,at91rm9200-spi";
>
> for the sam9x7 devices.
>
> Hope this is clear. If I have it wrong please let me know.
it's clear now, thanks.
I see in the driver that microchip,sam9x60-spi compatible is not yet
used, thus removing the fallback to "microchip,sam9x60-spi" brings no
functional change. Would have made a difference if sam9x60-spi
implemented additional support that sam9x7-spi could have used as a
fallback. If you think that sam9x7-spi will not fallback to sam9x60-spi
in the future then:
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>
>>
>>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>>> ---
>>> Changes in v4:
>>> - Elaborated the explanation in the commit message to justify the patch
>>> ---
>>> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>>> index 58367587bfbc..32e7c14033c2 100644
>>> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
>>> @@ -22,7 +22,6 @@ properties:
>>> - const: atmel,at91rm9200-spi
>>> - items:
>>> - const: microchip,sam9x7-spi
>>> - - const: microchip,sam9x60-spi
>>> - const: atmel,at91rm9200-spi
>>>
>>> reg:
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-28 7:03 ` Varshini.Rajendran
@ 2024-02-28 11:49 ` Conor Dooley
2024-02-29 8:55 ` Varshini.Rajendran
0 siblings, 1 reply; 16+ messages in thread
From: Conor Dooley @ 2024-02-28 11:49 UTC (permalink / raw)
To: Varshini.Rajendran
Cc: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 3562 bytes --]
On Wed, Feb 28, 2024 at 07:03:01AM +0000, Varshini.Rajendran@microchip.com wrote:
> Hi Conor,
>
> On 25/02/24 1:32 am, Conor Dooley wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote:
> >> Add sam9x7 compatible to DT bindings documentation.
> >>
> >> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> >> ---
> >> Changes in v4:
> >> - Fixed the wrong addition of compatible
> >> - Added further compatibles that are possible correct (as per DT)
> >> ---
> >> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
> >> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> index 65cb2e5c5eee..30af537e8e81 100644
> >> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >> @@ -23,11 +23,17 @@ properties:
> >> - const: atmel,at91sam9260-dbgu
> >> - const: atmel,at91sam9260-usart
> >> - items:
> >> - - const: microchip,sam9x60-usart
> >> + - enum:
> >> + - microchip,sam9x60-usart
> >> + - microchip,sam9x7-usart
> >> - const: atmel,at91sam9260-usart
> >> - items:
> >> - - const: microchip,sam9x60-dbgu
> >> - - const: microchip,sam9x60-usart
> >> + - enum:
> >> + - microchip,sam9x60-dbgu
> >> + - microchip,sam9x7-dbgu
> >
> >> + - enum:
> >> + - microchip,sam9x60-usart
> >> + - microchip,sam9x7-usart
> >
> > This doesn't make sense - this enum should be a const.
> > I don't really understand the idea behind of the original binding here that
> > allowed:
> > "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
> >
> > Specifically, I don't get the purpose of the "microchip,sam9x60-usart".
> > Either make it
> > - items:
> > - enum:
> > - microchip,sam9x60-dbgu
> > - microchip,sam9x7-dbgu
> > - const: microchip,sam9x60-usart
> > - const: atmel,at91sam9260-dbgu
> > - const: atmel,at91sam9260-usart
> > or add
> > - items:
> > - const: microchip,sam9x60-dbgu
> > - const: atmel,at91sam9260-dbgu
> > - const: atmel,at91sam9260-usart
> > or explain exactly why this needs to be
> > "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu"
> The compatible has to be "chipa-usart", "chipb-usart", "chipa-dbgu",
> "chipb-dbgu" for the device to work as a debug console over UART
> wher the chipa-<periph> is the device specific compatible
> and the chipb-<periph> is the fallback compatible that the driver
> actually uses.
This examples why you have "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu"
and "atmel,at91sam9260-usart".
It does not explain "microchip,sam9x60-usart" though, I don't see what
purpose that serves. If used as a debug uart, you fall back to the
sam9260 debug uart compatible and if not you fall back to the sam9260
usart compatible.
In addition, the current setup implies that sam9x60 usart supports all
the features that the sam9260 debug usart does. I doubt that that is
true.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
` (4 preceding siblings ...)
2024-02-27 3:20 ` patchwork-bot+netdevbpf
@ 2024-02-28 15:53 ` Mark Brown
2024-03-01 10:51 ` Herbert Xu
6 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2024-02-28 15:53 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, herbert,
davem, andi.shyti, tglx, tudor.ambarus, miquel.raynal, richard,
vigneshr, edumazet, kuba, pabeni, linus.walleij, sre,
u.kleine-koenig, p.zabel, olivia, radu_nicolae.pirea,
richard.genoud, gregkh, jirislaby, lgirdwood, wim, linux, linux,
andrei.simion, mihai.sain, andre.przywara, neil.armstrong, tony,
durai.manickamkr, geert+renesas, arnd, Jason, rdunlap, rientjes,
vbabka, mripard, codrin.ciubotariu, eugen.hristev, devicetree,
linux-arm-kernel, linux-kernel, linux-clk, linux-crypto,
linux-i2c, linux-mtd, netdev, linux-gpio, linux-pm, linux-pwm,
linux-rtc, linux-spi, linux-serial, alsa-devel, linux-sound,
linux-watchdog, Varshini Rajendran
On Fri, 23 Feb 2024 22:43:42 +0530, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
> - The device tree, configs and drivers are added
> - Clock driver for sam9x7 is added
> - Support for basic peripherals is added
> - Target board SAM9X75 Curiosity is added
>
> Changes in v4:
> --------------
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list
commit: 666db8fd4265f938795004838d2a9335ce7b9da1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-28 11:49 ` Conor Dooley
@ 2024-02-29 8:55 ` Varshini.Rajendran
2024-02-29 18:26 ` Conor Dooley
0 siblings, 1 reply; 16+ messages in thread
From: Varshini.Rajendran @ 2024-02-29 8:55 UTC (permalink / raw)
To: conor
Cc: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
Hi Conor,
On 28/02/24 5:19 pm, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> On Wed, Feb 28, 2024 at 07:03:01AM +0000, Varshini.Rajendran@microchip.com wrote:
>> Hi Conor,
>>
>> On 25/02/24 1:32 am, Conor Dooley wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>> On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote:
>>>> Add sam9x7 compatible to DT bindings documentation.
>>>>
>>>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>>>> ---
>>>> Changes in v4:
>>>> - Fixed the wrong addition of compatible
>>>> - Added further compatibles that are possible correct (as per DT)
>>>> ---
>>>> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>>>> index 65cb2e5c5eee..30af537e8e81 100644
>>>> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>>>> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
>>>> @@ -23,11 +23,17 @@ properties:
>>>> - const: atmel,at91sam9260-dbgu
>>>> - const: atmel,at91sam9260-usart
>>>> - items:
>>>> - - const: microchip,sam9x60-usart
>>>> + - enum:
>>>> + - microchip,sam9x60-usart
>>>> + - microchip,sam9x7-usart
>>>> - const: atmel,at91sam9260-usart
>>>> - items:
>>>> - - const: microchip,sam9x60-dbgu
>>>> - - const: microchip,sam9x60-usart
>>>> + - enum:
>>>> + - microchip,sam9x60-dbgu
>>>> + - microchip,sam9x7-dbgu
>>>
>>>> + - enum:
>>>> + - microchip,sam9x60-usart
>>>> + - microchip,sam9x7-usart
>>>
>>> This doesn't make sense - this enum should be a const.
>>> I don't really understand the idea behind of the original binding here that
>>> allowed:
>>> "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
>>>
>>> Specifically, I don't get the purpose of the "microchip,sam9x60-usart".
>>> Either make it
>>> - items:
>>> - enum:
>>> - microchip,sam9x60-dbgu
>>> - microchip,sam9x7-dbgu
>>> - const: microchip,sam9x60-usart
>>> - const: atmel,at91sam9260-dbgu
>>> - const: atmel,at91sam9260-usart
>>> or add
>>> - items:
>>> - const: microchip,sam9x60-dbgu
>>> - const: atmel,at91sam9260-dbgu
>>> - const: atmel,at91sam9260-usart
>>> or explain exactly why this needs to be
>>> "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu"
>> The compatible has to be "chipa-usart", "chipb-usart", "chipa-dbgu",
>> "chipb-dbgu" for the device to work as a debug console over UART
>> wher the chipa-<periph> is the device specific compatible
>> and the chipb-<periph> is the fallback compatible that the driver
>> actually uses.
>
> This examples why you have "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu"
> and "atmel,at91sam9260-usart".
> It does not explain "microchip,sam9x60-usart" though, I don't see what
> purpose that serves. If used as a debug uart, you fall back to the
> sam9260 debug uart compatible and if not you fall back to the sam9260
> usart compatible.
>
Here, if it is not used as debug uart it has to fallback to the default
usart compatible which in this case should have a device specific
compatible too right?
The common usart compatible looks as follows,
compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
meaning the 1st one is the device specific usart compatible and the 2nd
one is the fallback compatible which the driver actually supports.
The debug uart looks as follows,
compatible = "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu",
"microchip,sam9x60-usart", "atmel,at91sam9260-usart";
In this case, there is a device specific debug uart compatible, a
fallback tot he debug uart compatible and as you said if not used as a
debug uart it should fallback and work as a normal uart device which has
both a device specific compatible and a fallback to work.
In case the device specific compatible is supported with some other
features in the driver in the future, the debug uart also should get its
perk. Does this make sense?
> In addition, the current setup implies that sam9x60 usart supports all
> the features that the sam9260 debug usart does. I doubt that that is
> true.
>
> Thanks,
> Conor.
--
Thanks and Regards,
Varshini Rajendran.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
2024-02-29 8:55 ` Varshini.Rajendran
@ 2024-02-29 18:26 ` Conor Dooley
0 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2024-02-29 18:26 UTC (permalink / raw)
To: Varshini.Rajendran
Cc: radu_nicolae.pirea, richard.genoud, gregkh, jirislaby, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-kernel, linux-spi,
linux-serial, devicetree, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 5229 bytes --]
On Thu, Feb 29, 2024 at 08:55:11AM +0000, Varshini.Rajendran@microchip.com wrote:
> Hi Conor,
>
> On 28/02/24 5:19 pm, Conor Dooley wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > On Wed, Feb 28, 2024 at 07:03:01AM +0000, Varshini.Rajendran@microchip.com wrote:
> >> Hi Conor,
> >>
> >> On 25/02/24 1:32 am, Conor Dooley wrote:
> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >>> On Fri, Feb 23, 2024 at 10:55:59PM +0530, Varshini Rajendran wrote:
> >>>> Add sam9x7 compatible to DT bindings documentation.
> >>>>
> >>>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> >>>> ---
> >>>> Changes in v4:
> >>>> - Fixed the wrong addition of compatible
> >>>> - Added further compatibles that are possible correct (as per DT)
> >>>> ---
> >>>> .../devicetree/bindings/serial/atmel,at91-usart.yaml | 12 +++++++++---
> >>>> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >>>> index 65cb2e5c5eee..30af537e8e81 100644
> >>>> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >>>> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml
> >>>> @@ -23,11 +23,17 @@ properties:
> >>>> - const: atmel,at91sam9260-dbgu
> >>>> - const: atmel,at91sam9260-usart
> >>>> - items:
> >>>> - - const: microchip,sam9x60-usart
> >>>> + - enum:
> >>>> + - microchip,sam9x60-usart
> >>>> + - microchip,sam9x7-usart
> >>>> - const: atmel,at91sam9260-usart
> >>>> - items:
> >>>> - - const: microchip,sam9x60-dbgu
> >>>> - - const: microchip,sam9x60-usart
> >>>> + - enum:
> >>>> + - microchip,sam9x60-dbgu
> >>>> + - microchip,sam9x7-dbgu
> >>>
> >>>> + - enum:
> >>>> + - microchip,sam9x60-usart
> >>>> + - microchip,sam9x7-usart
> >>>
> >>> This doesn't make sense - this enum should be a const.
> >>> I don't really understand the idea behind of the original binding here that
> >>> allowed:
> >>> "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
> >>>
> >>> Specifically, I don't get the purpose of the "microchip,sam9x60-usart".
> >>> Either make it
> >>> - items:
> >>> - enum:
> >>> - microchip,sam9x60-dbgu
> >>> - microchip,sam9x7-dbgu
> >>> - const: microchip,sam9x60-usart
> >>> - const: atmel,at91sam9260-dbgu
> >>> - const: atmel,at91sam9260-usart
> >>> or add
> >>> - items:
> >>> - const: microchip,sam9x60-dbgu
> >>> - const: atmel,at91sam9260-dbgu
> >>> - const: atmel,at91sam9260-usart
> >>> or explain exactly why this needs to be
> >>> "chipa-dgbu", "chipa-usart", "chipb-dbgu", "chipb-dbgu"
> >> The compatible has to be "chipa-usart", "chipb-usart", "chipa-dbgu",
> >> "chipb-dbgu" for the device to work as a debug console over UART
> >> wher the chipa-<periph> is the device specific compatible
> >> and the chipb-<periph> is the fallback compatible that the driver
> >> actually uses.
> >
> > This examples why you have "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu"
> > and "atmel,at91sam9260-usart".
> > It does not explain "microchip,sam9x60-usart" though, I don't see what
> > purpose that serves. If used as a debug uart, you fall back to the
> > sam9260 debug uart compatible and if not you fall back to the sam9260
> > usart compatible.
> >
> Here, if it is not used as debug uart it has to fallback to the default
> usart compatible which in this case should have a device specific
> compatible too right?
>
> The common usart compatible looks as follows,
>
> compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
>
> meaning the 1st one is the device specific usart compatible and the 2nd
> one is the fallback compatible which the driver actually supports.
>
> The debug uart looks as follows,
>
> compatible = "microchip,sam9x60-dbgu", "atmel,at91sam9260-dbgu",
> "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
This version here makes a lot more sense than what is currently in use
and what is being added in your original patch. I wouldn't object to
this being used.
> In this case, there is a device specific debug uart compatible, a
> fallback tot he debug uart compatible and as you said if not used as a
> debug uart it should fallback and work as a normal uart device which has
> both a device specific compatible and a fallback to work.
>
> In case the device specific compatible is supported with some other
> features in the driver in the future, the debug uart also should get its
> perk. Does this make sense?
>
>
> > In addition, the current setup implies that sam9x60 usart supports all
> > the features that the sam9260 debug usart does. I doubt that that is
> > true.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v4 00/39] Add support for sam9x7 SoC family
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
` (5 preceding siblings ...)
2024-02-28 15:53 ` (subset) " Mark Brown
@ 2024-03-01 10:51 ` Herbert Xu
6 siblings, 0 replies; 16+ messages in thread
From: Herbert Xu @ 2024-03-01 10:51 UTC (permalink / raw)
To: Varshini Rajendran
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, mturquette, sboyd, davem,
andi.shyti, tglx, tudor.ambarus, miquel.raynal, richard,
vigneshr, edumazet, kuba, pabeni, linus.walleij, sre,
u.kleine-koenig, p.zabel, olivia, radu_nicolae.pirea,
richard.genoud, gregkh, jirislaby, lgirdwood, broonie, wim,
linux, linux, andrei.simion, mihai.sain, andre.przywara,
neil.armstrong, tony, durai.manickamkr, geert+renesas, arnd,
Jason, rdunlap, rientjes, vbabka, mripard, codrin.ciubotariu,
eugen.hristev, devicetree, linux-arm-kernel, linux-kernel,
linux-clk, linux-crypto, linux-i2c, linux-mtd, netdev,
linux-gpio, linux-pm, linux-pwm, linux-rtc, linux-spi,
linux-serial, alsa-devel, linux-sound, linux-watchdog
On Fri, Feb 23, 2024 at 10:43:42PM +0530, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
> - The device tree, configs and drivers are added
> - Clock driver for sam9x7 is added
> - Support for basic peripherals is added
> - Target board SAM9X75 Curiosity is added
>
> Changes in v4:
> --------------
>
> - Addressed all the review comments in the patches
> - Picked up all Acked-by and Reviewed-by tags
> - Dropped applied patches from the series
> - Added pwm node and related dt binding documentation
> - Added support for exporting some clocks to DT
> - Dropped USB related patches and changes. See NOTE.
> - All the specific changes are captured in the corresponding patches
>
> NOTE: Owing to the discussion here
> https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/
> the USB related changes are dropped from this series in order to enable
> us to work on the mentioned issues before adding new compatibles as
> said. The issues/warnings will be addressed in subsequent patches.
> After which the USB related support for sam9x7 SoCs will be added. Hope
> this works out fine.
>
> Changes in v3:
> --------------
>
> - Fixed the DT documentation errors pointed out in v2.
> - Dropped Acked-by tag in tcb DT doc patch as it had to be adapted
> according to sam9x7 correctly.
> - Picked by the previously missed tags.
> - Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names
> property" as the warning was not found while validating DT-schema for
> at91-sam9x75_curiosity.dtb.
> - Dropped redundant words in the commit message.
> - Fixed the CHECK_DTBS warnings validated against
> at91-sam9x75_curiosity.dtb.
> - Renamed dt nodes according to naming convention.
> - Dropped unwanted status property in dts.
> - Removed nodes that are not in use from the board dts.
> - Removed spi DT doc patch from the series as it was already applied
> and a fix patch was applied subsequently. Added a patch to remove the
> compatible to adapt sam9x7.
> - Added sam9x7 compatibles in usb dt documentation.
>
>
> Changes in v2:
> --------------
>
> - Added sam9x7 specific compatibles in DT with fallbacks
> - Documented all the newly added DT compatible strings
> - Added device tree for the target board sam9x75 curiosity and
> documented the same in the DT bindings documentation
> - Removed the dt nodes that are not supported at the moment
> - Removed the configs added by previous version that are not supported
> at the moment
> - Fixed all the corrections in the commit message
> - Changed all the instances of copyright year to 2023
> - Added sam9x7 flag in PIT64B configuration
> - Moved macro definitions to header file
> - Added another divider in mck characteristics in the pmc driver
> - Fixed the memory leak in the pmc driver
> - Dropped patches that are no longer needed
> - Picked up Acked-by and Reviewed-by tags
>
>
> Varshini Rajendran (39):
> dt-bindings: net: cdns,macb: add sam9x7 ethernet interface
> dt-bindings: atmel-sysreg: add sam9x7
> dt-bindings: crypto: add sam9x7 in Atmel AES
> dt-bindings: crypto: add sam9x7 in Atmel SHA
> dt-bindings: crypto: add sam9x7 in Atmel TDES
> dt-bindings: i2c: at91: Add sam9x7 compatible string
> dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
> dt-bindings: atmel-nand: add microchip,sam9x7-pmecc
> dt-bindings: pinctrl: at91: add sam9x7
> dt-bindings: rng: atmel,at91-trng: add sam9x7 TRNG
> dt-bindings: rtt: at91rm9260: add sam9x7 compatible
> dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7.
> ASoC: dt-bindings: atmel-classd: add sam9x7 compatible
> dt-bindings: pwm: at91: Add sam9x7 compatible strings list
> dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt
> spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from
> list
> ASoC: dt-bindings: microchip: add sam9x7
> ARM: at91: pm: add support for sam9x7 SoC family
> ARM: at91: pm: add sam9x7 SoC init config
> ARM: at91: add support in SoC driver for new sam9x7
> dt-bindings: clk: at91: add sam9x7
> dt-bindings: clk: at91: add sam9x7 clock controller
> clk: at91: clk-sam9x60-pll: re-factor to support individual core freq
> outputs
> clk: at91: sam9x7: add support for HW PLL freq dividers
> clk: at91: sama7g5: move mux table macros to header file
> dt-bindings: clock: at91: Allow PLLs to be exported and referenced in
> DT
> clk: at91: sam9x7: add sam9x7 pmc driver
> dt-bindings: irqchip/atmel-aic5: Add support for sam9x7 aic
> irqchip/atmel-aic5: Add support to get nirqs from DT for sam9x60 &
> sam9x7
> power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
> power: reset: at91-reset: add reset support for sam9x7 SoC
> power: reset: at91-reset: add sdhwc support for sam9x7 SoC
> dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
> dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7
> ARM: at91: Kconfig: add config flag for SAM9X7 SoC
> ARM: configs: at91: enable config flags for sam9x7 SoC family
> ARM: dts: at91: sam9x7: add device tree for SoC
> dt-bindings: arm: add sam9x75 curiosity board
> ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board
>
> .../devicetree/bindings/arm/atmel-at91.yaml | 6 +
> .../devicetree/bindings/arm/atmel-sysregs.txt | 7 +-
> .../bindings/clock/atmel,at91rm9200-pmc.yaml | 2 +
> .../bindings/clock/atmel,at91sam9x5-sckc.yaml | 4 +-
> .../crypto/atmel,at91sam9g46-aes.yaml | 6 +-
> .../crypto/atmel,at91sam9g46-sha.yaml | 6 +-
> .../crypto/atmel,at91sam9g46-tdes.yaml | 6 +-
> .../bindings/i2c/atmel,at91sam-i2c.yaml | 4 +-
> .../interrupt-controller/atmel,aic.txt | 2 +-
> .../devicetree/bindings/misc/atmel-ssc.txt | 1 +
> .../devicetree/bindings/mtd/atmel-nand.txt | 1 +
> .../devicetree/bindings/net/cdns,macb.yaml | 5 +
> .../bindings/pinctrl/atmel,at91-pinctrl.txt | 2 +
> .../power/reset/atmel,sama5d2-shdwc.yaml | 3 +
> .../bindings/pwm/atmel,at91sam-pwm.yaml | 3 +
> .../reset/atmel,at91sam9260-reset.yaml | 4 +
> .../bindings/rng/atmel,at91-trng.yaml | 4 +
> .../bindings/rtc/atmel,at91sam9260-rtt.yaml | 4 +-
> .../bindings/serial/atmel,at91-usart.yaml | 12 +-
> .../bindings/sound/atmel,sama5d2-classd.yaml | 7 +-
> .../sound/microchip,sama7g5-i2smcc.yaml | 11 +-
> .../bindings/spi/atmel,at91rm9200-spi.yaml | 1 -
> .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 12 +-
> arch/arm/boot/dts/microchip/Makefile | 3 +
> .../dts/microchip/at91-sam9x75_curiosity.dts | 309 +++++
> arch/arm/boot/dts/microchip/sam9x60.dtsi | 1 +
> arch/arm/boot/dts/microchip/sam9x7.dtsi | 1214 +++++++++++++++++
> arch/arm/configs/at91_dt_defconfig | 1 +
> arch/arm/mach-at91/Kconfig | 23 +-
> arch/arm/mach-at91/Makefile | 1 +
> arch/arm/mach-at91/generic.h | 2 +
> arch/arm/mach-at91/pm.c | 35 +
> arch/arm/mach-at91/sam9x7.c | 34 +
> drivers/clk/at91/Makefile | 1 +
> drivers/clk/at91/clk-sam9x60-pll.c | 50 +-
> drivers/clk/at91/pmc.h | 18 +
> drivers/clk/at91/sam9x60.c | 7 +
> drivers/clk/at91/sam9x7.c | 946 +++++++++++++
> drivers/clk/at91/sama7g5.c | 42 +-
> drivers/irqchip/irq-atmel-aic5.c | 12 +-
> drivers/power/reset/Kconfig | 4 +-
> drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
> drivers/soc/atmel/soc.c | 23 +
> drivers/soc/atmel/soc.h | 9 +
> include/dt-bindings/clock/at91.h | 4 +
> 45 files changed, 2788 insertions(+), 65 deletions(-)
> create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
> create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi
> create mode 100644 arch/arm/mach-at91/sam9x7.c
> create mode 100644 drivers/clk/at91/sam9x7.c
>
> --
> 2.25.1
Patches 3-5 and 10 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-03-01 10:53 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 17:13 [PATCH v4 00/39] Add support for sam9x7 SoC family Varshini Rajendran
2024-02-23 17:25 ` [PATCH v4 12/39] dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 Varshini Rajendran
2024-02-24 20:02 ` Conor Dooley
2024-02-28 7:03 ` Varshini.Rajendran
2024-02-28 11:49 ` Conor Dooley
2024-02-29 8:55 ` Varshini.Rajendran
2024-02-29 18:26 ` Conor Dooley
2024-02-23 17:26 ` [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list Varshini Rajendran
2024-02-26 9:09 ` Tudor Ambarus
2024-02-28 9:28 ` Varshini.Rajendran
2024-02-28 9:38 ` Tudor Ambarus
2024-02-24 1:18 ` (subset) [PATCH v4 00/39] Add support for sam9x7 SoC family Mark Brown
2024-02-27 1:21 ` Andi Shyti
2024-02-27 3:20 ` patchwork-bot+netdevbpf
2024-02-28 15:53 ` (subset) " Mark Brown
2024-03-01 10:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).