From: "Joakim Tjernlund" <Joakim.Tjernlund@transmode.se>
To: "'David Brownell'" <david-b@pacbell.net>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: spi-devel-general@lists.sourceforge.net, 12o3l@tiscali.nl,
linuxppc-dev@ozlabs.org
Subject: RE: [patch 2.6.25-git] spi_mpc83xx much improved driver
Date: Thu, 1 May 2008 12:42:01 +0200 [thread overview]
Message-ID: <1924.82319330356$1209638659@news.gmane.org> (raw)
In-Reply-To: <200804301555.34110.david-b@pacbell.net>
> -----Original Message-----
> From: David Brownell [mailto:david-b@pacbell.net]
> Sent: den 1 maj 2008 00:56
> To: Andrew Morton
> Cc: spi-devel-general@lists.sourceforge.net; joakim.tjernlund@transmode.se; linuxppc-dev@ozlabs.org;
> 12o3l@tiscali.nl
> Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
>
> On Wednesday 30 April 2008, Andrew Morton wrote:
> > > + spin_lock_irq(&mpc83xx_spi->lock);
> >
> > irq-safe.
> >
> > > ...
> > >
> > > + spin_lock(&mpc83xx_spi->lock);
> >
> > not irq-safe.
> >
> > Deliberate?
>
> That latter one is inside an #if 0/#endif block, so it won't matter.
> The #if 0 block bothered me. Maybe Joakim can remove it.
The non irq-safe spin_lock was there before my patch and now it is
removed with the #if 0/#endif block. I don't need this code but
I left it there disabled to make it clear for everyone else
that it was removed. I can remove it but I rather leave it
there for one release so everyone will have a chance to see
it and object if they feel differently.
>
> (By the way, I'd feel safer about this patch if there were an
> ack or two from more PPC folk...)
Yeah, that would be good.
Jocke
prev parent reply other threads:[~2008-05-01 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:37 [patch 2.6.25-git] spi_mpc83xx much improved driver David Brownell
[not found] ` <200804301537.07965.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-04-30 22:46 ` Andrew Morton
[not found] ` <20080430154631.b86797de.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-30 22:55 ` David Brownell
[not found] ` <200804301555.34110.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-05-01 10:42 ` Joakim Tjernlund
2008-05-01 10:42 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1924.82319330356$1209638659@news.gmane.org' \
--to=joakim.tjernlund@transmode.se \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).