From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org,
joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
Date: Wed, 30 Apr 2008 15:46:31 -0700 [thread overview]
Message-ID: <20080430154631.b86797de.akpm@linux-foundation.org> (raw)
In-Reply-To: <200804301537.07965.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Wed, 30 Apr 2008 15:37:07 -0700
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> From: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
> Date: Fri, 11 Apr 2008 18:57:21 +0200
> Subject: [PATCH] Much improved mpc83xx SPI driver.
>
> The current driver may cause glitches on SPI CLK line since one must
> disable the SPI controller before changing any HW settings. Fix this
> by implementing a local spi_transfer function that won't change speed
> and/or word size while CS is active.
>
> While doing that heavy lifting a few other issues were addressed too:
> - Make word size 16 and 32 work too.
> - Honor bits_per_word and speed_hz in spi transaction.
> - Optimize the common path.
>
> This also stops using the "bitbang" framework (except for a few
> constants).
>
> ...
>
> +static void mpc83xx_spi_work(struct work_struct *work)
> +{
> + struct mpc83xx_spi *mpc83xx_spi =
> + container_of(work, struct mpc83xx_spi, work);
> +
> + spin_lock_irq(&mpc83xx_spi->lock);
irq-safe.
> ...
>
> + spin_lock(&mpc83xx_spi->lock);
not irq-safe.
Deliberate?
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-30 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:37 [patch 2.6.25-git] spi_mpc83xx much improved driver David Brownell
[not found] ` <200804301537.07965.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-04-30 22:46 ` Andrew Morton [this message]
[not found] ` <20080430154631.b86797de.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-30 22:55 ` David Brownell
[not found] ` <200804301555.34110.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-05-01 10:42 ` Joakim Tjernlund
2008-05-01 10:42 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430154631.b86797de.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).