* [patch 0/2] S3C24XX SPI fixes
@ 2008-06-26 9:59 Ben Dooks
2008-06-26 9:59 ` [patch 1/2] SPI: spi_s3c24xx bus_num fixup due to missing part of previous patch Ben Dooks
2008-06-26 9:59 ` [patch 2/2] SPI: Move MOD_ALIAS in spi_s3c24xx driver Ben Dooks
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2008-06-26 9:59 UTC (permalink / raw)
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: david-b-yBeKhBN/0LDR7s880joybQ
These two patches are fixes for the s3c24xx spi
driver, the first one seems to have been lost in
the noise, the second is a module alias fix for
the driver.
The patches are suitable for inclusion as soon as
possible.
--
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch 1/2] SPI: spi_s3c24xx bus_num fixup due to missing part of previous patch
2008-06-26 9:59 [patch 0/2] S3C24XX SPI fixes Ben Dooks
@ 2008-06-26 9:59 ` Ben Dooks
2008-06-26 9:59 ` [patch 2/2] SPI: Move MOD_ALIAS in spi_s3c24xx driver Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2008-06-26 9:59 UTC (permalink / raw)
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: david-b-yBeKhBN/0LDR7s880joybQ, Ben Dooks
[-- Attachment #1: simtec/simtec-drivers-spi-s3c24xx-busnum.patch --]
[-- Type: text/plain, Size: 1874 bytes --]
The original "Pass the bus number we expect the S3C24XX SPI driver to attach
to via the platform data." [1] patch was mis-sent, and missed two important
parts of the diff, which was to actually set the bus_num field and add
the relevant field to the platform data.
[1] git commit 50f426b55d919dd017af35bb6a08753d1f262920
Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Index: linux-2.6.25-quilt3/include/asm-arm/arch-s3c2410/spi.h
===================================================================
--- linux-2.6.25-quilt3.orig/include/asm-arm/arch-s3c2410/spi.h 2008-04-18 11:34:07.000000000 +0100
+++ linux-2.6.25-quilt3/include/asm-arm/arch-s3c2410/spi.h 2008-04-18 11:36:15.000000000 +0100
@@ -16,6 +16,7 @@
struct s3c2410_spi_info {
unsigned long pin_cs; /* simple gpio cs */
unsigned int num_cs; /* total chipselects */
+ int bus_num; /* bus number to use. */
void (*set_cs)(struct s3c2410_spi_info *spi, int cs, int pol);
};
Index: linux-2.6.25-quilt3/drivers/spi/spi_s3c24xx.c
===================================================================
--- linux-2.6.25-quilt3.orig/drivers/spi/spi_s3c24xx.c 2008-04-18 11:36:30.000000000 +0100
+++ linux-2.6.25-quilt3/drivers/spi/spi_s3c24xx.c 2008-04-18 11:39:10.000000000 +0100
@@ -270,6 +270,7 @@ static int __init s3c24xx_spi_probe(stru
/* setup the master state. */
master->num_chipselect = hw->pdata->num_cs;
+ master->bus_num = pdata->bus_num;
/* setup the state for the bitbang driver */
--
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch 2/2] SPI: Move MOD_ALIAS in spi_s3c24xx driver.
2008-06-26 9:59 [patch 0/2] S3C24XX SPI fixes Ben Dooks
2008-06-26 9:59 ` [patch 1/2] SPI: spi_s3c24xx bus_num fixup due to missing part of previous patch Ben Dooks
@ 2008-06-26 9:59 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2008-06-26 9:59 UTC (permalink / raw)
To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: david-b-yBeKhBN/0LDR7s880joybQ, Ben Dooks
[-- Attachment #1: simtec/simtec-drivers-spi-s3c24xx-modalias.patch --]
[-- Type: text/plain, Size: 1321 bytes --]
Unite the MODULE_ALIAS() declaration with the rest of
the MODULE_* definitions.
Signed-off-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Index: linux-2.6.25-quilt3/drivers/spi/spi_s3c24xx.c
===================================================================
--- linux-2.6.25-quilt3.orig/drivers/spi/spi_s3c24xx.c 2008-04-18 11:40:15.000000000 +0100
+++ linux-2.6.25-quilt3/drivers/spi/spi_s3c24xx.c 2008-04-18 11:41:37.000000000 +0100
@@ -424,7 +424,6 @@ static int s3c24xx_spi_resume(struct pla
#define s3c24xx_spi_resume NULL
#endif
-MODULE_ALIAS("platform:s3c2410-spi");
static struct platform_driver s3c24xx_spidrv = {
.remove = __exit_p(s3c24xx_spi_remove),
.suspend = s3c24xx_spi_suspend,
@@ -451,3 +450,4 @@ module_exit(s3c24xx_spi_exit);
MODULE_DESCRIPTION("S3C24XX SPI Driver");
MODULE_AUTHOR("Ben Dooks, <ben-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:s3c2410-spi");
--
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-26 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-26 9:59 [patch 0/2] S3C24XX SPI fixes Ben Dooks
2008-06-26 9:59 ` [patch 1/2] SPI: spi_s3c24xx bus_num fixup due to missing part of previous patch Ben Dooks
2008-06-26 9:59 ` [patch 2/2] SPI: Move MOD_ALIAS in spi_s3c24xx driver Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).